Re: Coro patch

2011-12-12 Thread Christian Thalinger
On Nov 30, 2011, at 11:37 AM, Lukas Stadler wrote: > On 2011-11-30 11:20, Charles Oliver Nutter wrote: >> On Wed, Nov 30, 2011 at 4:17 AM, Lukas Stadler wrote: >>> Hm, maybe... the fix was really just a tiny tiny bugfix, so that >>> shouldn't have caused any performance regressions, although, of

Re: Coro patch

2011-11-30 Thread Charles Oliver Nutter
On Wed, Nov 30, 2011 at 11:57 AM, Mark Roos wrote: > Hi Charles > > Interesting results.  Is your code for the coro implementation available > somewhere > to look at? On master and jruby-1_6 branch, under src/org/jruby/ext/fiber/CoroutineFiber.java. It's Lukas's code, mostly. https://github.com/

Re: Coro patch

2011-11-30 Thread Mark Roos
Hi Charles Interesting results. Is your code for the coro implementation available somewhere to look at? thanks mark___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

Re: Coro patch

2011-11-30 Thread Lukas Stadler
On 2011-11-30 11:20, Charles Oliver Nutter wrote: > On Wed, Nov 30, 2011 at 4:17 AM, Lukas Stadler wrote: >> Hm, maybe... the fix was really just a tiny tiny bugfix, so that >> shouldn't have caused any performance regressions, although, of course, >> I can't say for sure. >> But maybe something i

Re: Coro patch

2011-11-30 Thread Charles Oliver Nutter
On Wed, Nov 30, 2011 at 4:17 AM, Lukas Stadler wrote: > Hm, maybe... the fix was really just a tiny tiny bugfix, so that > shouldn't have caused any performance regressions, although, of course, > I can't say for sure. > But maybe something in invokedynamic has changed so that it's impacted > by c

Re: Coro patch

2011-11-30 Thread Lukas Stadler
On 2011-11-30 08:49, Charles Oliver Nutter wrote: > Seconds after I email...A DISCOVERY... > > It seems like invokedynamic is causing headaches for coro. Here's the > numbers with coro fibers and JRuby's invokedynamic support turned > *off*: > > 100 fibers / 1000 passes: 0.076000 0.00 0.0

Re: Coro patch

2011-11-29 Thread Charles Oliver Nutter
Seconds after I email...A DISCOVERY... It seems like invokedynamic is causing headaches for coro. Here's the numbers with coro fibers and JRuby's invokedynamic support turned *off*: 100 fibers / 1000 passes: 0.076000 0.00 0.076000 ( 0.077000) 100 fibers / 1000 passes: 0.076000 0.00

Re: Coro patch

2011-11-29 Thread Charles Oliver Nutter
Ok, good news and not as good news! The good news is that coro seems to be working in the latest openjdk-osx-build, and it definitely improves JRuby's coroutine performance! For running bench_fiber_ring with 100 fibers passing 1000 messages, here's numbers for the threaded impl: 100 fibers / 100

Re: Coro patch

2011-11-29 Thread Henri Gomez
> Awesome, thanks Lukas! > > Hopefully when the next openjdk-osx-build runs, it will pick up these > changes, and we'll have a working coro impl on OS X too :) Oops, forgot to tweet about it yesterday. http://openjdk-osx-build.googlecode.com/files/OpenJDK-1.8-x86_64-b11-2029-release.dmg Chee

Re: Coro patch

2011-11-29 Thread Charles Oliver Nutter
Awesome, thanks Lukas! Hopefully when the next openjdk-osx-build runs, it will pick up these changes, and we'll have a working coro impl on OS X too :) - Charlie On Tue, Nov 29, 2011 at 6:58 AM, Lukas Stadler wrote: > Uh, sorry for the long wait... > That was another problem that occurs with in

Re: Coro patch

2011-11-29 Thread Lukas Stadler
Uh, sorry for the long wait... That was another problem that occurs with invokedynamic, in particular with ricochet frames. I fixed it, pushed the changes and uploaded a new binary to http://ssw.jku.at/General/Staff/LS/coro/. - Lukas On 2011-11-07 00:18, Charles Oliver Nutter wrote: Ok, bug

Re: Coro patch

2011-11-06 Thread Henri Gomez
Note about the build env for this package. Done under OSX 10.6.8, XCode 4, gcc/g++ 4.2 (not llvm 4.2). 2011/11/7 Charles Oliver Nutter : > Ok, bug report time! :) > > It looks like it's crashing again once Hotspot JITs. > > This works: > > jruby --1.9 -Xfiber.coroutines=true bench/bench_fiber_rin

Re: Coro patch

2011-11-06 Thread Charles Oliver Nutter
Ok, bug report time! :) It looks like it's crashing again once Hotspot JITs. This works: jruby --1.9 -Xfiber.coroutines=true bench/bench_fiber_ring.rb 10 100 100 But this doesn't: jruby --1.9 -Xfiber.coroutines=true bench/bench_fiber_ring.rb 10 1000 100 Here's the console output, and I've att

Re: Coro patch

2011-11-06 Thread Henri Gomez
Ok, I get them and coro is included in OpenJDK 8 from openjdk-osx-build 2011/11/6 Henri Gomez : > > > Le 6 nov. 2011 à 22:12, Henri Gomez a écrit : > >> Hi to all, >> >> I'm looking for Coro patch by Lukas Stadler, any body knows where I can find >> it ? > > More on this, I found patch here > (

Re: Coro patch

2011-11-06 Thread Lukas Stadler
Yes, I do :-) The patch is part of the mlvm patch repository: http://hg.openjdk.java.net/mlvm/mlvm (see instructions at http://wikis.sun.com/display/mlvm/Home) ... but if you don't want to build the jdk yourself there's a pre-built binary at: http://ssw.jku.at/General/Staff/LS/coro/ - Lukas On

Re: coro patch issue

2010-05-12 Thread Tuolin Chen
Hi Lukas, Thanks for the info. I've also noticed that after looking deeper into the source code. the 32 bit build works great! Looking forward to your 64 bit patch. Best, --Tuolin On Thu, May 13, 2010 at 12:07 AM, Lukas Stadler wrote: > Hi! > > Ok, I see... 64-bit support is something that I'm

Re: coro patch issue

2010-05-12 Thread Lukas Stadler
Hi! Ok, I see... 64-bit support is something that I'm working on right now, I probably should've put in an assertion to make that clear. Sorry! It'll be finished in a week or so. (why are there different java calling conventions in linux and windows? argh...) I hope you're ok with using the 3

Re: coro patch issue

2010-05-11 Thread Tuolin Chen
On Wed, May 12, 2010 at 6:07 AM, John Rose wrote: > On May 11, 2010, at 7:45 AM, Tuolin Chen wrote: > > > I'm new to mlvm and I'm trying to get Lukas' coro.patch to work. > > > > I grabbed the source and patches according to openjdk and mlvm build > instructions. Everything is done on my laptop r

Re: coro patch issue

2010-05-11 Thread John Rose
On May 11, 2010, at 7:45 AM, Tuolin Chen wrote: > I'm new to mlvm and I'm trying to get Lukas' coro.patch to work. > > I grabbed the source and patches according to openjdk and mlvm build > instructions. Everything is done on my laptop running Ubuntu 10.04 64bit > version. Only coro patch is ap