Chris, sorry for the late reply.
Here's a version with the new naming scheme:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.03.naming
I like existing naming scheme and OBJECT/VOID/LONG/etc names are quite popular(e.g.
Wrapper ASM (Opcodes) use them).
Of course they are popular
On Apr 8, 2014, at 1:53 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Thanks, Chris.
I have to do one more iteration:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.05/
I have to revert changes related to BMH::reinvokerTarget.
Removal of reinvokerTarget in generated
On Apr 3, 2014, at 9:44 PM, John Rose john.r.r...@oracle.com wrote:
On Apr 3, 2014, at 6:33 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
Of course they are popular because these are the type names. There is no
type L; it’s an object. I don’t understand why we have to
On Mar 26, 2014, at 8:01 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Here's a version with the new naming scheme:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.03.naming
I like existing naming scheme and OBJECT/VOID/LONG/etc names are quite
popular(e.g. Wrapper ASM
On Apr 3, 2014, at 6:33 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
Of course they are popular because these are the type names. There is no
type L; it’s an object. I don’t understand why we have to use different
names just because they are used in other namespaces.
Hi Vladimir,
This looks good. Minor stuff below.
I too prefer *_TYPE instead of Int/Float/Void etc as those are not v. friendly
for static imports.
Paul.
LambaForm:
--
private static int fixResult(int result, Name[] names) {
if (result == LAST_RESULT)
result =
Paul, thanks for review.
Updated webrev:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.04/
Best regards,
Vladimir Ivanov
On 4/1/14 1:44 PM, Paul Sandoz wrote:
Hi Vladimir,
This looks good. Minor stuff below.
I too prefer *_TYPE instead of Int/Float/Void etc as those are not v.
On Apr 1, 2014, at 3:57 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Paul, thanks for review.
Updated webrev:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.04/
+1
Paul.
signature.asc
Description: Message signed with OpenPGP using GPGMail
Thank you, Paul.
Best regards,
Vladimir Ivanov
On 4/1/14 7:42 PM, Paul Sandoz wrote:
On Apr 1, 2014, at 3:57 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Paul, thanks for review.
Updated webrev:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.04/
+1
Paul.
Updated version:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.03/
- changed the way how arrays of types are created:
static final BasicType[] ALL_TYPES = BasicType.values();
static final BasicType[] ARG_TYPES = Arrays.copyOf(ALL_TYPES,
ALL_TYPES.length-1);
- added a
Chris,
Thanks for the feedback.
What do you think about the following:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.01/
Best regards,
Vladimir Ivanov
On 3/19/14 5:18 AM, Christian Thalinger wrote:
On Mar 18, 2014, at 2:35 PM, John Rose john.r.r...@oracle.com
On Mar 21, 2014, at 8:49 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Thanks for the feedback.
What do you think about the following:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.01/
That looks nice. Strong typing; who woulda' thunk it. :-)
The uses of .ordinal() are
On 03/21/2014 07:54 PM, John Rose wrote:
On Mar 21, 2014, at 8:49 AM, Vladimir Ivanov
vladimir.x.iva...@oracle.com mailto:vladimir.x.iva...@oracle.com
wrote:
Thanks for the feedback.
What do you think about the following:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.01/
John, thanks for the feedback.
Updated webrev:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.02
Also moved LambdaForm.testShortenSignature() into a stand-alone unit test.
Best regards,
Vladimir Ivanov
On 3/21/14 10:54 PM, John Rose wrote:
On Mar 21, 2014, at 8:49 AM, Vladimir Ivanov
On Mar 14, 2014, at 4:28 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8037210
953 lines changed: 425 ins; 217 del; 311 mod
This is a massive cleanup of JSR292 code to replace
On Mar 18, 2014, at 1:36 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
Why are we not using an Enum instead of an untyped byte?
Byte is moderately typed, in the sense (which I rely on during development)
that you can't assign an int or char to a byte w/o a cast.
That's why it
On Mar 18, 2014, at 2:35 PM, John Rose john.r.r...@oracle.com wrote:
On Mar 18, 2014, at 1:36 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
Why are we not using an Enum instead of an untyped byte?
Byte is moderately typed, in the sense (which I rely on during
17 matches
Mail list logo
