Re: jdk7 b58, VM doesn't smell good

2009-05-11 Thread Rémi Forax
Chanwit Kaewkasi a écrit : > Hi Remi, > > I am running John's FidgetDemo with b58 and everything is fine. > > I am using -XX:+EnableInvokeDynamic. > I compile the program with -target 7. > > Perhaps, I'll try your program posted here and see if I get the same error. > > Cheers, > > Chanwit > It

Re: jdk7 b58, VM doesn't smell good

2009-05-11 Thread Rémi Forax
Rémi Forax a écrit : > Chanwit Kaewkasi a écrit : > >> Hi Remi, >> >> I am running John's FidgetDemo with b58 and everything is fine. >> >> I am using -XX:+EnableInvokeDynamic. >> I compile the program with -target 7. >> >> Perhaps, I'll try your program posted here and see if I get the same er

I would like to discuss the MethodHandles factory

2009-05-11 Thread Fredrik Öhrström
where adapter code is generated by calling for example MethodHandles.appendArgument(). I am not entirely comfortable with this construction. Mostly because JRockit does not have an interpreter. So, following a recommendation from John, that I should blog about jsr292. :-) Here is the link: http://

Re: I would like to discuss the MethodHandles factory

2009-05-11 Thread Rémi Forax
Fredrik Öhrström a écrit : > where adapter code is generated by calling for example > MethodHandles.appendArgument(). I am not entirely comfortable with this > construction. Mostly because JRockit does not have an interpreter. > > So, following a recommendation from John, that I should blog about >

Re: jdk7 b58, VM doesn't smell good

2009-05-11 Thread John Rose
When experimenting with invokedynamic or even just method handles, always compile with -target 7 (or -XDinvokedynamic) and run with -XX: +EnableInvokeDynamic. These defaults will get better when the EG converges on the spec. The API docs don't get built, and javac claims that java.dyn doesn

Re: jdk7 b58, VM doesn't smell good

2009-05-11 Thread John Rose
I'm looking at your AbstractVisitor code in detail, and there's one possible bug in it. The inner class Main0$1 is package-private (per inner class spec) which means that AbstractVisitor should not be able to access the 'visit' methods, even though they are public. Therefore, you do need