Re: Still crashity crashing

2009-08-06 Thread Rémi Forax
Le 06/08/2009 02:40, Charles Oliver Nutter a écrit : On Wed, Aug 5, 2009 at 7:30 PM, Rémi Forax wrote: I have seen some small rooms of improvement in the JRuby code (apart from replacing DynamicMethod by MethodHandle which is what must be done but which is also in my opinion a more than

Re: Still crashity crashing

2009-08-06 Thread Charles Oliver Nutter
On Thu, Aug 6, 2009 at 9:35 AM, Rémi Forax wrote: > You should try to cache the method handle in the DynamicMethod > to reuse the same MH for several call sites. Yeah, good call. I'll have to store it at Object, though, since we want a single codebase to work for Java 5+. But caching it shouldn't

Re: Mangled names for invokedynamic

2009-08-06 Thread John Rose
That looks like a bug in BytecodeName.parseBytecodeName. The 'new String' shortly after the error point should have been 'new Object'. Time for more unit testing! -- John ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.

Re: Mangled names for invokedynamic

2009-08-06 Thread John Rose
I just pushed some fixes and unit tests for mangling. Thanks for the report! -- John On Aug 1, 2009, at 1:25 PM, Attila Szegedi wrote: > Folks (well, primarily John I think), > > I'm trying to write a testcase for an invokedynamic call that > specifies "dyn:getprop:helloText" as the method

hg: mlvm/mlvm: meth: sun.dyn.util.BytecodeName passes unit tests

2009-08-06 Thread john . rose
Changeset: f0e76a3fe55d Author:jrose Date: 2009-08-06 18:04 -0700 URL: http://hg.openjdk.java.net/mlvm/mlvm/rev/f0e76a3fe55d meth: sun.dyn.util.BytecodeName passes unit tests + netbeans/meth/test/sun/dyn/util/BytecodeNameTest.java ___ ml

hg: mlvm/mlvm/jdk: meth: sun.dyn.util.BytecodeName passes unit tests

2009-08-06 Thread john . rose
Changeset: a734350b0b96 Author:jrose Date: 2009-08-06 18:05 -0700 URL: http://hg.openjdk.java.net/mlvm/mlvm/jdk/rev/a734350b0b96 meth: sun.dyn.util.BytecodeName passes unit tests ! indy.patch ___ mlvm-dev mailing list mlvm-dev@openjdk.ja