Re: Hotswap patch?

2009-09-16 Thread Patrick Wright
Thanks for the links to the Wiki and PDF. It looks like a lot of what we've been asking for. Thomas--is any special flag required to enable this when launching the JVM if I build MLVM with your changeset in it? Also, I assume that if classes are redefined we will eventually run into the standard p

Re: still no fun with invokedynamic

2009-09-16 Thread John Rose
το Sep 13, 2009, επι τῳ 6:53 AM, Rémi Forax εγραψα: > Le 13/09/2009 02:38, John Rose a écrit : >> >> The backport a great option for experimentation, since it does not >> require a pre-release JVM. Its performance seems to be comparable >> to the current MLVM JVM. Basically what you get is a

adapter pushes too many parameters

2009-09-16 Thread Christian Thalinger
Hi! I just wanted to write a testcase with an invokedynamic that takes 6 arguments, like: sum += InvokeDynamic.unknown(i, i, i, i, i, i); and I get: java.lang.IllegalArgumentException: bad adapter (conversion=0xfffab300): adapter pushes too many parameters Increasing the MethodHandlePushLi

Re: adapter pushes too many parameters

2009-09-16 Thread John Rose
On Sep 16, 2009, at 3:13 AM, Christian Thalinger wrote: > I just wanted to write a testcase with an invokedynamic that takes 6 > arguments, like: > > sum += InvokeDynamic.unknown(i, i, i, i, i, i); > > and I get: > > java.lang.IllegalArgumentException: bad adapter > (conversion=0xfffab300): adap

Re: adapter pushes too many parameters

2009-09-16 Thread Christian Thalinger
John Rose wrote: > On Sep 16, 2009, at 3:13 AM, Christian Thalinger wrote: > >> I just wanted to write a testcase with an invokedynamic that takes 6 >> arguments, like: >> >> sum += InvokeDynamic.unknown(i, i, i, i, i, i); >> >> and I get: >> >> java.lang.IllegalArgumentException: bad adapter >>

Re: adapter pushes too many parameters

2009-09-16 Thread Christian Thalinger
Christian Thalinger wrote: >> But, I think increasing the MHPL should allow the additional number of >> bound params to be pushed. So that final error looks like a plain bug. > > I will try to comment it out. Commenting this check: if (slots_pushed + target_pushes > MethodHandlePushLimit)

insertArguments asserts

2009-09-16 Thread Christian Thalinger
Hi (John)! While writing some tests for the compiler I stumbled over this assert in the interpreter: # Internal Error (/Users/twisti/mlvm/hotspot/src/share/vm/runtime/sharedRuntime.cpp:591), pid=19342, tid=2690041632 # Error: guarantee(cb->is_adapter_blob(),"exception happened outside interpret