Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Christian Thalinger
On Apr 4, 2011, at 10:34 AM, Gary Benson wrote: > John Rose wrote: >> On Apr 1, 2011, at 7:33 AM, Gary Benson wrote: >>> This webrev adds support for JSR 292 to Zero: >>> >>> http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ >> >> Most impressive! I think this matches the following previously

Re: new Mac OS X mlvm build: 2011_04_04

2011-04-05 Thread Ola Bini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stephen et al, I did a new build with the indy patch sets yesterday. Just as with your build it passes tests and works even though the two files doesn't merge correctly. However, this simple test: import java.lang.invoke.SwitchPoint; public class Dy

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Gary Benson
Christian Thalinger wrote: > On Apr 4, 2011, at 10:34 AM, Gary Benson wrote: > > John Rose wrote: > > > On Apr 1, 2011, at 7:33 AM, Gary Benson wrote: > > > > This webrev adds support for JSR 292 to Zero: > > > > > > > > http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ > > > > > > Most impress

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Gary Benson
Christian Thalinger wrote: > On Apr 1, 2011, at 4:33 PM, Gary Benson wrote: > > This webrev adds support for JSR 292 to Zero: > > > > http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ > > hotspot/src/cpu/zero/vm/cppInterpreter_zero.cpp: > > +// NB the x86 code for this (in methodHandles_x

Re: new Mac OS X mlvm build: 2011_04_04

2011-04-05 Thread Rémi Forax
Basically in constant() bindTo(x) should be replaced by insertArguments(0, x) Because bindTo requires that the first argument is an object. Here it's a boolean. Rémi On 04/05/2011 02:55 PM, Ola Bini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Stephen et al, > > I did a new build

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Christian Thalinger
On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: > Christian Thalinger wrote: >> On Apr 1, 2011, at 4:33 PM, Gary Benson wrote: >>> This webrev adds support for JSR 292 to Zero: >>> >>> http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ >> >> hotspot/src/cpu/zero/vm/cppInterpreter_zero.cpp: >> >>

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Gary Benson
Christian Thalinger wrote: > On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: > > Christian Thalinger wrote: > > > hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp: > > > > > > + assert(false, "Should have thrown incompatible class change > > > exception"); > > > > > > I'd use Sho

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Christian Thalinger
On Apr 5, 2011, at 4:32 PM, Gary Benson wrote: > Christian Thalinger wrote: >> On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: >>> Christian Thalinger wrote: hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp: + assert(false, "Should have thrown incompatible class chan

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Gary Benson
Christian Thalinger wrote: > On Apr 5, 2011, at 4:32 PM, Gary Benson wrote: > > Christian Thalinger wrote: > > > On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: > > > > Christian Thalinger wrote: > > > > > hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp: > > > > > > > > > > + asse

Re: new Mac OS X mlvm build: 2011_04_04

2011-04-05 Thread Ola Bini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-04-05 09.07, Rémi Forax wrote: > Basically in constant() bindTo(x) should be replaced by > insertArguments(0, x) > Because bindTo requires that the first argument is an object. > Here it's a boolean. So basically you're saying that this line:

Re: new Mac OS X mlvm build: 2011_04_04

2011-04-05 Thread Mark Roos
Thanks, ti really helps alot mark___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev