Re: [9] RFR (M): 8027827: Improve performance of catchException combinator

2014-02-21 Thread Paul Sandoz
On Feb 20, 2014, at 6:57 PM, Vladimir Ivanov wrote: > Paul, > > Thanks for the feedback! See my answers inline. > > Updated webrev: > http://cr.openjdk.java.net/~vlivanov/8027827/final/webrev.01/ > > I finally figured out how to make caching work. This webrev contains these > changes. > +

Re: [9] RFR (M): 8027827: Improve performance of catchException combinator

2014-02-21 Thread Vladimir Ivanov
Paul, thanks! Best regards, Vladimir Ivanov On 2/21/14 2:11 PM, Paul Sandoz wrote: > > On Feb 20, 2014, at 6:57 PM, Vladimir Ivanov > wrote: > >> Paul, >> >> Thanks for the feedback! See my answers inline. >> >> Updated webrev: >> http://cr.openjdk.java.net/~vlivanov/8027827/final/webrev.01/ >>

Re: [9] RFR (M): 8027827: Improve performance of catchException combinator

2014-02-21 Thread Remi Forax
Hi Valdimir, is there a reason to generate try { ... } catch(Throwable t) { if (Klass.isInstance(t)) { ... } throw t; } instead of: try { ... } catch(Klass t) { ... } maybe because the Klass can be resolved by the wrong classloader ? Rémi On

Re: [9] RFR (M): 8027827: Improve performance of catchException combinator

2014-02-21 Thread Vladimir Ivanov
Remi, Yes, one reason is resolution peculiarities of exception class not located on boot classpath. The other reason is enabling extensive sharing of lambda forms. Best regards, Vladimir Ivanov On 2/21/14 4:33 PM, Remi Forax wrote: > Hi Valdimir, > is there a reason to generate > try { >

Re: [9] RFR (M): 8027827: Improve performance of catchException combinator

2014-02-21 Thread Christian Thalinger
On Feb 20, 2014, at 9:57 AM, Vladimir Ivanov wrote: > Paul, > > Thanks for the feedback! See my answers inline. > > Updated webrev: > http://cr.openjdk.java.net/~vlivanov/8027827/final/webrev.01/ > > I finally figured out how to make caching work. This webrev contains > these changes. > >