Hi Vladimir,
This looks good. Minor stuff below.
I too prefer *_TYPE instead of Int/Float/Void etc as those are not v. friendly
for static imports.
Paul.
LambaForm:
--
private static int fixResult(int result, Name[] names) {
if (result == LAST_RESULT)
result = names.le
On Mar 14, 2014, at 5:36 PM, Vladimir Ivanov
wrote:
>> Doh! crossed webrevs, thanks.
>>
>> Just had a quick look, this looks like a really nice improvement to the
>> array setter/getter support, definitely simplified. IIUC the mh.viewAsType
>> will now handle the appropriate casting. I believe
Paul, thanks for review.
Updated webrev:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.04/
Best regards,
Vladimir Ivanov
On 4/1/14 1:44 PM, Paul Sandoz wrote:
Hi Vladimir,
This looks good. Minor stuff below.
I too prefer *_TYPE instead of Int/Float/Void etc as those are not v. friendly
Paul,
Unfortunately, additional profiling doesn't work for Accessor.checkCast
case. The problem is Accessor.checkCast is called from multiple places,
so type profile is very likely to be polluted. And it kills the benefits.
I don't think MethodType helps with profiling in any way. It represen
On Apr 1, 2014, at 4:10 PM, Vladimir Ivanov
wrote:
> Paul,
>
> Unfortunately, additional profiling doesn't work for Accessor.checkCast case.
> The problem is Accessor.checkCast is called from multiple places, so type
> profile is very likely to be polluted. And it kills the benefits.
>
So
On Apr 1, 2014, at 3:57 PM, Vladimir Ivanov
wrote:
> Paul, thanks for review.
>
> Updated webrev:
> http://cr.openjdk.java.net/~vlivanov/8037210/webrev.04/
>
+1
Paul.
signature.asc
Description: Message signed with OpenPGP using GPGMail
___
mlvm-
Thank you, Paul.
Best regards,
Vladimir Ivanov
On 4/1/14 7:42 PM, Paul Sandoz wrote:
On Apr 1, 2014, at 3:57 PM, Vladimir Ivanov
wrote:
Paul, thanks for review.
Updated webrev:
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.04/
+1
Paul.
_
Best regards,
Vladimir Ivanov
On 4/1/14 7:29 PM, Paul Sandoz wrote:
On Apr 1, 2014, at 4:10 PM, Vladimir Ivanov
wrote:
Paul,
Unfortunately, additional profiling doesn't work for Accessor.checkCast case.
The problem is Accessor.checkCast is called from multiple places, so type
profile i
