Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity >253 can't be cached

2014-10-01 Thread Konstantin Shefov
Hi, I have updated the webrev: http://cr.openjdk.java.net/~kshefov/8058695/webrev.01 Also I will move fix to JDK-8058733 to other request. -Konstantin On 24.09.2014 19:54, Konstantin Shefov wrote: Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058695 Webr

Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity >253 can't be cached

2014-10-01 Thread Vladimir Ivanov
Good. Best regards, Vladimir Ivanov On 10/1/14, 4:20 PM, Konstantin Shefov wrote: Hi, I have updated the webrev: http://cr.openjdk.java.net/~kshefov/8058695/webrev.01 Also I will move fix to JDK-8058733 to other request. -Konstantin On 24.09.2014 19:54, Konstantin Shefov wrote: Hello, Ple

Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity >253 can't be cached

2014-10-01 Thread Igor Ignatyev
Hi Konstantin, 0. could you please introduce a ctor which sets the default value for 'maxArity' and use it instead of explicitly passed 'Helper.MAX_ARITY'? 1. there is a existing solution for your case w/ access to an private field of an outer class: > int desiredArity = Helper.RNG.nextInt(super

Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity >253 can't be cached

2014-10-01 Thread Konstantin Shefov
Thanks for reviewing http://cr.openjdk.java.net/~kshefov/8058695/webrev.02 -Konstantin On 01.10.2014 17:30, Igor Ignatyev wrote: Hi Konstantin, 0. could you please introduce a ctor which sets the default value for 'maxArity' and use it instead of explicitly passed 'Helper.MAX_ARITY'? 1. ther

Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity >253 can't be cached

2014-10-01 Thread Igor Ignatyev
Konstantin, +private TestMethods(String name, int maxArity) { +this.name = name; +this.maxArity = maxArity; +} + private TestMethods(String name) { this.name = name; +this.maxArity = Helper.MAX_ARITY; } please call TestMethods(String, int) fro