Re: [9] RFR (S): 8075263: MHI::checkCustomized isn't eliminated for inlined MethodHandles

Good. thanks, Vladimir K On 3/16/15 12:05 PM, John Rose wrote: Reviewed. — John On Mar 16, 2015, at 11:47 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com wrote: http://cr.openjdk.java.net/~vlivanov/8075263/webrev.00/hotspot http://cr.openjdk.java.net/~vlivanov/8075263/webrev.00/jdk

Re: [9] RFR (S): 8074548: Never-taken branches cause repeated deopts in MHs.GWT case

You already have 'result' variable for argument(0), why reread?: CmpINode(argument(0) Usually IfTrue is the fast path. IGVN will revert that check to have that. But it is better to have it in code. Current code looks like double negation. There is no explanation in changes why false_count

Re: [9] RFR (S): 8074548: Never-taken branches cause repeated deopts in MHs.GWT case

Good fix, thanks. — John P.S. I noticed a typo: it's (contraction of it is) should be its (genitive of it). On Mar 16, 2015, at 11:26 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com wrote: http://cr.openjdk.java.net/~vlivanov/8074548/webrev.00/

[9] RFR (S): 8075263: MHI::checkCustomized isn't eliminated for inlined MethodHandles

http://cr.openjdk.java.net/~vlivanov/8075263/webrev.00/hotspot http://cr.openjdk.java.net/~vlivanov/8075263/webrev.00/jdk https://bugs.openjdk.java.net/browse/JDK-8075263 When MethodHandle is a compile-time constant and it is inlined in MethodHandle.invoke/invokeExact there's no need in

Re: [9] RFR (S): 8075263: MHI::checkCustomized isn't eliminated for inlined MethodHandles

Reviewed. — John On Mar 16, 2015, at 11:47 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com wrote: http://cr.openjdk.java.net/~vlivanov/8075263/webrev.00/hotspot http://cr.openjdk.java.net/~vlivanov/8075263/webrev.00/jdk https://bugs.openjdk.java.net/browse/JDK-8075263

Re: [9] RFR (S): 8074548: Never-taken branches cause repeated deopts in MHs.GWT case

Thanks, John! Will fix the typo before pushing the fix. Best regards, Vladimir Ivanov On 3/16/15 9:51 PM, John Rose wrote: Good fix, thanks. — John P.S. I noticed a typo: it's (contraction of it is) should be its (genitive of it). On Mar 16, 2015, at 11:26 AM, Vladimir Ivanov

[9] RFR (S): 8074548: Never-taken branches cause repeated deopts in MHs.GWT case

http://cr.openjdk.java.net/~vlivanov/8074548/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8074548 MethodHandleImpl::profileBoolean doesn't update never-taken branch count when hitting a deopt on it. As a result, for rarely taken branches consequent compilations consider them as

Re: [9] RFR (S): 8075263: MHI::checkCustomized isn't eliminated for inlined MethodHandles

Thanks, John! Best regards, Vladimir Ivanov On 3/16/15 10:05 PM, John Rose wrote: Reviewed. — John On Mar 16, 2015, at 11:47 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com wrote: http://cr.openjdk.java.net/~vlivanov/8075263/webrev.00/hotspot