Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow

2014-11-05 Thread Vladimir Ivanov
Claes, Thanks for spotting this inefficiency. New webrev: http://cr.openjdk.java.net/~redestad/8062180/webrev.01 The new code catches the case when a collector is erroneously removed, but not when a new one is introduced. Can you extract verification logic into separate method and check

Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow

2014-11-05 Thread Vladimir Ivanov
Looks good. Best regards, Vladimir Ivanov On 11/5/14, 8:22 PM, Claes Redestad wrote: Hi Vladimir, On 11/05/2014 01:47 PM, Vladimir Ivanov wrote: Claes, Thanks for spotting this inefficiency. New webrev: http://cr.openjdk.java.net/~redestad/8062180/webrev.01 The new code catches the case

Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow

2014-11-05 Thread Claes Redestad
Hi Vladimir, On 11/05/2014 01:47 PM, Vladimir Ivanov wrote: Claes, Thanks for spotting this inefficiency. New webrev: http://cr.openjdk.java.net/~redestad/8062180/webrev.01 The new code catches the case when a collector is erroneously removed, but not when a new one is introduced. Can you