RE: 8184777: Factor out species generation logic from BoundMethodHandle

2017-11-13 Thread Christoph Dreis
Hey Claes, though far away from being an expert on the subject matter, I have some very minor comments if you don't mind. ClassSpecializer.java L510: * For example, a concrete species for two reference and one integral bound values have a shape like the following: Should be imho: L510: * For

RFR: 8184777: Factor out species generation logic from BoundMethodHandle

2017-11-13 Thread Claes Redestad
Hi,  this patch factors out the BoundMethodHandle species data class generation to a new ClassSpecializer facility.  While currently semantically neutral, this will make it possible to reuse the facility in other places.  Webrev: http://cr.openjdk.java.net/~redestad/8184777/open.00/  Bug:

Re: RFR: 8184777: Factor out species generation logic from BoundMethodHandle

2017-11-13 Thread Vladimir Ivanov
Looks good! Best regards, Vladimir Ivanov On 11/13/17 7:34 PM, Claes Redestad wrote: Hi,  this patch factors out the BoundMethodHandle species data class generation to a new ClassSpecializer facility.  While currently semantically neutral, this will make it possible to reuse the facility

Re: RFR: 8184777: Factor out species generation logic from BoundMethodHandle

2017-11-13 Thread Claes Redestad
Thanks Vladimir! /Claes On 2017-11-13 17:38, Vladimir Ivanov wrote: Looks good! Best regards, Vladimir Ivanov On 11/13/17 7:34 PM, Claes Redestad wrote: Hi,   this patch factors out the BoundMethodHandle species data class generation to a new ClassSpecializer facility.   While currently