Branch: refs/heads/feature/mavenized_assembly Home: https://github.com/RestComm/Restcomm-Connect Commit: 0decf923eb9e62894a2e9826731c51da59be173e https://github.com/RestComm/Restcomm-Connect/commit/0decf923eb9e62894a2e9826731c51da59be173e Author: Yorgos Saslis <yorgos.sas...@telestax.com> Date: 2018-05-05 (Sat, 05 May 2018)
Changed paths: A release/restcomm-assembly-as7/src/main/docker/cron_files/core_crontab A release/restcomm-assembly-as7/src/main/docker/cron_files/tcpdump_crontab A release/restcomm-assembly-as7/src/main/docker/scripts/docker_do.sh A release/restcomm-assembly-as7/src/main/docker/scripts/dockercleanup.sh A release/restcomm-assembly-as7/src/main/docker/scripts/restcomm-runlevels.sh A release/restcomm-assembly-as7/src/main/docker/scripts/restcomm_autoconf.sh A release/restcomm-assembly-as7/src/main/docker/scripts/restcomm_conf.sh A release/restcomm-assembly-as7/src/main/docker/scripts/restcomm_extconf.sh A release/restcomm-assembly-as7/src/main/docker/scripts/restcomm_service.sh A release/restcomm-assembly-as7/src/main/docker/scripts/restcomm_sslconf.sh A release/restcomm-assembly-as7/src/main/docker/scripts/restcomm_tag.sh A release/restcomm-assembly-as7/src/main/docker/scripts/restcomm_toolsconf.sh A release/restcomm-assembly-as7/src/main/docker/scripts/start-restcomm.sh Log Message: ----------- Copy-pasted scripts from Restcomm-Docker project Moving them into this GH repo, so they can be included in the docker image build. As we are moving towards using the docker image as our binary (instead of just the WAR file), it makes sense to keep all those components that are used to build the image in the same repository anyway. Commit: 7daa4c6c3bfe8e18731c2e475911234ec0210611 https://github.com/RestComm/Restcomm-Connect/commit/7daa4c6c3bfe8e18731c2e475911234ec0210611 Author: Yorgos Saslis <yorgos.sas...@telestax.com> Date: 2018-05-05 (Sat, 05 May 2018) Changed paths: A release/restcomm-assembly-as7/Dockerfile_all-in-one A release/restcomm-assembly-as7/Dockerfile_standalone Log Message: ----------- Adapted Dockerfile from Restcomm-Docker project Major differences are two: 1. restcomm binary is NOT retrieved from Box, rather it is expected to be available in the local filesystem. This is because this `Dockerfile` will be used as part of the maven build, so the WAR file will (just) have been created anyway. 2. The Dockerfile now comes in 2 variants: one is `Dockerfile_standalone`, which includes *just* restcomm-connect (i.e. no mediaserver, no rvd, no webrtc-ui). As such, any mediaserver, etc. files are removed from the Dockerfile_standalone. On the other hand, the `Dockerfile_all-in-one` is a more straightforward port from `Restcomm-Docker` repo and basically just includes change (1) above and some reordering (to make continuous rebuilds of docker image faster, leveraging cached layers. Commit: b90b5863811a8b4e005dd34506a253319d32c669 https://github.com/RestComm/Restcomm-Connect/commit/b90b5863811a8b4e005dd34506a253319d32c669 Author: Yorgos Saslis <yorgos.sas...@telestax.com> Date: 2018-05-05 (Sat, 05 May 2018) Changed paths: M release/restcomm-assembly-as7/pom.xml Log Message: ----------- Split the maven build in 2 profiles `standalone` and `all-in-one` In a nutshell, the `standalone` profile includes just restcomm-connect. The `all-in-one` includes RC + RMS + RVD + WebRTC UI, just like it used to be before introducing these 2 profiles. (Eventually, we should be getting rid of this second one, but for the moment, for backwards compatibility and for moving forward with a smoother migration process, we should keep it around and just focus on improving the WAR + docker image generation on that part (in maven build, instead of `ant` + separate restcomm-docker repo). Commit: 1b6acaf287b427983b7668b42a89efcb0a968dcc https://github.com/RestComm/Restcomm-Connect/commit/1b6acaf287b427983b7668b42a89efcb0a968dcc Author: Yorgos Saslis <yorgos.sas...@telestax.com> Date: 2018-05-05 (Sat, 05 May 2018) Changed paths: M release/restcomm-assembly-as7/pom.xml Log Message: ----------- Added docker image generation through fabric8 docker maven plugin the plugin is used in each of the 2 maven profiles (`standalone` and `all-in-one`) to pick up the corresponding Dockerfile (`Dockerfile_standalone` and `Dockerfile_all-in-one`) and build the appropriate docker image (`restcomm/restcomm` and `restcomm/connect` respectively). For the moment - and this is perhaps a point for discussion - the plugin's `build` goal is bound to the `pre-integration-test` phase, as the fabric8 philosophy suggests you build a docker image (which is the resulting binary artifact from your maven build) and then you `start` it - still within the `pre-integration-test` phase - (together with all of its dependencies, e.g. database docker containers, 3rd party dependencies, etc.) so that you can then run the `verify` phase tests against the running system. There is also a binding to the plugin's `stop` goal, in the `post-integration-phase`, which tears down the above setup. I am leaving some of the above bindings commented out, on purpose, so you, oh dear reviewer, can get a better idea of how this works, in case you're not familiar. Whether we choose to adopt this setup (which in my previous experience is pretty damn awesome!! ) largely depends however on what tests we already run in the `verify` phase and whether we would care to move some to other phases - or even other jenkins pipeline stages. If we don't want to adopt the above approach, then we can consider binding the docker image creation in some other phase of mvn lifecycle. Commit: bb39fa4727d0fc0f94caf850b45963189036d920 https://github.com/RestComm/Restcomm-Connect/commit/bb39fa4727d0fc0f94caf850b45963189036d920 Author: Yorgos Saslis <yorgos.sas...@telestax.com> Date: 2018-05-05 (Sat, 05 May 2018) Changed paths: M .gitignore Log Message: ----------- Ensure we don't commit anything we shouldn't Commit: 93dd05c149b200859fce8cd8258dbdbbb4646f6c https://github.com/RestComm/Restcomm-Connect/commit/93dd05c149b200859fce8cd8258dbdbbb4646f6c Author: Yorgos Saslis <yorgos.sas...@telestax.com> Date: 2018-05-05 (Sat, 05 May 2018) Changed paths: M restcomm/pom.xml Log Message: ----------- Fixed duplicate module definition Compare: https://github.com/RestComm/Restcomm-Connect/compare/5b2caf4506de...93dd05c149b2 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. -- --- You received this message because you are subscribed to the Google Groups "mobicents-commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to mobicents-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.