Re: A consistent listener implementation

2014-05-06 Thread James Hugman
My initial response that any generalization of Event Listening is indistinguishable from an EventBus. I'm generally in favour of EventBuses, but would raise two points which have bitten me in the past: * if the event bus / generalized listener manager is does not handle threading, then this

Re: A consistent listener implementation

2014-05-07 Thread James Hugman
I don't know. I like easy to create messages. Creating a calss for all message types is Java's way of adding coupling back into an event bus. B Java! Agreed. However, I prefer annotated methods over a generic single method interface: i.e. the event bus should do the routing to the method tha

Re: [psa] JSONObject.optString doesn't do what you think it does

2014-05-23 Thread James Hugman
Hi, mfd As another datapoint: the Obj-C category `NSObject+NSJSON` treats nulls as a separate object type: `NSNull`, and all instances are `NSNull.null`. Instances of JS's undefined is represented with the equivalent of Java's `null`: `nil`. This is only possible because of Objective-C's loos

Re: Testing packaged app?

2014-06-23 Thread James Hugman
Added the links to your answer, and voted your answer up, so you have more than 10 rep. On 6/23/14, 11:31 AM, Myk Melez wrote: Felix E. Klee 2014 June 23 at 07:11 Also asked on Stack Overflow:

Re: On abstracting away WKWebView

2014-12-12 Thread James Hugman
+100 on using WKWebView over UIWebView. Apple, unlike Oracle and Sun, are serious about deprecation and removal. My 2 cents: * when the majority of developers are learning most about a new platform, we should hesitate to wrap new-to-us concepts in badly implemented not-new-to-us-concepts. Fi

Re: development of speech api

2014-12-24 Thread James Hugman
Hi Soumya, If you're interested in voice on Android. I'm working on https://bugzilla.mozilla.org/showdependencytree.cgi?id=1087644&hide_resolved=1 There is a patch in-flight for https://bugzilla.mozilla.org/show_bug.cgi?id=778588 . Many regards, – James On Tue, Dec 23, 2014 at 5:56 PM, Richard

Re: Swift Summit

2015-07-08 Thread James Hugman
I heard a lot of good things about the London one (was too late to get a ticket). Nominate that week as a potential work week? On Wed, Jul 8, 2015 at 5:14 AM, Wesley Johnston wrote: > I think I'm gonna sign up for this Swift Summit in San Francisco in > October: > > https://www.swiftsummit.com/

Headache Literal

2015-07-22 Thread James Hugman
iOS team – I woke up with a headache this morning which has got steadily worse, to the point where I can't work anymore. These usually last for the rest of the day. – James ___ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.

Addon sketches and ideas

2015-07-26 Thread James Hugman
Hi, I've had a bunch of experience with plugin systems before, so I've written up a set of ideas that are worth considering while we're in the honeymoon phase of 'Addons are important, and we have a blank slate' and before we've started designing anything. I have not written with any reference to

Re: Addon sketches and ideas

2015-07-27 Thread James Hugman
Thanks for the feedback. To summarize the feedback I'm getting: we're already developing a new desktop API; it'll be like Chrome's and we'd like Fennec to be able to share a lot of code with Desktop. I'm happy that we're going to be enabling easy translation of addons from Chrome to Firefox. With

Kitt browser for iOS, supports Chrome Extensions API

2015-10-12 Thread James Hugman
Hi I asked a Googler on the Chrome Dev Rel team about Chrome Extensions – primarily to compare notes second guessing app store policies that Firefox Addons may encounter. He didn't reveal anything about the Chrome team's thinking about not doing extensions, but he did point to http://www.kitt.com

Re: iOS Menu Implementation Proposal

2016-03-09 Thread James Hugman
> > In a way I want to at least think about the changes that might be needed > for a user configurable layout as I don't want to have to go through a > whole pile of refactoring of the underlying menu code if we do decide we > want to do this, but at the same time I don't want to overcomplicate the

Re: [iOS] The Menu Has Landed!

2016-04-20 Thread James Hugman
Brilliant brilliant work. This is really top-drawer stuff, which gives the rest of app UI much room to grow, the first major iOS spinoff project, and a beachhead on to the refactoring work known only as BVC. – James On Wed, Apr 20, 2016 at 6:39 PM, Emily Toop wrote: > I landed the work that has

Re: Bug Ranking Scheme

2016-04-26 Thread James Hugman
I was trying to work out scope of what we're doing here since the last time we talked about this. We're currently using the tracking flags to indicate if we care about it, but using a rank (essentially because bugzilla already had a flag) to indicate how much we care about it if we don't care enou

iOS UI Tests

2016-05-01 Thread James Hugman
Hey, I've spent a few spare cycles looking at the UI tests, which are currently failing consistently. I thought this might be a set of fixes which roughly translate to "sprinkle in a few `tester().waitForAnimationsToFinish()` statements", but it turns out to not be as simple as that. I'll probab

Fwd: [ios] Extending MenuView with long press.

2016-05-03 Thread James Hugman
Emily A question about menu. A question about AppState to come (I'm breaking these up into two emails). First: how do we support long press. So my ideas about adding long press to a menu item was how does the app get to know that the user has long pressed the menu item. I'm assuming that we can

Fwd: [ios] AppState, MenuConfiguration, and prefs

2016-05-03 Thread James Hugman
Emily, and others Background: We are trying to maintain some separation between MenuView code and the rest of the app, with the intention that a) this is good for the code b) MenuView could end up being a good candidate to be an open-source sub-project unrelated to the main app. MenuConfiguratio

Re: iOS UI Tests

2016-05-04 Thread James Hugman
tests the more likely they'll be run on a dev machine etc). So many thanks, awesome contribution! – James On Mon, May 2, 2016 at 6:01 PM, Michael Comella wrote: > Hey. > > I'm missing context but... > > On Sun, May 1, 2016 at 5:32 PM, James Hugman wrote: > >&g

Re: Regarding Night Mode on iOS

2016-06-27 Thread James Hugman
I'm concerned on a number of fronts: the prominent display of the menu item, the non-changing browser chrome, styling inconsistencies by doing a bad job inverting colors. The most critical of these are bugs from restyling web content. I'm happy for this feature to slip for 5.0 until we have a bett

Firefox TDES Today!

2017-03-16 Thread James Hugman
Hey Gang! Given that many of our Crack Squad Of Elite Eliminators of Technical Debt are out today, and there is nothing on the agenda, I propose we postpone our meet today. The next time should be a bumper one: we will have had six weeks of unpublished proposals to talk about! (I have at least tw

[iOS] Send Tab with Apple Push Notifications

2017-04-19 Thread James Hugman
Hello! I'm very pleased to say yesterday we landed the final piece of iOS code to enable sending tabs to Firefox for iOS using WebPush. This is an important milestone for Firefox Accounts and Firefox for iOS – in that we have a well understood connection from FxA to users' iOS devices. This will

Naming advice for ScreenGraph.swift.

2017-05-21 Thread James Hugman
Hi, Background: ScreenGraph.swift is a tiny library [1] to model any app as a graph [2]. It's primary case is to make UI tests easier to read and write [3], but has found uses in generating L10n and marketing screenshots. It uses vanilla swift and GameplayKit. [1]: https://github.com/mozilla-mobi

Re: Live bookmarks & RSS

2017-08-17 Thread James Hugman
Hi Joe, Thanks for your cool suggestion. I believe that RSS feeds currently are opened in the News App or Podcasts App. However, I very much like the idea of detecting the tags and displaying a button somewhere (much as we already do with reader mode) to open the news app. I don't think it i

Request for Github-flavored brownbag

2018-08-11 Thread James Hugman
Hey Devin, On the lockbox team, we've benefited greatly from your Github-fu. During the iOS Engineering meeting, a question was asked: > how do you see how many PRs a reviewer has waiting for them so you can select the least busy reviewer for your PR? A number of solutions were offered, but Sas

jhugman — not working today

2019-04-15 Thread James Hugman
Hi, I'm not feeling very good today; finding it very difficult to concentrate, and have been fighting off something all weekend. I'll be back onto it tomorrow. — James ___ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozi

Re: jhugman — gone to Children's ER with #number1son.

2020-06-10 Thread James Hugman
today. Please ping me for anything urgent. Thanks and regards — James On Tue, Jun 9, 2020, 11:45 James Hugman wrote: > Hi all > > I've needed to take my first born to the emergency room this morning. > Nothing serious, but we will probably be here for a little while. I may > h

FYSA jhugman unexpectedly afk today

2020-09-18 Thread James Hugman
Unexpectedly, I've spent a good deal of time in the ER today. I'll be working a little later this evening, but apologies if I'm missing your meeting or your waiting on my attention resource. Thanks and regards James ___ mobile-firefox-dev mailing list

Re: FYSA jhugman unexpectedly afk today

2020-09-21 Thread James Hugman
wrote: > hope everything is better this week! > > -- janet > > On Fri, Sep 18, 2020 at 10:07 AM James Hugman wrote: > >> Unexpectedly, I've spent a good deal of time in the ER today. >> >> I'll be working a little later this evening, but apologies i