[WikimediaMobile] Using jsbeautify in MobileFrontend

2014-11-18 Thread Jon Robson
I explored running jsbeautify [1] on the MobileFrontend codebase and looked at how the output differs from the current styling. It introduces various rules that MobileFrontend is currently not adhering too. MobileFrontend already uses jscs [2] so we want to make sure the outputs of both are

Re: [WikimediaMobile] translatable messages in betas

2014-11-18 Thread Dan Garry
On 17 November 2014 10:39, Amir E. Aharoni amir.ahar...@mail.huji.ac.il wrote: I hope that Niklas or Siebrand don't hit me with a stick now, but I'd say that when we are talking about less then a dozen of messages, as in this case, then maybe you could merge just the messages separately to

Re: [WikimediaMobile] switching languages

2014-11-18 Thread Bernd Sitzmann
Monte/Dan: Yes, this has been proposed for the Android app in https://bugzilla.wikimedia.org/show_bug.cgi?id=71136 and https://bugzilla.wikimedia.org/show_bug.cgi?id=34100. On Tue, Nov 18, 2014 at 11:06 AM, Dan Garry dga...@wikimedia.org wrote: Hey Amir, Thanks for the email! It's nice to

Re: [WikimediaMobile] Using jsbeautify in MobileFrontend

2014-11-18 Thread Bahodir Mansurov
As for # Rule 4, it makes sense to add spaces inside square brackets. The reasoning is the same as why we add spaces inside parenthesis. On Nov 18, 2014, at 12:28 PM, Jon Robson jrob...@wikimedia.org wrote: I explored running jsbeautify [1] on the MobileFrontend codebase and looked at how