[mochikit] Bug in queryString?

2007-05-03 Thread Arnar Birgisson

Hi all,

The current svn version of queryString gives me something unexpected on this

queryString({nonni:null, x:3})

It gives me a silent error and no result. The docs say attributes with
null values or undefined will be skipped, so I was expecting x=3
here.

Further investigation shows that the line that fails is Base.js:1115:

typeof(v.length) == number

I assume this is failing because null has no .length property.


Am I doing something wrong here? I find it unlikely that no-one has
bumped into this before since this affects everything that uses
queryString, including loadJSONDoc.

If this is clearly a bug, I'd only be happy to commit a fix.

Arnar

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
MochiKit group.
To post to this group, send email to mochikit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/mochikit?hl=en
-~--~~~~--~~--~--~---



[mochikit] Re: Bug in queryString?

2007-05-03 Thread Bob Ippolito

On 5/3/07, Arnar Birgisson [EMAIL PROTECTED] wrote:

 Hi all,

 The current svn version of queryString gives me something unexpected on this

 queryString({nonni:null, x:3})

 It gives me a silent error and no result. The docs say attributes with
 null values or undefined will be skipped, so I was expecting x=3
 here.

 Further investigation shows that the line that fails is Base.js:1115:

 typeof(v.length) == number

 I assume this is failing because null has no .length property.


 Am I doing something wrong here? I find it unlikely that no-one has
 bumped into this before since this affects everything that uses
 queryString, including loadJSONDoc.

 If this is clearly a bug, I'd only be happy to commit a fix.


Sounds like a bug. Please commit a test that fails, then commit a fix :)

-bob

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
MochiKit group.
To post to this group, send email to mochikit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/mochikit?hl=en
-~--~~~~--~~--~--~---