On Mon, Sep 18, 2017 at 8:13 AM, Ben Chan wrote:
> Similar to firmware revision, hardware revision is useful information
> for identifying characteristics about a modem module. Both MBIM and
> QMI provides API to query hardware revision from the modem. This
> series of patch
On Mon, Sep 18, 2017 at 9:10 AM, Ben Chan wrote:
> This patches fixes commit 334273979 "broadband-modem-mbim: preserve
> unlock retries for PIN1 when appropriate", which doesn't correctly
> propagate the unlock retries information for PIN1 observed from
> responses to
On Mon, Sep 18, 2017 at 9:10 AM, Ben Chan wrote:
> This patch adds a mm_iface_modem_get_unlock_retries helper for getting
> the current MMUnlockRetries value of a MMIfaceModem object, which later
> allows us to partially update (e.g. a specific MMModemLock) the
>
On Sun, Sep 17, 2017 at 6:36 PM, Ben Chan wrote:
> This branch contains a series of patches that port the sierra plugin
> to use GTask:
>
> https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-plugins-sierra
All LGTM! Pushed to git master
On Sun, Sep 17, 2017 at 6:35 PM, Ben Chan wrote:
> This branch contains a series of patches that port the option plugin
> to use GTask:
>
> https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-plugins-option
All LGTM, merged to git master.
On Tue, Sep 19, 2017 at 12:01 AM, Aleksander Morgado
wrote:
>>
>> I overlooked one thing when I revised the patches based on Dan's
>> suggestion, and also missed that in my testing :-(
>>
>> MMSimMbim:update_modem_unlock_retries() calls
>>
This patches fixes commit 334273979 "broadband-modem-mbim: preserve
unlock retries for PIN1 when appropriate", which doesn't correctly
propagate the unlock retries information for PIN1 observed from
responses to MBIM_CID_PIN set operations (see commit eb9ec1b61
"sim-mbim: update unlock retries
This patch adds a mm_iface_modem_get_unlock_retries helper for getting
the current MMUnlockRetries value of a MMIfaceModem object, which later
allows us to partially update (e.g. a specific MMModemLock) the
MMUnlockRetries value of a MMIfaceModem object.
---
src/mm-iface-modem.c | 21
>
> I overlooked one thing when I revised the patches based on Dan's
> suggestion, and also missed that in my testing :-(
>
> MMSimMbim:update_modem_unlock_retries() calls
> mm_iface_modem_update_unlock_retries() to report remaining attempts
> PIN1. That won't affect
Please note that I use GSimpleAsyncResult instead of GTask in the
patch that modifies MMBroadbandModemQmi in order to minimize the
changes (as I don't want to touch ensure_qmi_client related code). The
GTask migration will be done in another branch:
Similar to firmware revision, hardware revision is useful information
for identifying characteristics about a modem module. Both MBIM and
QMI provides API to query hardware revision from the modem. This
series of patch add support of loading and reporting hardware revision
through the Modem
Hi Dan and Aleksander,
I overlooked one thing when I revised the patches based on Dan's
suggestion, and also missed that in my testing :-(
MMSimMbim:update_modem_unlock_retries() calls
mm_iface_modem_update_unlock_retries() to report remaining attempts
PIN1. That won't affect
12 matches
Mail list logo