Re: [PATCH] [Telit plugin] Add load_supported_bands interface

2016-01-25 Thread Carlo Lobrano
Thank you! Carlo On Mon, 25 Jan 2016 at 14:02 Aleksander Morgado wrote: > On 25/01/16 11:02, c.lobr...@gmail.com wrote: > > From: Carlo Lobrano > > > > --- > > plugins/telit/mm-broadband-modem-telit.c | 86 + > > plugins/telit/mm-modem-helpers-telit.c| 372 >

Re: [PATCH] [Telit plugin] Add load_supported_bands interface

2016-01-25 Thread Aleksander Morgado
On 25/01/16 11:02, c.lobr...@gmail.com wrote: > From: Carlo Lobrano > > --- > plugins/telit/mm-broadband-modem-telit.c | 86 + > plugins/telit/mm-modem-helpers-telit.c| 372 > +- > plugins/telit/mm-modem-helpers-telit.h| 67 > plug

[PATCH] [Telit plugin] Add load_supported_bands interface

2016-01-25 Thread c . lobrano
From: Carlo Lobrano --- plugins/telit/mm-broadband-modem-telit.c | 86 + plugins/telit/mm-modem-helpers-telit.c| 372 +- plugins/telit/mm-modem-helpers-telit.h| 67 plugins/telit/tests/test-mm-modem-helpers-telit.c | 150 -

Re: [PATCH] [Telit plugin] add load_supported_bands interface

2016-01-23 Thread c.lobr...@gmail.com
Hi, sure, I'll fix what suggested and propose a new patch thanks, Carlo On sab, gen 23, 2016 at 12:07 , Aleksander Morgado wrote: On 18/01/16 14:30, Carlo Lobrano wrote: --- plugins/telit/77-mm-telit-port-types.rules| 4 + plugins/telit/mm-broadband-modem-telit.c | 8

Re: [PATCH] [Telit plugin] add load_supported_bands interface

2016-01-22 Thread Aleksander Morgado
On 18/01/16 14:30, Carlo Lobrano wrote: > --- > plugins/telit/77-mm-telit-port-types.rules| 4 + > plugins/telit/mm-broadband-modem-telit.c | 86 + > plugins/telit/mm-modem-helpers-telit.c| 372 > +- > plugins/telit/mm-modem-helpers-telit.h

[PATCH] [Telit plugin] add load_supported_bands interface

2016-01-18 Thread Carlo Lobrano
--- plugins/telit/77-mm-telit-port-types.rules| 4 + plugins/telit/mm-broadband-modem-telit.c | 86 + plugins/telit/mm-modem-helpers-telit.c| 372 +- plugins/telit/mm-modem-helpers-telit.h| 58 plugins/telit/tests/test-mm-mo

[PATCH] [Telit plugin] add load_supported_bands interface

2016-01-18 Thread Carlo Lobrano
Hi, here is a new proposal implementation for load_supported_bands interface for Telit modems. Best regards, Carlo Carlo Lobrano (1): [Telit plugin] add load_supported_bands interface plugins/telit/77-mm-telit-port-types.rules| 4 + plugins/telit/mm-broadband-modem-telit.c

Re: [PATCH] Telit plugin: add load_supported_bands interface

2016-01-14 Thread Aleksander Morgado
On Thu, Jan 14, 2016 at 12:41 PM, Carlo Lobrano wrote: > Well, have you ever felt so sure about one thing and then talking to someone > about it you realize that was wrong? I was so sure that parsing the > response, working out the LTE bands from that number and mapping the BND > values to MM band

Re: [PATCH] Telit plugin: add load_supported_bands interface

2016-01-14 Thread Carlo Lobrano
Well, have you ever felt so sure about one thing and then talking to someone about it you realize that was wrong? I was so sure that parsing the response, working out the LTE bands from that number and mapping the BND values to MM bands would have been more difficult than just hardcode the supporte

Re: [PATCH] Telit plugin: add load_supported_bands interface

2016-01-14 Thread Aleksander Morgado
On Thu, Jan 14, 2016 at 8:51 AM, Carlo Lobrano wrote: > AT#BND does return the list of supported bands for 2G and UMTS, but for LTE > (according to LE910 V2 AT command docs) it is a little bit more complicated. > In fact the LTE bands are represented by a number which is "a sum of: > > 1 - B1 > 2

Re: [PATCH] Telit plugin: add load_supported_bands interface

2016-01-13 Thread Carlo Lobrano
​AT#BND does return the list of supported bands for 2G and UMTS, but for LTE​ (according to LE910 V2 AT command docs) it is a little bit more complicated. In fact the LTE bands are represented by a number which is "a sum of: 1 - B1 2 - B2 4 - B3 8 - B4 ... i - B(2exp(i-1)) ... 2147483648 - B32" S

Re: [PATCH] Telit plugin: add load_supported_bands interface

2016-01-13 Thread Dan Williams
On Wed, 2016-01-13 at 11:55 +0100, Carlo Lobrano wrote: > Hi, > > this patch implements `load_supported_bands` for the following > Telit's modems: Does AT#BND=? not work on these devices, or does it not return accurate results? Maybe I missed that question before... Dan > - HE910 EU* > - HE910

[PATCH] Telit plugin: add load_supported_bands interface

2016-01-13 Thread Carlo Lobrano
Hi, this patch implements `load_supported_bands` for the following Telit's modems: - HE910 EU* - HE910 NA* - LE910 EU V2 - LE910 NA V2 - LE910 SV V2 Carlo Lobrano (1): [Telit Plugin] Add load_supported_bands for some Telit modem models plugins/telit/77-mm-telit-port-types.rules| 4