Re: [PATCH 1/5] allow optional quotes in +CREG: , "", "" (GSM 07.07 CREG=2 unsolicited) pattern; add testcase for Thuraya XT

2016-02-12 Thread Thomas Sailer
On 02/12/2016 05:19 PM, Dan Williams wrote: Still curious about this part though. We probably still want to strip out the comma, since a 3GPP cellid is numbers only I believe. It seems that CI on Thuraya is simply nonsensical. LAC looks reasonable - I'm on spot beam 38, and the spot beam numb

Re: [PATCH 1/5] allow optional quotes in +CREG: , "", "" (GSM 07.07 CREG=2 unsolicited) pattern; add testcase for Thuraya XT

2016-02-12 Thread Dan Williams
On Fri, 2016-02-12 at 10:15 -0600, Dan Williams wrote: > On Thu, 2016-02-11 at 16:05 +0100, Thomas Sailer wrote: > > On 02/11/2016 03:25 PM, Aleksander Morgado wrote: > > > Why not just make the single quote characters optionals? (instead > > > of  > > > providing two options, with and without quot

Re: [PATCH 1/5] allow optional quotes in +CREG: , "", "" (GSM 07.07 CREG=2 unsolicited) pattern; add testcase for Thuraya XT

2016-02-12 Thread Dan Williams
On Thu, 2016-02-11 at 16:05 +0100, Thomas Sailer wrote: > On 02/11/2016 03:25 PM, Aleksander Morgado wrote: > > Why not just make the single quote characters optionals? (instead > > of  > > providing two options, with and without quotes).  > > In the quoted case, comma needs to be excluded in the

Re: [PATCH 1/5] allow optional quotes in +CREG: , "", "" (GSM 07.07 CREG=2 unsolicited) pattern; add testcase for Thuraya XT

2016-02-12 Thread Thomas Sailer
On 02/11/2016 03:25 PM, Aleksander Morgado wrote: Why not just make the single quote characters optionals? (instead of providing two options, with and without quotes). In the quoted case, comma needs to be excluded in the character set, I think. Thuraya response is +CREG: 1, "0426", "F0,0F"

Re: [PATCH 1/5] allow optional quotes in +CREG: , "", "" (GSM 07.07 CREG=2 unsolicited) pattern; add testcase for Thuraya XT

2016-02-11 Thread Aleksander Morgado
On Thu, Feb 11, 2016 at 1:45 PM, Thomas Sailer wrote: > +#define CREG3 > "\\+(CREG|CGREG|CEREG):\\s*0*([0-9]),\\s*(?|([^,\\s]*)|(?:\"([^\"]*)\"))\\s*,\\s*(?|([^,\\s]*)|(?:\"([^\"]*)\"))" Why not just make the single quote characters optionals? (instead of providing two options, with and without

[PATCH 1/5] allow optional quotes in +CREG: ,"","" (GSM 07.07 CREG=2 unsolicited) pattern; add testcase for Thuraya XT

2016-02-11 Thread Thomas Sailer
From: Thomas Sailer Signed-off-by: Thomas Sailer --- src/mm-modem-helpers.c | 2 +- src/tests/test-modem-helpers.c | 11 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mm-modem-helpers.c b/src/mm-modem-helpers.c index 17ad8d2..cf80a40 100644 --- a/src/mm