Re: [PATCH1 1/4 v3] helpers: new 'AT+CMER=?' parser

2017-05-29 Thread Aleksander Morgado
On 22/05/17 14:43, Aleksander Morgado wrote: > --- > > Hey Colin, > > Please try now with this v3 patch. I modified the helper method to allow the > comma-separated number sequence you get in your EHS5 for the modes, i.e.: > "(1,2)". The regex wasn't catching that logic, so instead of

Re: [PATCH1 1/4 v3] helpers: new 'AT+CMER=?' parser

2017-05-22 Thread Aleksander Morgado
On Mon, May 22, 2017 at 3:50 PM, Colin Helliwell wrote: > But do bear in mind that I don't have any conviction about what 'CMER' the > EHS5 actually supports, because it's AT doc doesn't mention the command at > all - by rights it shouldn't even respond at all to

Re: [PATCH1 1/4 v3] helpers: new 'AT+CMER=?' parser

2017-05-22 Thread Colin Helliwell
> On 22 May 2017 at 13:43 Aleksander Morgado wrote: > > --- > > Hey Colin, > > Please try now with this v3 patch. I modified the helper method to allow the > comma-separated number sequence you get in your EHS5 for the modes, i.e.: > "(1,2)". The regex wasn't

[PATCH1 1/4 v3] helpers: new 'AT+CMER=?' parser

2017-05-22 Thread Aleksander Morgado
--- Hey Colin, Please try now with this v3 patch. I modified the helper method to allow the comma-separated number sequence you get in your EHS5 for the modes, i.e.: "(1,2)". The regex wasn't catching that logic, so instead of complicating it too much, I switched to splitting the response