Re: [PATCH 1/2] novatel: port custom init to use GTask

On Thu, Apr 6, 2017 at 11:36 AM, Aleksander Morgado wrote: > On 03/04/17 21:37, Ben Chan wrote: >> --- >> plugins/novatel/mm-common-novatel.c | 62 >> + >> 1 file changed, 29 insertions(+), 33 deletions(-) >> > > Pushed to git

Porting to GTask: pointer to self in context?

Hey Ben, Dan and everyone else, Related to the ports to GTask sent by Ben... When using the GSimpleAsyncResult logic, I usually always added a full reference to the "source object" of the async operation in the "Context" struct, so that I could use it directly, e.g. ctx->self. This was really

Re: [PATCH] novatel-lte: revert to original plugin library name

On 03/04/17 23:16, Dan Williams wrote: > On Mon, 2017-04-03 at 13:05 -0700, Ben Chan wrote: >> Commit f9c63bfa0 "build,plugins: update build rules" accidentally >> changed the Novatel LTE plugin from 'libmm-plugins-novatel-lte.so' to >> 'libmm-plugins-novatel_lte.so'. The name becomes inconsistent

Re: [PATCH] telit: unsupported CSIM lock should not skip loading unlock retries

On 06/04/17 14:37, Carlo Lobrano wrote: > Some modems do not support CSIM lock/unlock, but they do support > querying SIM unlock retries through +CSIM command. > > If CSIM lock returns with "unsupported command" do not propagate > the error and continue with the other CSIM queries instead. > ---

Re: [PATCH 1/2] novatel: port custom init to use GTask

On 03/04/17 21:37, Ben Chan wrote: > --- > plugins/novatel/mm-common-novatel.c | 62 > + > 1 file changed, 29 insertions(+), 33 deletions(-) > Pushed to git master. In this case, though, we may have been able to avoid the ctx->probe reference, right? >

Re: Porting to GTask: pointer to self in context?

On Thu, Apr 6, 2017 at 11:09 AM, Aleksander Morgado wrote: > Hey Ben, Dan and everyone else, > > Related to the ports to GTask sent by Ben... > > When using the GSimpleAsyncResult logic, I usually always added a full > reference to the "source object" of the async

Re: [PATCH] base-modem: port mm_base_modem_authorize to use GTask

On 04/04/17 08:37, Ben Chan wrote: > --- > src/mm-base-modem.c | 25 ++--- > 1 file changed, 10 insertions(+), 15 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-base-modem.c b/src/mm-base-modem.c > index 430ce59d..76286f6b 100644 > ---

Re: [PATCH 2/2] novatel: port IMSI loading to use GTask

On 03/04/17 21:37, Ben Chan wrote: > --- > plugins/novatel/mm-sim-novatel-lte.c | 89 > +++- > 1 file changed, 36 insertions(+), 53 deletions(-) > I love this one! Re-using the "imsi" array in stack as result in the GSimpleAsyncResult was a bit of a hack, as

[PATCH] sms-list: port mm_sms_list_delete_sms to use GTask

--- src/mm-sms-list.c | 70 +-- 1 file changed, 27 insertions(+), 43 deletions(-) diff --git a/src/mm-sms-list.c b/src/mm-sms-list.c index 7819b3ad..22c2cd9a 100644 --- a/src/mm-sms-list.c +++ b/src/mm-sms-list.c @@ -113,28 +113,12 @@

ModemManager: symbol lookup error: ModemManager: undefined symbol: mm_kernel_event_properties_get_type

Hello All, I am using Quectel UC20 mini PCIe modem on my development board and running ModemManager on it. Since ModemManager is using by default baud rate set to 57600 I have decided to move to the latest version of ModemManager (1.7.0) since there is a possibility to set udev rule for baud

Re: [PATCH v3] telit: add error_code recognition to +CSIM parser

Hey Carlo, On 04/04/17 14:55, Carlo Lobrano wrote: > - Refactored mm_telit_parse_csim_response in order to correctly recognize the > following +CSIM error codes: > > * 6300 - Verification failed > * 6983 - Authentication method blocked > * 6984 - Reference data invalidated > *

RE: ModemManager: symbol lookup error: ModemManager: undefined symbol: mm_kernel_event_properties_get_type

Hello Aleksander, I have used ./configure --with-qmi=yes than make and make install and I have run ModemManager with a command ModemManager --debug. Am I missing any other option in ./configure? Thank you for your help. Jan Graczyk -Original Message- From: Aleksander Morgado

[PATCH] novatel: obtain MMPortProbe from GTask source object

The MMPortProbe object is already referenced by the GTask object for custom init. Instead of keeping another reference of MMPortProbe in the CustomInitContext, this patch changes the code to simply obtain it from the source object of GTask. See

Re: ModemManager: symbol lookup error: ModemManager: undefined symbol: mm_kernel_event_properties_get_type

On 06/04/17 21:26, Jan Graczyk wrote: > I have used ./configure --with-qmi=yes than make and make install and I have > run ModemManager with a command ModemManager --debug. Am I missing any other > option in ./configure? Thank you for your help. If you are not using --prefix=/somewhere in

[PATCH 2/2] sms-mbim: port sms_delete to use GTask

--- src/mm-sms-mbim.c | 48 +++- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/src/mm-sms-mbim.c b/src/mm-sms-mbim.c index 085a2d59..99e0de74 100644 --- a/src/mm-sms-mbim.c +++ b/src/mm-sms-mbim.c @@ -207,22 +207,17 @@ sms_send

[PATCH 1/2] sms-mbim: port sms_send to use GTask

--- src/mm-sms-mbim.c | 46 ++ 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/src/mm-sms-mbim.c b/src/mm-sms-mbim.c index eded51fc..085a2d59 100644 --- a/src/mm-sms-mbim.c +++ b/src/mm-sms-mbim.c @@ -74,21 +74,16 @@ peek_device

Re: [PATCH] iface-modem-simple: port register_in_3gpp_or_cdma_network to use GTask

On 04/04/17 08:37, Ben Chan wrote: > --- > src/mm-iface-modem-simple.c | 59 > ++--- > 1 file changed, 34 insertions(+), 25 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-simple.c b/src/mm-iface-modem-simple.c > index

[PATCH 1/2] auth: port authorize to use GTask

--- src/mm-auth-provider.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/mm-auth-provider.c b/src/mm-auth-provider.c index 4ef56234..4d8766c0 100644 --- a/src/mm-auth-provider.c +++ b/src/mm-auth-provider.c @@ -75,15 +75,12 @@ authorize (MMAuthProvider *self,

[PATCH] call-list: port mm_call_list_delete_call to use GTask

--- src/mm-call-list.c | 55 +++--- 1 file changed, 19 insertions(+), 36 deletions(-) diff --git a/src/mm-call-list.c b/src/mm-call-list.c index fae66035..1cc1f543 100644 --- a/src/mm-call-list.c +++ b/src/mm-call-list.c @@ -214,28 +214,12 @@

[PATCH] port-mbim: port mm_port_mbim_{open,close} to use GTask

--- src/mm-port-mbim.c | 130 + 1 file changed, 50 insertions(+), 80 deletions(-) diff --git a/src/mm-port-mbim.c b/src/mm-port-mbim.c index 2b649963..5015c388 100644 --- a/src/mm-port-mbim.c +++ b/src/mm-port-mbim.c @@ -31,90 +31,58 @@ struct

Re: Porting to GTask: pointer to self in context?

On Thu, 2017-04-06 at 20:09 +0200, Aleksander Morgado wrote: > Hey Ben, Dan and everyone else, > > Related to the ports to GTask sent by Ben... > > When using the GSimpleAsyncResult logic, I usually always added a > full > reference to the "source object" of the async operation in the >

Re: ModemManager: symbol lookup error: ModemManager: undefined symbol: mm_kernel_event_properties_get_type

On 06/04/17 21:14, Jan Graczyk wrote: > I am using Quectel UC20 mini PCIe modem on my development board and running > ModemManager on it. Since ModemManager is using by default baud rate set to > 57600 I have decided to move to the latest version of ModemManager (1.7.0) > since there is a

Re: [PATCH] bearer-list: port mm_bearer_list_disconnect_all_bearers to use GTask

On 04/04/17 08:37, Ben Chan wrote: > --- > src/mm-bearer-list.c | 40 +--- > 1 file changed, 21 insertions(+), 19 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-bearer-list.c b/src/mm-bearer-list.c > index e021e34a..9ad98aeb 100644 > ---

[PATCH 1/2] port-qmi: port mm_port_qmi_open to use GTask

--- src/mm-port-qmi.c | 142 +- 1 file changed, 76 insertions(+), 66 deletions(-) diff --git a/src/mm-port-qmi.c b/src/mm-port-qmi.c index eb163006..c6ae0615 100644 --- a/src/mm-port-qmi.c +++ b/src/mm-port-qmi.c @@ -188,9 +188,6 @@ typedef

[PATCH 2/2] port-qmi: port mm_port_qmi_allocate_client to use GTask

--- src/mm-port-qmi.c | 51 ++- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/src/mm-port-qmi.c b/src/mm-port-qmi.c index c6ae0615..2baeea7c 100644 --- a/src/mm-port-qmi.c +++ b/src/mm-port-qmi.c @@ -73,21 +73,16 @@

Re: Failed to find primary AT port

On Thu, Apr 6, 2017 at 12:39 AM, Jan Graczyk wrote: > Thank you for your response. I have looked into ModemManager version 1.6.4 > and this patch you are mentioning in your e-mail does not reflect the line > number in src/mm-base-modem.c: > > @@ -219,6 +219,12 @@