Re: [PATCH] base-call: remove unnecessary string duplications

2017-04-08 Thread Aleksander Morgado
On 08/04/17 03:16, Ben Chan wrote: > --- > src/mm-base-call.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-base-call.c b/src/mm-base-call.c > index 6ce85d0d..606d24f2 100644 > --- a/src/mm-base-call.c > +++

Re: [PATCH 2/2] port-qmi: port mm_port_qmi_allocate_client to use GTask

2017-04-08 Thread Aleksander Morgado
On 07/04/17 18:25, Ben Chan wrote: >>> typedef struct { >>> -MMPortQmi *self; >>> -GSimpleAsyncResult *result; >>> ServiceInfo *info; >>> } AllocateClientContext; >>> >> I believe we could remove the AllocateClientContext struct all together >> and just pass the ServiceInfo as task