[PATCH] broadband-modem-mbim: remove unused variable

--- src/mm-broadband-modem-mbim.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c index 7f5d2fc8..815f5455 100644 --- a/src/mm-broadband-modem-mbim.c +++ b/src/mm-broadband-modem-mbim.c @@ -1547,11 +1547,9 @@

Sending SMS in PDU mode fails.

I am using the 3G XBee Cellular (uses U-Blox SARA-U200 modem) and ModemManager from master (d41d717112e6a183a0df510c210e80a86fc11060). I am trying to send an SMS with the following commands: $ mmcli -m 0 --messaging-create-sms="text='Hello world',number='+627XX" Successfully created new SMS:

Re: [PATCH] libmm-glib,firmware: fix unique_id checks

On 03/08/17 06:53, Ben Chan wrote: > The following checks in mm_modem_firmware_select() and > mm_modem_firmware_select_sync() could result in a NULL pointer > dereference if `unique_id' is NULL: > > g_return_if_fail (unique_id != NULL || unique_id[0] == '\0') > g_return_val_if_fail (unique_id

Re: [PATCH 4/5] plugin-manager: remove unused variable

On 03/08/17 06:53, Ben Chan wrote: > --- > src/mm-plugin-manager.c | 4 > 1 file changed, 4 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-plugin-manager.c b/src/mm-plugin-manager.c > index 47d162fb..65ccbebf 100644 > --- a/src/mm-plugin-manager.c > +++

Re: [PATCH 2/5] broadband-modem: remove unused variables

On 03/08/17 06:53, Ben Chan wrote: > --- > src/mm-broadband-modem.c | 12 > 1 file changed, 12 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-broadband-modem.c b/src/mm-broadband-modem.c > index eb127b58..2bfc3382 100644 > --- a/src/mm-broadband-modem.c > +++

Re: [PATCH 3/5] call-list: remove unused variables

On 03/08/17 06:53, Ben Chan wrote: > --- > src/mm-call-list.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-call-list.c b/src/mm-call-list.c > index 9457bb2b..3ca46bcc 100644 > --- a/src/mm-call-list.c > +++

Re: [PATCH] novatel: avoid calling qcdm_result_unref on NULL QcdmResult

On 03/08/17 06:53, Ben Chan wrote: > --- > plugins/novatel/mm-broadband-modem-novatel.c | 1 - > 1 file changed, 1 deletion(-) > Pushed to git master, thanks. > diff --git a/plugins/novatel/mm-broadband-modem-novatel.c > b/plugins/novatel/mm-broadband-modem-novatel.c > index

Re: [PATCH] sms-part-cdma: add missing break statements in cause_code_to_delivery_state

On 03/08/17 06:53, Ben Chan wrote: > This patch fixes cause_code_to_delivery_state() by adding two missing > break statements for the case ERROR_CLASS_TEMPORARY and > ERROR_CLASS_PERMANENT in the `switch (error_class)` statement. Without > the break statements, the switch always falls through to

Re: [PATCH] broadband-modem-mbim: remove unused variable

On 03/08/17 09:58, Ben Chan wrote: > --- > src/mm-broadband-modem-mbim.c | 2 -- > 1 file changed, 2 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c > index 7f5d2fc8..815f5455 100644 > --- a/src/mm-broadband-modem-mbim.c

Re: [PATCH] huawei: ensure MMBearerConnectResult populated into GSimpleAsyncResult

On 02/08/17 02:01, Ben Chan wrote: > During the CONNECT_3GPP_CONTEXT_STEP_LAST step, > connect_3gpp_context_step() conditionally creates and populates a > MMBearerConnectResult object into the GSimpleAsyncResult object when the > ipv4_config field of the Connect3gppContext struct is set. That

Re: [PATCH] altair-lte: don't use send-delay=0

On 02/08/17 07:16, Ben Chan wrote: > As observed on some modems, send-delay=0 seems to break port probing. > --- > plugins/altair/mm-plugin-altair-lte.c | 1 - > 1 file changed, 1 deletion(-) > But the port probing with send delay 0 here should only happen when the Altair LTE modem is the one

Re: Sending SMS in PDU mode fails.

On 03/08/17 11:04, José wrote: > I am using the 3G XBee Cellular (uses U-Blox SARA-U200 modem) and > ModemManager from master (d41d717112e6a183a0df510c210e80a86fc11060). > > I am trying to send an SMS with the following commands: > > $ mmcli -m 0 --messaging-create-sms="text='Hello

Re: [PATCH] altair-lte: don't use send-delay=0

On Thu, Aug 3, 2017 at 4:24 PM, Ben Chan wrote: > > > On Aug 3, 2017 3:35 AM, "Aleksander Morgado" > wrote: > > On 02/08/17 07:16, Ben Chan wrote: >> As observed on some modems, send-delay=0 seems to break port probing. >> --- >>

Re: [PATCH] altair-lte: don't use send-delay=0

On Aug 3, 2017 3:35 AM, "Aleksander Morgado" wrote: On 02/08/17 07:16, Ben Chan wrote: > As observed on some modems, send-delay=0 seems to break port probing. > --- > plugins/altair/mm-plugin-altair-lte.c | 1 - > 1 file changed, 1 deletion(-) > But the port probing

Re: Sending SMS in PDU mode fails.

I was not register in the network : ( Working now, thanks! I think I have a different problem with the XBee US version, but I will let you know if I cannot solve that. On Thu, Aug 3, 2017 at 1:13 PM, Aleksander Morgado wrote: > On 03/08/17 11:04, José wrote: >> I am

ModemManager and Iridium 9522b

Hello, I am trying to get my Iridium 9522b modem recognized using mmcli. It is connected on /dev/ttyUSB2 with 19200, 8, N, 1. I can successfully communicate via AT commands through pyserial or minicom, so I'm confident that it is functioning. Below are the scan and list outputs from mmcli as

Re: [PATCH] bearer-mbim: avoid accessing invalid session_id and nw_error

On Thu, 2017-08-03 at 13:24 -0700, Ben Chan wrote: > This patch fixes an issue in disconnect_set_ready(). If > mbim_message_connect_response_parse(), `session_id' and `nw_error' > are > not set to a valid value, and thus shouldn't be used. LGTM; kinda convoluted function, but I can't think of a

Re: [PATCH] broadband-modem-qmi: fix potential use-after-freed issues

On Thu, 2017-08-03 at 13:25 -0700, Ben Chan wrote: > This patch fixes some potential use-after-freed issues in > dms_get_ids_ready(). When an invalid ESN / MEID is retrieved, > `ctx->self->priv->esn' / `ctx->self->priv->meid' is freed but not > reset > to NULL. If no IMEI is retrieved, `str' can

[PATCH] huawei: remove redundant call to huawei_parse_auth_type()

This patch removes a redundant `encoded_auth = huawei_parse_auth_type (auth)` in connect_3gpp_context_step(). --- plugins/huawei/mm-broadband-bearer-huawei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/huawei/mm-broadband-bearer-huawei.c

[PATCH] mm-broadband-modem-mbim: reprobe on mbim-proxy death

In case mbim-proxy crashes, ModemManager needs to be able to recognize this and respawn the proxy so we don't lose access to the modem. Do this by subscribing to the device removal signal on MbimDevice and reprobing the modem when we lose the connection to mbim-proxy. We can't just restart

Re: ModemManager and Iridium 9522b

Hey > > I am trying to get my Iridium 9522b modem recognized using mmcli. It is > connected on /dev/ttyUSB2 with 19200, 8, N, 1. I can successfully > communicate via AT commands through pyserial or minicom, so I'm confident > that it is functioning. > > Below are the scan and list outputs from

[PATCH v2] broadband-modem-qmi: fix potential use-after-freed issues

This patch fixes some potential use-after-freed issues in dms_get_ids_ready(). When an invalid ESN / MEID is retrieved, `ctx->self->priv->esn' / `ctx->self->priv->meid' is freed but not reset to NULL. If no IMEI is retrieved, `str' can be set to the already freed `ctx->self->priv->esn' /

[PATCH v2] location-gps-nmea: fix memory leaks

There are potential memory leaks in MMLocationGpsNmea: - When the `trace' string provided to location_gps_nmea_take_trace() isn't added to the hash table, its ownership is still considered transferred. It should thus be freed. Similarly, the `trace_type' string isn't added the hash table

[PATCH] broadband-modem: fix an ineffective `g_assert (equip_id)'

This patch fixes an ineffective `g_assert (equip_id)' in modem_load_equipment_identifier_finish(). After mm_parse_gsn() succeeds, `equip_id' is freed but not reset to NULL, so `g_assert (equip_id)' will never assert even if `imei', `meid', and `esn' are all NULL (though that shouldn't happen when

[PATCH 1/2] sim-qmi: remove unused variables

--- src/mm-sim-qmi.c | 12 1 file changed, 12 deletions(-) diff --git a/src/mm-sim-qmi.c b/src/mm-sim-qmi.c index 2ae15147..725e073e 100644 --- a/src/mm-sim-qmi.c +++ b/src/mm-sim-qmi.c @@ -480,9 +480,6 @@ dms_uim_verify_pin_ready (QmiClientDms *client, {