Re: [PATCH] telit: support QMI and MBIM modems

On Fri, Mar 24, 2017 at 11:08 PM, Daniele Palmas wrote: >> On Fri, Mar 24, 2017 at 3:33 PM, Daniele Palmas wrote: >>> So LN930 was a "special" modem, in the sense that was never produced >>> with Telit VID. >> >> Did it actually have a custom Telit firmware,

Re: [PATCH v2] Fixed wrong MEM1 value passed to +CPMS

Sure, I didn't see the other error. I'll update the patch Il venerdì 24 marzo 2017, Aleksander Morgado ha scritto: > Hey Carlo, > > On Fri, Mar 24, 2017 at 12:48 PM, Carlo Lobrano wrote: >> Let modem_messaging_set_default_storage returns with

Re: [PATCH] telit: support QMI and MBIM modems

2017-03-24 17:38 GMT+01:00 Aleksander Morgado : > On Fri, Mar 24, 2017 at 3:33 PM, Daniele Palmas wrote: >> So LN930 was a "special" modem, in the sense that was never produced >> with Telit VID. > > Did it actually have a custom Telit firmware, or was

Re: [PATCH v2] Fixed wrong MEM1 value passed to +CPMS

Hey Carlo, On Fri, Mar 24, 2017 at 12:48 PM, Carlo Lobrano wrote: > Let modem_messaging_set_default_storage returns with error > if current_sms_mem1_storage is MM_SMS_STORAGE_UNKNOWN > > --- > > I updated the patch according the code review, moreover I'd like > to note a

Re: [PATCH] telit: don't require udev tags to bind devices

On Fri, Mar 24, 2017 at 5:08 PM, Carlo Lobrano wrote: > tested with HE910, LE910, LE910 V2, LE910 sv1 and everything is fine for me. I've pushed this to git master. -- Aleksander https://aleksander.es ___ ModemManager-devel

Re: [PATCH] base-bearer: stop connection status monitoring if no TTY available

On 24/03/17 21:20, Aleksander Morgado wrote: >>> +/* If CID not defined, error out */ >>> if (!MM_BROADBAND_BEARER (self)->priv->cid) { >>> -g_task_return_new_error (task, MM_CORE_ERROR, >>> MM_CORE_ERROR_FAILED, >>> +g_task_return_new_error (task, MM_CORE_ERROR, >>>

Re: [PATCH] broadband-bearer: set TTY as connected as soon as ATD replies

On Fri, Mar 24, 2017 at 9:35 PM, Dan Williams wrote: >> When the connection request is done via ATD, flag the port as >> connected as soon as the successful response is received, so that we >> remove our polling on the device right away. >> >>

Re: [PATCH] broadband-bearer: set TTY as connected as soon as ATD replies

On Fri, 2017-03-24 at 15:03 +0100, Aleksander Morgado wrote: > When the connection request is done via ATD, flag the port as > connected as soon as the successful response is received, so that we > remove our polling on the device right away. > > https://bugs.freedesktop.org/show_bug.cgi?id=99541

Re: [PATCH 2/2] broadband-modem: fix capabilities in 4G-only devices

On Fri, Mar 24, 2017 at 9:12 PM, Dan Williams wrote: >> The +CGSM capability is saying that the modem is a 3GPP modem, but >> that doesn't necessarily mean it's a GSM/UMTS modem, it could be a >> LTE-only device. >> >> We did add the GSM_UMTS capability when +CGSM was found, so

Re: [PATCH 1/2] broadband-modem, helpers: implement AT+WS46=? response parser

On Fri, Mar 24, 2017 at 9:22 PM, Aleksander Morgado wrote: >>> We want a parser that returns the full list of combinations found. >> >> Looks good to me except the comment: >> >> +/* Fixup the ANY value, based on whether LTE is supported or not >> >> the code under

Re: [PATCH] base-bearer: stop connection status monitoring if no TTY available

On Fri, Mar 24, 2017 at 9:15 PM, Dan Williams wrote: >> +/* If CID not defined, error out */ >> if (!MM_BROADBAND_BEARER (self)->priv->cid) { >> -g_task_return_new_error (task, MM_CORE_ERROR, >> MM_CORE_ERROR_FAILED, >> +g_task_return_new_error (task,

Re: [PATCH] base-bearer: stop connection status monitoring if no TTY available

On Fri, 2017-03-24 at 14:55 +0100, Aleksander Morgado wrote: > On modems with a single TTY for both control and data, we cannot use > the TTY to load connection status once we're in connected mode: > > Connection through a plain serial AT port (ttyUSB2) > (ttyUSB2): --> 'ATD*99***2#' >    

Re: [PATCH 2/2] broadband-modem: fix capabilities in 4G-only devices

On Sun, 2017-03-12 at 21:05 +0100, Aleksander Morgado wrote: > The +CGSM capability is saying that the modem is a 3GPP modem, but > that doesn't necessarily mean it's a GSM/UMTS modem, it could be a > LTE-only device. > > We did add the GSM_UMTS capability when +CGSM was found, so now we'll >

Re: [PATCH 1/2] broadband-modem,helpers: implement AT+WS46=? response parser

On Sun, 2017-03-12 at 21:05 +0100, Aleksander Morgado wrote: > We want a parser that returns the full list of combinations found. Looks good to me except the comment: +/* Fixup the ANY value, based on whether LTE is supported or not the code under that comment seems to use all modes, not

Re: [PATCH] Huawei: Ignore unsolicited message ^EONS

On 24/03/17 15:43, Riccardo Vangelisti wrote: > Ops, sorry :) > > Pushed now to git master after doing some minor alignment fixes. Thanks! -- Aleksander https://aleksander.es ___ ModemManager-devel mailing list

Re: [PATCH] telit: support QMI and MBIM modems

On Fri, Mar 24, 2017 at 3:33 PM, Daniele Palmas wrote: > So LN930 was a "special" modem, in the sense that was never produced > with Telit VID. Did it actually have a custom Telit firmware, or was it the original one from Intel? I see that this device also didn't have Telit VID

Re: [PATCH] telit: don't require udev tags to bind devices

Hi Aleksander, tested with HE910, LE910, LE910 V2, LE910 sv1 and everything is fine for me. On 24 March 2017 at 15:37, Carlo Lobrano wrote: > Hi, > > sure I can test it today or the next week > > BR, > Carlo > > On 24 March 2017 at 14:51, Aleksander Morgado

Re: [PATCH] telit: don't require udev tags to bind devices

Hi, sure I can test it today or the next week BR, Carlo On 24 March 2017 at 14:51, Aleksander Morgado wrote: > The vendor id/string based rules should already be enough to get the > telit plugin bind telit devices. > > This simplifies support for future Telit

Re: [PATCH] Huawei: Ignore unsolicited message ^EONS

Ops, sorry :) Il 24/03/2017 15:28, Aleksander Morgado ha scritto: Hey Riccardo, On Fri, Mar 24, 2017 at 3:03 PM, Riccardo Vangelisti wrote: Hi, I've found an unsolicited message (^EONS) that broke the incoming voice call in Huawei ME909s-120 modules. This patch

Re: [PATCH] telit: support QMI and MBIM modems

Hi Aleksander, 2017-03-24 14:48 GMT+01:00 Aleksander Morgado : > Vendor specific plugins that support QMI or MBIM based devices need to > handle the creation of these modems themselves. > > https://bugs.freedesktop.org/show_bug.cgi?id=100372 > --- > > Hey Carlo and

Re: [PATCH] Huawei: Ignore unsolicited message ^EONS

Hey Riccardo, On Fri, Mar 24, 2017 at 3:03 PM, Riccardo Vangelisti wrote: > Hi, I've found an unsolicited message (^EONS) that broke the incoming voice > call in Huawei ME909s-120 modules. > This patch can fix it (simply ignore it). > Could you make sure the patch

[PATCH] Huawei: Ignore unsolicited message ^EONS

Hi, I've found an unsolicited message (^EONS) that broke the incoming voice call in Huawei ME909s-120 modules. This patch can fix it (simply ignore it). diff --git a/plugins/huawei/mm-broadband-modem-huawei.c b/plugins/huawei/mm-broadband-modem-huawei.c index 0e375e1..4b6ba90 100644 ---

Re: [PATCH] telit: support QMI and MBIM modems

On Fri, Mar 24, 2017 at 2:57 PM, Carlo Lobrano wrote: >> I have a LN930 that I can switch to MBIM mode, but it exposes Intel's VID, >> not the Telit VID. Do you know if this would be something happening to all >> MBIM-capable Telit modems? > > this shouldn't happen. How do

[PATCH] broadband-bearer: set TTY as connected as soon as ATD replies

When the connection request is done via ATD, flag the port as connected as soon as the successful response is received, so that we remove our polling on the device right away. https://bugs.freedesktop.org/show_bug.cgi?id=99541 --- Hey Colin, Dan & everyone, This patch tries to minimize the

Re: [PATCH] telit: support QMI and MBIM modems

Hi Aleksander, > I have a LN930 that I can switch to MBIM mode, but it exposes Intel's VID, not the Telit VID. Do you know if this would be something happening to all MBIM-capable Telit modems? this shouldn't happen. How do you switch to MBIM mode? Carlo Il venerdì 24 marzo 2017, Aleksander

[PATCH] base-bearer: stop connection status monitoring if no TTY available

On modems with a single TTY for both control and data, we cannot use the TTY to load connection status once we're in connected mode: Connection through a plain serial AT port (ttyUSB2) (ttyUSB2): --> 'ATD*99***2#' (ttyUSB2): <-- 'CONNECT 1' (ttyUSB2): port now connected

[PATCH] telit: don't require udev tags to bind devices

The vendor id/string based rules should already be enough to get the telit plugin bind telit devices. This simplifies support for future Telit devices, as we wouldn't need any additional change in the plugin. It also helps when working with RS232 devices as the user wouldn't need to add the

[PATCH] telit: support QMI and MBIM modems

Vendor specific plugins that support QMI or MBIM based devices need to handle the creation of these modems themselves. https://bugs.freedesktop.org/show_bug.cgi?id=100372 --- Hey Carlo and Daniele, This patch makes the Telit plugin accept QMI and MBIM modems. Can any of you test it with such

[PATCH v2] Fixed wrong MEM1 value passed to +CPMS

Let modem_messaging_set_default_storage returns with error if current_sms_mem1_storage is MM_SMS_STORAGE_UNKNOWN --- I updated the patch according the code review, moreover I'd like to note a little difference respect the previous version: currently, even if +CPMS fails because of the wrong

Re: Default "ip-type" in modem-manager "simple-connect"?

Thanks a ton Aleksander !!! On Fri, Mar 24, 2017 at 2:43 PM, Aleksander Morgado < aleksan...@aleksander.es> wrote: > On Fri, Mar 24, 2017 at 4:20 AM, Ajay Garg wrote: > > If we don't specify ip-type parameter while doing a simple-connect via > mmcli > >

Re: Default "ip-type" in modem-manager "simple-connect"?

On Fri, Mar 24, 2017 at 4:20 AM, Ajay Garg wrote: > If we don't specify ip-type parameter while doing a simple-connect via mmcli > (http://manpages.ubuntu.com/manpages/trusty/man8/mmcli.8.html), what is the > default parameter picked? ipv4 or ipv6? Or whatever the network