[PATCH 4/5] log: Introduce function pointer to handle different log backends

2017-05-21 Thread Torsten Hilbrich
This allows for easier additions of other logging mechanism. --- src/mm-log.c | 53 ++--- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/src/mm-log.c b/src/mm-log.c index bedf88f..6578d68 100644 --- a/src/mm-log.c +++ b/src/mm-log.c

[PATCH 3/5] log: Add mapping from glib loglevel to syslog priority

2017-05-21 Thread Torsten Hilbrich
Improves readability of log_handler function. --- src/mm-log.c | 45 + 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/src/mm-log.c b/src/mm-log.c index ec622dc..bedf88f 100644 --- a/src/mm-log.c +++ b/src/mm-log.c @@ -82,6 +82,26 @@

[PATCH] v1: Logging cleanup and systemd journal support

2017-05-21 Thread Torsten Hilbrich
This series of patches is based on the "Logging and --help updates" series posted by Aleksander Morgado . It start with cleaning up some parts of the logging code. The the existing logging support (supporting syslog and file-based logging) is split into two different

[PATCH] cinterion: support changing modes in LTE capable devices

2017-05-21 Thread Aleksander Morgado
--- Hey, This patch implements some basic support for changing allowed modes for LTE capable Cinterion devices. Comments? --- plugins/cinterion/mm-broadband-modem-cinterion.c | 162 +++ 1 file changed, 77 insertions(+), 85 deletions(-) diff --git

[PATCH 1/4] iface-modem: consolidate signal quality and access tech polling

2017-05-21 Thread Aleksander Morgado
Plugins have two ways to update signal quality and access technology values: via unsolicited messages or via polling periodically. Instead of keeping separate contexts for polling signal quality and access technology values, we setup a common timeout to trigger both. This allows us to simplify in

[PATCH 3/4] port-serial-at: always prepend unsolicited message handlers

2017-05-21 Thread Aleksander Morgado
The generic modem has several URC handlers for generic messages, like +CIEV. But, there may be cases where the plugins themselves want to provide their own URC handlers to be run before the generic one. This patch enables this setup by always prepending the new URC handlers, so that the last ones

[PATCH 4/4] cinterion: use ^SIND unsolicited messages for access tech reporting

2017-05-21 Thread Aleksander Morgado
If the modem supports ^SIND psinfo reporting, we enable the URC and flag the access technology polling unsupported, so that we only update access technology via the +CIEV URCs. E.g.: (ttyACM1): --> 'AT^SIND="psinfo",1' (ttyACM1): <-- '^SIND: psinfo,1,10OK' Reporting initial access

Re: [PATCH 4/4] telit: remove custom +CMER enabling

2017-05-21 Thread Aleksander Morgado
On Sun, May 21, 2017 at 2:54 PM, Aleksander Morgado wrote: > +/* Our own enable now */ > +mm_base_modem_at_command_full ( > MM_BASE_MODEM (self), > mm_base_modem_peek_port_secondary (MM_BASE_MODEM (self)), > -unsolicited_enable_sequence,

[PATCH 1/4] helpers: new 'AT+CMER=?' parser

2017-05-21 Thread Aleksander Morgado
--- src/mm-modem-helpers.c | 136 + src/mm-modem-helpers.h | 25 src/tests/test-modem-helpers.c | 53 3 files changed, 214 insertions(+) diff --git a/src/mm-modem-helpers.c b/src/mm-modem-helpers.c index

Generic +CMER setting logic

2017-05-21 Thread Aleksander Morgado
Hey Dan, Carlo & everyone, This patch series implements the checking of the AT+CMER command parameters so that we can enable or disable them without error. The parser only checks the 'mode' (1st field) and 'ind' (4th field) settings, as those are the ones we request to update. Also modified

[PATCH 4/4] telit: remove custom +CMER enabling

2017-05-21 Thread Aleksander Morgado
This is now managed directly in the generic plugin. --- plugins/cinterion/mm-broadband-modem-cinterion.c | 2 + plugins/telit/mm-broadband-modem-telit.c | 84 2 files changed, 60 insertions(+), 26 deletions(-) diff --git