[PATCH 3/3] iface-modem-voice: port mm_iface_modem_voice_disable to use GTask

--- src/mm-iface-modem-voice.c | 89 -- 1 file changed, 47 insertions(+), 42 deletions(-) diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c index b075796b..73fb314a 100644 --- a/src/mm-iface-modem-voice.c +++

[PATCH 4/4] iface-modem-time: port update_network_timezone to use GTask

--- src/mm-iface-modem-time.c | 120 +++--- 1 file changed, 61 insertions(+), 59 deletions(-) diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c index eec340ed..41ca2f0e 100644 --- a/src/mm-iface-modem-time.c +++ b/src/mm-iface-modem-time.c

[PATCH 2/4] iface-modem-time: port mm_iface_modem_time_enable to use GTask

--- src/mm-iface-modem-time.c | 108 +- 1 file changed, 49 insertions(+), 59 deletions(-) diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c index efb8d386..74e497e7 100644 --- a/src/mm-iface-modem-time.c +++ b/src/mm-iface-modem-time.c

[PATCH 1/4] iface-modem-time: port mm_iface_modem_time_initialize to use GTask

--- src/mm-iface-modem-time.c | 93 --- 1 file changed, 40 insertions(+), 53 deletions(-) diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c index 85588d3f..efb8d386 100644 --- a/src/mm-iface-modem-time.c +++ b/src/mm-iface-modem-time.c

[PATCH 2/3] iface-modem-voice: port mm_iface_modem_voice_enable to use GTask

--- src/mm-iface-modem-voice.c | 108 - 1 file changed, 49 insertions(+), 59 deletions(-) diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c index 2a93907f..b075796b 100644 --- a/src/mm-iface-modem-voice.c +++

[PATCH 3/4] iface-modem-time: port mm_iface_modem_time_disable to use GTask

--- src/mm-iface-modem-time.c | 91 +-- 1 file changed, 48 insertions(+), 43 deletions(-) diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c index 74e497e7..eec340ed 100644 --- a/src/mm-iface-modem-time.c +++ b/src/mm-iface-modem-time.c

[PATCH 1/3] iface-modem-voice: port mm_iface_modem_voice_initialize to use GTask

--- src/mm-iface-modem-voice.c | 97 -- 1 file changed, 42 insertions(+), 55 deletions(-) diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c index ca65238b..2a93907f 100644 --- a/src/mm-iface-modem-voice.c +++

[PATCH 1/3] iface-modem-oma: port mm_iface_modem_oma_initialize to use GTask

--- src/mm-iface-modem-oma.c | 99 +--- 1 file changed, 43 insertions(+), 56 deletions(-) diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c index b8c48417..03e3deb6 100644 --- a/src/mm-iface-modem-oma.c +++ b/src/mm-iface-modem-oma.c @@

[PATCH] mm-broadband-modem-mbim: support hot swapping

If an MBIM modem supports unsolicited notifications for subscriber ready status, we can use it to detect when SIM cards have been removed and reinserted. Upon detection we should re- probe the modem so that we can configure it for the new SIM. --- src/mm-broadband-modem-mbim.c | 16

Re: [PATCH 1/1] telit: port mm-common-telit to use GTask

HI Aleksander, 2017-06-28 18:44 GMT+02:00 Aleksander Morgado : > Hey Daniele, > > See comments below. > > On 28/06/17 16:07, Daniele Palmas wrote: >> --- >> plugins/telit/mm-common-telit.c | 64 >> +++-- >> 1 file changed, 29

Re: [PATCH 2/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_enable to use GTask

On 28/06/17 18:30, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp-ussd.c | 73 > ++ > 1 file changed, 39 insertions(+), 34 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c >

Re: [PATCH 3/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_disable to use GTask

On 28/06/17 18:30, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp-ussd.c | 73 > ++ > 1 file changed, 39 insertions(+), 34 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c >

Re: [PATCH 1/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_initialize to use GTask

On 28/06/17 18:30, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp-ussd.c | 76 > ++ > 1 file changed, 39 insertions(+), 37 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c >

Re: [PATCH 1/1] telit: port mm-common-telit to use GTask

Hey Daniele, See comments below. On 28/06/17 16:07, Daniele Palmas wrote: > --- > plugins/telit/mm-common-telit.c | 64 > +++-- > 1 file changed, 29 insertions(+), 35 deletions(-) > > diff --git a/plugins/telit/mm-common-telit.c

Re: [PATCH 2/2 v4] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

On 28/06/17 17:30, Ben Chan wrote: > Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced > with 1, 2, 3, ..., etc. This patch adds a compatibility header, > ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to > the new values. > --- Pushed to git master,

[PATCH 1/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_initialize to use GTask

--- src/mm-iface-modem-3gpp-ussd.c | 76 ++ 1 file changed, 39 insertions(+), 37 deletions(-) diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c index db62cbbc..9dd4150f 100644 --- a/src/mm-iface-modem-3gpp-ussd.c +++

[PATCH 2/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_enable to use GTask

--- src/mm-iface-modem-3gpp-ussd.c | 73 ++ 1 file changed, 39 insertions(+), 34 deletions(-) diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c index 9dd4150f..ff6168d1 100644 --- a/src/mm-iface-modem-3gpp-ussd.c +++

[PATCH 3/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_disable to use GTask

--- src/mm-iface-modem-3gpp-ussd.c | 73 ++ 1 file changed, 39 insertions(+), 34 deletions(-) diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c index ff6168d1..1da9459f 100644 --- a/src/mm-iface-modem-3gpp-ussd.c +++

[PATCH 2/2 v4] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced with 1, 2, 3, ..., etc. This patch adds a compatibility header, ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to the new values. --- docs/reference/api/ModemManager-docs.xml | 5 +

Re: [PATCH 2/2 v2] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

On Wed, Jun 28, 2017 at 4:08 PM, Ben Chan wrote: > It seems to me that gtk-doc doesn't deal with `static const` > definitions. One silly workaround is to do something like this: > I'll look into supporting that in gtk-doc. > /** > * OLD_ENUM: > * > */ >

Re: [PATCH 2/2 v3] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

On Wed, Jun 28, 2017 at 5:08 PM, Ben Chan wrote: > Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced > with 1, 2, 3, ..., etc. This patch adds a compatibility header, > ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to > the new

Re: Re: Issues with modem reset

On Wed, Jun 28, 2017 at 4:42 PM, Piotr Figiel wrote: > > diff --git a/src/mm-broadband-bearer.c b/src/mm-broadband-bearer.c > index aeff2ef..db38970 100644 > --- a/src/mm-broadband-bearer.c > +++ b/src/mm-broadband-bearer.c > @@ -1586,8 +1586,10 @@ cgact_ready (MMBaseModem

[PATCH 2/2 v3] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced with 1, 2, 3, ..., etc. This patch adds a compatibility header, ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to the new values. --- docs/reference/api/ModemManager-docs.xml | 5 +

[PATCH 1/1] telit: port mm-common-telit to use GTask

--- plugins/telit/mm-common-telit.c | 64 +++-- 1 file changed, 29 insertions(+), 35 deletions(-) diff --git a/plugins/telit/mm-common-telit.c b/plugins/telit/mm-common-telit.c index 1e43588..cfd3292 100644 --- a/plugins/telit/mm-common-telit.c +++

Re: Re: Issues with modem reset

Hi Aleksander, Piotr,> I'm checking the logs and if my understanding is correct it looks like> some logic from bearer disconnect from the connection before the modem> reset happens still executes after modem was lost and when "new" modem> is probed, it looks like it may get in the way of AT ports

Re: Issues with modem reset

On Wed, Jun 28, 2017 at 10:54 AM, Piotr Figiel wrote: > thanks for reply. > Yes I could but I think it races with NM which tries to reestablish > connection, not sure if such testcase will help to debug this. > I've done some checks with with nmcli d disconnect ttyACM0 and it

Re: Issues with modem reset

Hi Aleksander, thanks for reply. Yes I could but I think it races with NM which tries to reestablish connection, not sure if such testcase will help to debug this. I've done some checks with with nmcli d disconnect ttyACM0 and it improved (though I'll redo this more systematically), but the

Re: Issues with modem reset

On Wed, Jun 28, 2017 at 10:27 AM, Piotr Figiel wrote: > I'm debugging it now but hints would be appreciated. Can you retry but before running the reset operation, do an explicit disconnection and/or disable? E.g. mmcli --simple-disconnect mmcli --disable mmcli --reset

Re: [PATCH 2/2 v2] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

Hey, On Wed, Jun 28, 2017 at 9:13 AM, Ben Chan wrote: > Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced > with 1, 2, 3, ..., etc. This patch adds a compatibility header, > ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to > the

Issues with modem reset

Hi Aleksander, modemmanager-devel, we're encountering an issue with modem manager when used with network manager, such that sometimes the modem's secondary port becomes unusable from modem manager after modem is reset with mmcli -r. The modem responds fine to AT commands when asked directly,

Re: [PATCH 3/3] iface-modem-messaging: port mm_iface_modem_messaging_disable to use GTask

On Tue, Jun 27, 2017 at 5:54 PM, Ben Chan wrote: > --- > src/mm-iface-modem-messaging.c | 89 > ++ > 1 file changed, 47 insertions(+), 42 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-iface-modem-messaging.c

Re: [PATCH 2/3] iface-modem-messaging: port mm_iface_modem_messaging_enable to use GTask

On Tue, Jun 27, 2017 at 5:54 PM, Ben Chan wrote: > --- > src/mm-iface-modem-messaging.c | 182 > - > 1 file changed, 91 insertions(+), 91 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-iface-modem-messaging.c

Re: [PATCH] iface-modem-firmware: port mm_iface_modem_firmware_initialize to use GTask

On 27/06/17 16:31, Ben Chan wrote: > --- > src/mm-iface-modem-firmware.c | 95 > +++ > 1 file changed, 41 insertions(+), 54 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-iface-modem-firmware.c b/src/mm-iface-modem-firmware.c > index

Re: [PATCH 2/2 v2] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

When adding this compat header, I noticed that __attribute__((deprecated)), which G_DEPRECATED_FOR is based on, can't be associated with macros. Both gcc and clang associated the attribute to the next identifier found after the macro definition, not the macro itself: #1

[PATCH 1/2 v2] enums: replace Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_*

3GPP TS 36.101 Table 5.5-1 refers the E-UTRA operating bands as 1, 2, 3, ..., etc. --- include/ModemManager-enums.h | 144 +++--- plugins/altair/mm-modem-helpers-altair-lte.c | 4 +- .../altair/tests/test-modem-helpers-altair-lte.c | 8 +-