Thanks for taking a look at this!
On Thu, Jun 29, 2017 at 3:22 AM, Carlo Lobrano wrote:
> Hi,
>
>> If I'm not mistaken, whenever a sim insert/removal event is detected, we
>> should just call
>> mm_broadband_modem_update_sim_hot_swap_detected(), which will trigger a
>> full
// sorry, re-sending to the group
Hi Aleksander,
2017-06-28 17:20 GMT+02:00 Aleksander Morgado :
> The key point is the kind of error to consider the action fatal and
> abort right away. If the device is removed, we should definitely take
> it as a fatal error and abort
---
src/mm-iface-modem-cdma.c | 82 +--
1 file changed, 44 insertions(+), 38 deletions(-)
diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c
index d7c6cf12..f35d6aa1 100644
--- a/src/mm-iface-modem-cdma.c
+++ b/src/mm-iface-modem-cdma.c
---
src/mm-iface-modem-3gpp.c | 103 --
1 file changed, 53 insertions(+), 50 deletions(-)
diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c
index b9446507..772d3609 100644
--- a/src/mm-iface-modem-3gpp.c
+++ b/src/mm-iface-modem-3gpp.c
---
src/mm-iface-modem-3gpp.c | 95 +--
1 file changed, 43 insertions(+), 52 deletions(-)
diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c
index bcd12e85..e06e36cf 100644
--- a/src/mm-iface-modem-3gpp.c
+++ b/src/mm-iface-modem-3gpp.c
---
src/mm-iface-modem-cdma.c | 102 +-
1 file changed, 46 insertions(+), 56 deletions(-)
diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c
index 6340b031..d7c6cf12 100644
--- a/src/mm-iface-modem-cdma.c
+++ b/src/mm-iface-modem-cdma.c
---
src/mm-iface-modem-3gpp.c | 83 ++-
1 file changed, 46 insertions(+), 37 deletions(-)
diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c
index 772d3609..255e75f4 100644
--- a/src/mm-iface-modem-3gpp.c
+++ b/src/mm-iface-modem-3gpp.c
On 29/06/17 11:09, Daniele Palmas wrote:
> ---
> v2: address GTask cancellation issues highlighted by Aleksander
> ---
> plugins/telit/mm-common-telit.c | 65
> +++--
> 1 file changed, 30 insertions(+), 35 deletions(-)
>
Pushed to git master, thanks.
> diff
---
v2: address GTask cancellation issues highlighted by Aleksander
---
plugins/telit/mm-common-telit.c | 65 +++--
1 file changed, 30 insertions(+), 35 deletions(-)
diff --git a/plugins/telit/mm-common-telit.c b/plugins/telit/mm-common-telit.c
index
On 29/06/17 10:51, Aleksander Morgado wrote:
>> +if (self->priv->last_ready_state !=
>> MBIM_SUBSCRIBER_READY_STATE_SIM_NOT_INSERTED &&
>> +ready_state == MBIM_SUBSCRIBER_READY_STATE_SIM_NOT_INSERTED) {
>> +/* SIM has been removed */
>> +
On 29/06/17 06:44, Ben Chan wrote:
> ---
> src/mm-iface-modem-time.c | 120
> +++---
> 1 file changed, 61 insertions(+), 59 deletions(-)
>
Pushed to git master, thanks.
> diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c
> index
On 29/06/17 06:44, Ben Chan wrote:
> ---
> src/mm-iface-modem-time.c | 93
> ---
> 1 file changed, 40 insertions(+), 53 deletions(-)
>
Pushed to git master, thanks.
> diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c
> index
On 29/06/17 06:44, Ben Chan wrote:
> ---
> src/mm-iface-modem-time.c | 108
> +-
> 1 file changed, 49 insertions(+), 59 deletions(-)
>
Pushed to git master, thanks.
> diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c
> index
On 29/06/17 06:44, Ben Chan wrote:
> ---
> src/mm-iface-modem-time.c | 91
> +--
> 1 file changed, 48 insertions(+), 43 deletions(-)
>
Pushed to git master, thanks.
> diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c
> index
On 29/06/17 06:44, Ben Chan wrote:
> ---
> src/mm-iface-modem-voice.c | 108
> -
> 1 file changed, 49 insertions(+), 59 deletions(-)
>
Pushed to git master, thanks.
> diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c
> index
On 29/06/17 06:44, Ben Chan wrote:
> ---
> src/mm-iface-modem-voice.c | 89
> --
> 1 file changed, 47 insertions(+), 42 deletions(-)
>
Pushed to git master, thanks.
> diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c
> index
On 29/06/17 06:43, Ben Chan wrote:
> ---
> src/mm-iface-modem-oma.c | 87
> +---
> 1 file changed, 46 insertions(+), 41 deletions(-)
>
Pushed to git master, thanks.
> diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c
> index
On 29/06/17 06:43, Ben Chan wrote:
> ---
> src/mm-iface-modem-oma.c | 125
> ++-
> 1 file changed, 59 insertions(+), 66 deletions(-)
>
Pushed to git master, thanks.
> diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c
> index
On 29/06/17 06:44, Ben Chan wrote:
> ---
> src/mm-iface-modem-voice.c | 97
> --
> 1 file changed, 42 insertions(+), 55 deletions(-)
>
Pushed to git master, thanks.
> diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c
> index
On 29/06/17 06:43, Ben Chan wrote:
> ---
> src/mm-iface-modem-oma.c | 99
> +---
> 1 file changed, 43 insertions(+), 56 deletions(-)
>
Pushed to git master, thanks.
> diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c
> index
Hey Eric,
+Carlo in CC
Carlo, would also like your opinion on this.
On 28/06/17 23:46, Eric Caruso wrote:
> If an MBIM modem supports unsolicited notifications for
> subscriber ready status, we can use it to detect when SIM cards
> have been removed and reinserted. Upon detection we should re-
If an MBIM modem supports unsolicited notifications for
subscriber ready status, we can use it to detect when SIM cards
have been removed and reinserted. Upon detection we should re-
probe the modem so that we can configure it for the new SIM.
---
src/mm-broadband-modem-mbim.c | 16
22 matches
Mail list logo