[PATCH] base-sim: remove unused wait_for_unlock_id in SendPinPukContext

Commit d27e40ae9 ("core: new `Initializing' state in the global modem state machine") added a 'wait_for_unlock_id' field to SendPinPukContext, but never actually set it up. --- src/mm-base-sim.c | 4 1 file changed, 4 deletions(-) diff --git a/src/mm-base-sim.c b/src/mm-base-sim.c index

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

On Fri, Jun 30, 2017 at 1:00 AM, Aleksander Morgado wrote: > On 29/06/17 19:20, Eric Caruso wrote: >> Thanks for taking a look at this! >> >> On Thu, Jun 29, 2017 at 3:22 AM, Carlo Lobrano wrote: >>> Hi, >>> If I'm not mistaken, whenever a sim

Re: [PATCH] iface-modem: use g_new0 instead of g_slice_new0 to allocate context

On 30/06/17 15:27, Ben Chan wrote: > By using g_new0 instead of g_slice_new0 to allocate certain context > structs, we can simply use g_free as GDestroyNotify in > g_task_set_task_data and get rid of those functions that solely wrap the > g_slice_free call. Pushed to git master, thanks. > --- >

[PATCH] iface-modem: use g_new0 instead of g_slice_new0 to allocate context

By using g_new0 instead of g_slice_new0 to allocate certain context structs, we can simply use g_free as GDestroyNotify in g_task_set_task_data and get rid of those functions that solely wrap the g_slice_free call. --- src/mm-iface-modem.c | 20 1 file changed, 4

[PATCH] bearer-mbim: port MMBearerMbim to use GTask

--- src/mm-bearer-mbim.c | 270 +-- 1 file changed, 131 insertions(+), 139 deletions(-) diff --git a/src/mm-bearer-mbim.c b/src/mm-bearer-mbim.c index 44c1c861..439de812 100644 --- a/src/mm-bearer-mbim.c +++ b/src/mm-bearer-mbim.c @@ -70,12 +70,13

Re: [PATCH v2] iface-modem: port mm_iface_modem_wait_for_final_state to use GTask

On 30/06/17 12:52, Ben Chan wrote: > --- > src/mm-iface-modem.c | 103 > --- > 1 file changed, 64 insertions(+), 39 deletions(-) > Pushed to git master after a minor coding style fixup (see below). Also, not sure we really needed a explicit

[PATCH 1/1] telit: port mm-broadband-modem-telit to use GTask

--- plugins/telit/mm-broadband-modem-telit.c | 285 ++- 1 file changed, 131 insertions(+), 154 deletions(-) diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c index 55deeed..2054b0c 100644 ---

[PATCH v2] iface-modem: port mm_iface_modem_wait_for_final_state to use GTask

--- src/mm-iface-modem.c | 103 --- 1 file changed, 64 insertions(+), 39 deletions(-) diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c index 586f5565..908d7d1c 100644 --- a/src/mm-iface-modem.c +++ b/src/mm-iface-modem.c @@ -89,27 +89,49 @@

Re: [PATCH 09/10] iface-modem: port internal_load_unlock_required to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 85 > +++- > 1 file changed, 45 insertions(+), 40 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 08/10] iface-modem: port mm_iface_modem_update_lock_info to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 95 > > 1 file changed, 51 insertions(+), 44 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 04/10] iface-modem: port mm_iface_modem_create_bearer to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 53 > > 1 file changed, 24 insertions(+), 29 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 03/10] iface-modem: port mm_iface_modem_disable to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index d718e914..28f3bf01 100644 > --- a/src/mm-iface-modem.c

Re: [PATCH 07/10] iface-modem: port mm_iface_modem_set_power_state to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 169 > +++ > 1 file changed, 91 insertions(+), 78 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 05/10] iface-modem: port mm_iface_modem_set_current_bands to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 64 > ++-- > 1 file changed, 32 insertions(+), 32 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 02/10] iface-modem: port mm_iface_modem_enable to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 146 > +-- > 1 file changed, 71 insertions(+), 75 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 01/10] iface-modem: port mm_iface_modem_initialize to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 426 > --- > 1 file changed, 231 insertions(+), 195 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH v2] sms-qmi: port MMSmsQmi to use GTask

On 30/06/17 11:57, Ben Chan wrote: > --- > src/mm-sms-qmi.c | 266 > +-- > 1 file changed, 142 insertions(+), 124 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-sms-qmi.c b/src/mm-sms-qmi.c > index 6f604844..fabd417a

[PATCH v2] sms-qmi: port MMSmsQmi to use GTask

--- src/mm-sms-qmi.c | 266 +-- 1 file changed, 142 insertions(+), 124 deletions(-) diff --git a/src/mm-sms-qmi.c b/src/mm-sms-qmi.c index 6f604844..fabd417a 100644 --- a/src/mm-sms-qmi.c +++ b/src/mm-sms-qmi.c @@ -57,12 +57,13 @@

Re: [PATCH] iface-modem-3gpp: port mm_iface_modem_3gpp_register_in_network to use GTask

On 30/06/17 11:21, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp.c | 93 > +-- > 1 file changed, 49 insertions(+), 44 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c > index

Re: [PATCH] sim-mbim: port MMSimMbim to use GTask

On 30/06/17 11:16, Ben Chan wrote: > --- > src/mm-sim-mbim.c | 201 > -- > 1 file changed, 89 insertions(+), 112 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-sim-mbim.c b/src/mm-sim-mbim.c > index 3d99c99d..f112fe7d

Re: [PATCH] sms-qmi: port MMSmsQmi to use GTask

On 30/06/17 11:17, Ben Chan wrote: > --- > src/mm-sms-qmi.c | 263 > +-- > 1 file changed, 139 insertions(+), 124 deletions(-) > Looks like this one won't compile properly: mm-sms-qmi.c: In function ‘sms_send_from_storage’:

[PATCH 08/10] iface-modem: port mm_iface_modem_update_lock_info to use GTask

--- src/mm-iface-modem.c | 95 1 file changed, 51 insertions(+), 44 deletions(-) diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c index e70706df..e084e1da 100644 --- a/src/mm-iface-modem.c +++ b/src/mm-iface-modem.c @@ -2958,13

[PATCH 04/10] iface-modem: port mm_iface_modem_create_bearer to use GTask

--- src/mm-iface-modem.c | 53 1 file changed, 24 insertions(+), 29 deletions(-) diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c index 28f3bf01..59ff753e 100644 --- a/src/mm-iface-modem.c +++ b/src/mm-iface-modem.c @@ -454,17 +454,12

[PATCH 07/10] iface-modem: port mm_iface_modem_set_power_state to use GTask

--- src/mm-iface-modem.c | 169 +++ 1 file changed, 91 insertions(+), 78 deletions(-) diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c index d7c325c7..e70706df 100644 --- a/src/mm-iface-modem.c +++ b/src/mm-iface-modem.c @@ -3199,8 +3199,6

[PATCH 02/10] iface-modem: port mm_iface_modem_enable to use GTask

--- src/mm-iface-modem.c | 146 +-- 1 file changed, 71 insertions(+), 75 deletions(-) diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c index 0d5e1168..d718e914 100644 --- a/src/mm-iface-modem.c +++ b/src/mm-iface-modem.c @@ -3501,7 +3501,7

[PATCH 01/10] iface-modem: port mm_iface_modem_initialize to use GTask

--- src/mm-iface-modem.c | 426 --- 1 file changed, 231 insertions(+), 195 deletions(-) diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c index 7f040d1d..0d5e1168 100644 --- a/src/mm-iface-modem.c +++ b/src/mm-iface-modem.c @@ -3771,7

[PATCH 05/10] iface-modem: port mm_iface_modem_set_current_bands to use GTask

--- src/mm-iface-modem.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c index 59ff753e..e32eda5e 100644 --- a/src/mm-iface-modem.c +++ b/src/mm-iface-modem.c @@ -2169,18

[PATCH] iface-modem-3gpp: port mm_iface_modem_3gpp_register_in_network to use GTask

--- src/mm-iface-modem-3gpp.c | 93 +-- 1 file changed, 49 insertions(+), 44 deletions(-) diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c index 255e75f4..e1a61ced 100644 --- a/src/mm-iface-modem-3gpp.c +++ b/src/mm-iface-modem-3gpp.c

[PATCH] sms-qmi: port MMSmsQmi to use GTask

--- src/mm-sms-qmi.c | 263 +-- 1 file changed, 139 insertions(+), 124 deletions(-) diff --git a/src/mm-sms-qmi.c b/src/mm-sms-qmi.c index 6f604844..f42319d0 100644 --- a/src/mm-sms-qmi.c +++ b/src/mm-sms-qmi.c @@ -57,12 +57,13 @@

[PATCH] sim-mbim: port MMSimMbim to use GTask

--- src/mm-sim-mbim.c | 201 -- 1 file changed, 89 insertions(+), 112 deletions(-) diff --git a/src/mm-sim-mbim.c b/src/mm-sim-mbim.c index 3d99c99d..f112fe7d 100644 --- a/src/mm-sim-mbim.c +++ b/src/mm-sim-mbim.c @@ -50,12 +50,13 @@

Re: [PATCH 5/5] iface-modem-cdma: port mm_iface_modem_cdma_run_registration_checks to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-cdma.c | 207 > +- > 1 file changed, 112 insertions(+), 95 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c > index

Re: [PATCH 1/5] iface-modem-cdma: port mm_iface_modem_cdma_initialize to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-cdma.c | 105 > +- > 1 file changed, 48 insertions(+), 57 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c > index

Re: [PATCH 2/5] iface-modem-cdma: port mm_iface_modem_cdma_enable to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-cdma.c | 102 > +- > 1 file changed, 46 insertions(+), 56 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c > index

Re: [PATCH 4/4] iface-modem-3gpp: port mm_iface_modem_3gpp_reload_current_registration_info to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp.c | 83 > ++- > 1 file changed, 46 insertions(+), 37 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c > index

Re: [PATCH 2/4] iface-modem-3gpp: port mm_iface_modem_3gpp_enable to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp.c | 144 > ++ > 1 file changed, 70 insertions(+), 74 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c > index

Re: [PATCH 3/4] iface-modem-3gpp: port mm_iface_modem_3gpp_disable to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp.c | 103 > -- > 1 file changed, 53 insertions(+), 50 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c > index

Re: [PATCH 1/4] iface-modem-3gpp: port mm_iface_modem_3gpp_initialize to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp.c | 95 > +-- > 1 file changed, 43 insertions(+), 52 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c > index

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

On 29/06/17 19:20, Eric Caruso wrote: > Thanks for taking a look at this! > > On Thu, Jun 29, 2017 at 3:22 AM, Carlo Lobrano wrote: >> Hi, >> >>> If I'm not mistaken, whenever a sim insert/removal event is detected, we >>> should just call >>>