Re: [PATCH] broadband-bearer: run init sequence after flashing in disconnection

Hey, > > I'm having a go at building the extended reset/hangup (with checking) > logic on top of this, if you wanted to go ahead and apply this in the > meantime? > Ah, yes, thanks for reminding me, I had lost track of this patch. Pushed now to git master and backported it to mm-1-6 and mm-1-4.

Re: [PATCH] mm-broadband-modem-mbim: reprobe on mbim-proxy death

Thanks for taking a look! On Fri, Aug 4, 2017 at 5:39 AM, Aleksander Morgado wrote: > Ideally mbim-proxy should never crash :) Do you have any issue that ends up > in the proxy crashing, or is this just a nice to have recovery method? Mostly this is a nice-to-have,

Re: [PATCH] bearer-mbim: refactor disconnect_set_ready()

On Fri, 2017-08-04 at 14:00 +0200, Aleksander Morgado wrote: > Try to make it more clear which are the different branches in the > logic, and jump out as soon as the branch is finished. > --- > > Hey, > > How about something like this? LGTM > Cheers! > > --- >  src/mm-bearer-mbim.c | 96

Re: [PATCH] broadband-bearer: run init sequence after flashing in disconnection

Hi Aleksander, I'm having a go at building the extended reset/hangup (with checking) logic on top of this, if you wanted to go ahead and apply this in the meantime? Cheers, Tim. On 25/07/17 13:48, Aleksander Morgado wrote: > The init-sequence configured for the TTY that is being used as data >

Re: DW5560 (Ericsson F5321) - GPS capability not available

Hey! > > thank you very much, this is correct solution, I've just tested. > > After steps you recommended and enabling the modem: > > # mmcli -m 0 --location-status > > /org/freedesktop/ModemManager1/Modem/0 > > Location | capabilities: '3gpp-lac-ci, gps-raw,

Re: DW5560 (Ericsson F5321) - GPS capability not available

Hey Aleksander, thank you very much, this is correct solution, I've just tested. After steps you recommended and enabling the modem: # mmcli -m 0 --location-status /org/freedesktop/ModemManager1/Modem/0 Location | capabilities: '3gpp-lac-ci, gps-raw,

Re: Sending SMS in PDU mode fails.

On Fri, Aug 4, 2017 at 4:14 PM, Daniele Palmas wrote: > > as far as I remember 3GPP pdu should be supported, but maybe this > could depend on firmware customizations. > Just in case, this is the information for the Modem I am using: - Hardware |

Re: Sending SMS in PDU mode fails.

Hi Aleksander and José, 2017-08-04 15:24 GMT+02:00 Aleksander Morgado : > Hey José, Carlo & Daniele > > On Fri, Aug 4, 2017 at 10:27 AM, José wrote: >> I am trying the same thing with the Telit LE866. With that modem I am >> able to send SMSs in

Re: Sending SMS in PDU mode fails.

On Fri, Aug 4, 2017 at 3:24 PM, Aleksander Morgado wrote: > Hum I totally believe I did send SMS in PDU mode with the Telit > LE866 a while back... What is the error you're getting, and which is > the actual PDU you're trying to send? > Sorry, I forgot to include

Re: [PATCH 1/2] sim-qmi: remove unused variables

On 04/08/17 00:55, Ben Chan wrote: > --- > src/mm-sim-qmi.c | 12 > 1 file changed, 12 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-sim-qmi.c b/src/mm-sim-qmi.c > index 2ae15147..725e073e 100644 > --- a/src/mm-sim-qmi.c > +++ b/src/mm-sim-qmi.c > @@ -480,9

Re: [PATCH v2] altair-lte: don't use send-delay=0

On 04/08/17 09:44, Ben Chan wrote: > On the modem with firmware revision ALT3100_04_05_06_10_A8_TF > (LTEUSB_02_04_05_10_53), it's observed that port probing doesn't > complete successfully when send-delay=0 is used. > --- That's perfect, thanks. Pushed to git master. >

Re: [PATCH 2/2] port-probe: remove unused variable

On 04/08/17 00:55, Ben Chan wrote: > --- > src/mm-port-probe.c | 2 -- > 1 file changed, 2 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-port-probe.c b/src/mm-port-probe.c > index cfe0763c..640c319a 100644 > --- a/src/mm-port-probe.c > +++ b/src/mm-port-probe.c > @@

Re: [PATCH] location-gps-nmea: fix memory leaks

>> sequence = g_strdup_printf ("%s%s%s", >> previous, >> @@ -118,7 +121,14 @@ gboolean >> mm_location_gps_nmea_add_trace (MMLocationGpsNmea *self, >> const gchar *trace) >> { >> -return

Re: [PATCH] broadband-modem: fix an ineffective `g_assert (equip_id)'

On Thu, Aug 3, 2017 at 11:41 PM, Ben Chan wrote: > This patch fixes an ineffective `g_assert (equip_id)' in > modem_load_equipment_identifier_finish(). After mm_parse_gsn() succeeds, > `equip_id' is freed but not reset to NULL, so `g_assert (equip_id)' will > never assert

Re: DW5560 (Ericsson F5321) - GPS capability not available

Hey, > > on Dell E6430 with DW5560 (Ericsson F5321) card installed, I can use > mmcli to correctly connect to the internet, it works pretty nice :) > > However I am not able to control modem GPS capabilities through MM. > Previously I enabled GPS NMEA stream through wvdial conf like this: > >

Re: ModemManager and Iridium 9522b

Hey Eric, > > Thanks for the quick reply! I don't think that is possible. I don't think > it even likes 38400. See below from the manual: > > 5.121 +IPR - Fixed DTE Rate (Revised Implementation) > > This implementation applies to the 9522A/9505A IS060xx and later and all > software releases

Re: [PATCH] mm-broadband-modem-mbim: reprobe on mbim-proxy death

Hey! On 03/08/17 22:56, Eric Caruso wrote: > In case mbim-proxy crashes, ModemManager needs to be able to > recognize this and respawn the proxy so we don't lose access > to the modem. Do this by subscribing to the device removal > signal on MbimDevice and reprobing the modem when we lose the >

Re: [PATCH v2] broadband-modem-qmi: fix potential use-after-freed issues

On 03/08/17 23:25, Ben Chan wrote: > This patch fixes some potential use-after-freed issues in > dms_get_ids_ready(). When an invalid ESN / MEID is retrieved, > `ctx->self->priv->esn' / `ctx->self->priv->meid' is freed but not reset > to NULL. If no IMEI is retrieved, `str' can be set to the

Re: [PATCH] huawei: remove redundant call to huawei_parse_auth_type()

On 03/08/17 22:34, Dan Williams wrote: > On Thu, 2017-08-03 at 13:25 -0700, Ben Chan wrote: >> This patch removes a redundant `encoded_auth = huawei_parse_auth_type >> (auth)` >> in connect_3gpp_context_step(). > > LGTM > Pushed to git master, thanks! >> --- >>

[PATCH] bearer-mbim: refactor disconnect_set_ready()

Try to make it more clear which are the different branches in the logic, and jump out as soon as the branch is finished. --- Hey, How about something like this? Cheers! --- src/mm-bearer-mbim.c | 96 +--- 1 file changed, 53 insertions(+), 43

Re: [PATCH] bearer-mbim: avoid accessing invalid session_id and nw_error

On 03/08/17 22:30, Dan Williams wrote: > On Thu, 2017-08-03 at 13:24 -0700, Ben Chan wrote: >> This patch fixes an issue in disconnect_set_ready(). If >> mbim_message_connect_response_parse(), `session_id' and `nw_error' >> are >> not set to a valid value, and thus shouldn't be used. > > LGTM;

DW5560 (Ericsson F5321) - GPS capability not available

Hi, on Dell E6430 with DW5560 (Ericsson F5321) card installed, I can use mmcli to correctly connect to the internet, it works pretty nice :) However I am not able to control modem GPS capabilities through MM. Previously I enabled GPS NMEA stream through wvdial conf like this: [Dialer gps] Modem

Re: Sending SMS in PDU mode fails.

I am trying the same thing with the Telit LE866. With that modem I am able to send SMSs in Text mode using AT commands, but no in PDU mode. I have been told that "Telit's PDU mode doesn't use the standard GSM PDUs" but I am checking the AT Reference sheet and this is not clear to me. Does anyone

[PATCH v2] altair-lte: don't use send-delay=0

On the modem with firmware revision ALT3100_04_05_06_10_A8_TF (LTEUSB_02_04_05_10_53), it's observed that port probing doesn't complete successfully when send-delay=0 is used. --- plugins/altair/mm-plugin-altair-lte.c | 1 - 1 file changed, 1 deletion(-) diff --git