Re: [review] u-blox auth settings fix

2018-07-10 Thread Dan Williams
On Fri, 2018-06-22 at 16:57 +0200, Aleksander Morgado wrote: > Hey, > > I've pushed a new MR to gitlab fixing the authentication settings > request used in u-blox so that it always contains user/pass string > fields, even if empty, as per the AT command reference. > >

Re: [review] skip concatenated AT commands

2018-07-10 Thread Dan Williams
On Fri, 2018-06-22 at 16:58 +0200, Aleksander Morgado wrote: > Hey, > > I've pushed a MR to gitlab to avoid using concatenated AT commands in > the generic plugin: > https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_re > quests/4 > > Looks like there are modems out there (u-blox

Re: [review] skip unneeded extra modem references on async actions

2018-07-10 Thread Dan Williams
On Fri, 2018-06-22 at 17:00 +0200, Aleksander Morgado wrote: > Hey, > > Since we use GTask and the g_task_get_source_object() is a quick way > to retrieve the source object owning the async action, there's no > point in having an additional object reference in the private context > associated to

Re: [PATCH] blacklist: remove OpenMoko Hubs from the blacklist

2018-07-10 Thread Aleksander Morgado
On 10/07/18 16:03, Alexander Couzens wrote: > The problem of full vendor blacklist are hubs. > Because ATTRS{} matches all devices in the tree, > a modem connected to a OpenMoko hub will be blacklisted as well. > --- Pushed, thanks. > src/77-mm-usb-device-blacklist.rules | 4 ++-- > 1 file

[PATCH] blacklist: remove OpenMoko Hubs from the blacklist

2018-07-10 Thread Alexander Couzens
The problem of full vendor blacklist are hubs. Because ATTRS{} matches all devices in the tree, a modem connected to a OpenMoko hub will be blacklisted as well. --- src/77-mm-usb-device-blacklist.rules | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: libmm-glib usage: freeing object allocations correctly

2018-07-10 Thread Aleksander Morgado
Hey, > I am using the libmm-glib API to query bearer status periodically and > synchronously from MM(v1.6.4) from my own linux process. I have used mmcli > as an example as was suggested on this forum previously. > >