[PATCH] broadband-modem: initialize 'tac' in registration_status_check_ready()

2018-08-09 Thread Ben Chan
mm-broadband-modem.c:4395:13: error: variable 'tac' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (act == MM_MODEM_ACCESS_TECHNOLOGY_LTE) { ^ mm-broadband-modem.c:4407:75: note: uninitialized

Re: Adding AT commands to activate call audio over USB endpoint

2018-08-09 Thread Aleksander Morgado
Hey We're using a SIMCom SIM7100 modem which has the ability to exchange call audio data over a USB serial endpoint⁰. To enable this, the modem needs an AT command after the call has connected, AT+CPCMREG=1, and a command after call has disconnected, AT+CPCMREG=0. >>>

Re: [review] Use AT+CESQ for signal interface in MBIM modems if TTY available

2018-08-09 Thread Aleksander Morgado
On Thu, Aug 9, 2018 at 4:39 PM, Aleksander Morgado wrote: >>> > This MR enables support for the "Signal" interface in MBIM modems >>> > if >>> > they expose an AT-capable TTY port and AT+CESQ is supported. If no >>> > AT >>> > port is available in the device, the modem will report no extended >>>

Re: [review] Use AT+CESQ for signal interface in MBIM modems if TTY available

2018-08-09 Thread Aleksander Morgado
>> > This MR enables support for the "Signal" interface in MBIM modems >> > if >> > they expose an AT-capable TTY port and AT+CESQ is supported. If no >> > AT >> > port is available in the device, the modem will report no extended >> > signal capabilities, as it was doing until now for all MBIM

Re: [review] Use AT+CESQ for signal interface in MBIM modems if TTY available

2018-08-09 Thread Dan Williams
On Thu, 2018-08-09 at 13:47 +0200, Aleksander Morgado wrote: > Hey, > > > > > This MR enables support for the "Signal" interface in MBIM modems > > if > > they expose an AT-capable TTY port and AT+CESQ is supported. If no > > AT > > port is available in the device, the modem will report no

Re: [review] Use AT+CESQ for signal interface in MBIM modems if TTY available

2018-08-09 Thread Aleksander Morgado
Hey, > > This MR enables support for the "Signal" interface in MBIM modems if > they expose an AT-capable TTY port and AT+CESQ is supported. If no AT > port is available in the device, the modem will report no extended > signal capabilities, as it was doing until now for all MBIM modems. > >

[review] MBIM ATDS service based 3GPP location and extended Signal interface support

2018-08-09 Thread Aleksander Morgado
Hey, The following MR introduces support for using the MBIM ATDS service extensions to query for 3GPP location (LAC/TAC/CID) as well as extended signal information (RSRP, RSRQ, RSSI...). The MR contains 3 commits but only the last 2 are relevant. The first one is a commit cherry-picked from the

Re: [PATCH] build: require libmbim 1.17.3

2018-08-09 Thread Aleksander Morgado
On 08/08/18 22:27, Ben Chan wrote: > libmbim 1.17.3 adds the support for MBIM_CID_PCO, which is used by > commit d68078b2ce0f ("broadband-modem-mbim: check if modem implements > MBIM_CID_PCO"). > --- Oops, this should have gone with the commit that introduced the new requirement. Thanks for

[review] Fix MM_SIGNAL_UNKNOWN usage

2018-08-09 Thread Aleksander Morgado
Hey, The following MR fixes how MM_SIGNAL_UNKNOWN is used to report unset values: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/24 I thought of deprecating the symbol and adding a new one instead, given that we're changing the actual value of the symbol, but that