Re: [PATCH] sim hot swap: improved error management

2017-07-31 Thread Eric Caruso
On Tue, Jul 25, 2017 at 4:48 AM, Aleksander Morgado wrote: > > Eric, could you validate the patch with your MBIM modem as well? > Everything looks good from over here. ___ ModemManager-devel mailing list

[PATCH] mm-broadband-modem-mbim: reprobe on mbim-proxy death

2017-08-03 Thread Eric Caruso
In case mbim-proxy crashes, ModemManager needs to be able to recognize this and respawn the proxy so we don't lose access to the modem. Do this by subscribing to the device removal signal on MbimDevice and reprobing the modem when we lose the connection to mbim-proxy. We can't just restart

Cleaning up SIM hot swap

2017-07-07 Thread Eric Caruso
While trying to implement setup_sim_hot_swap for MBIM modems, I noticed that I am setting up and enabling unsolicited events for SUBSCRIBER_INFO type notifications, but not cleaning them up. This might not end up affecting the user since the destruction of the modem object will disconnect the

Re: [PATCH v2] mm-broadband-modem-mbim: support SIM hot swapping

2017-07-11 Thread Eric Caruso
> > On Tue, Jul 11, 2017 at 3:09 AM, Eric Caruso <ejcar...@chromium.org> wrote: >> If an MBIM modem supports unsolicited notifications for >> subscriber ready status, we can use it to detect when SIM cards >> have been removed and reinserted. Upon detection we should

[PATCH v3] mm-broadband-modem-mbim: support SIM hot swapping

2017-07-11 Thread Eric Caruso
If an MBIM modem supports unsolicited notifications for subscriber ready status, we can use it to detect when SIM cards have been removed and reinserted. Upon detection we should re- probe the modem so that we can configure it for the new SIM. --- src/mm-broadband-modem-mbim.c | 94

[PATCH v2] mm-broadband-modem-mbim: support SIM hot swapping

2017-07-10 Thread Eric Caruso
If an MBIM modem supports unsolicited notifications for subscriber ready status, we can use it to detect when SIM cards have been removed and reinserted. Upon detection we should re- probe the modem so that we can configure it for the new SIM. --- src/mm-broadband-modem-mbim.c | 94

Re: [PATCH] sim hot swap: improved error management

2017-07-12 Thread Eric Caruso
That sounds fine to me. The improved error message for SIM hot swap being configured but the ports context failing to open is good too -- the logs could be misleading if MM couldn't open AT ports but enabling hot swap didn't require them (as is true for MBIM modems). On Wed, Jul 12, 2017 at 6:37

[PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-28 Thread Eric Caruso
If an MBIM modem supports unsolicited notifications for subscriber ready status, we can use it to detect when SIM cards have been removed and reinserted. Upon detection we should re- probe the modem so that we can configure it for the new SIM. --- src/mm-broadband-modem-mbim.c | 16

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-30 Thread Eric Caruso
On Fri, Jun 30, 2017 at 1:00 AM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > On 29/06/17 19:20, Eric Caruso wrote: >> Thanks for taking a look at this! >> >> On Thu, Jun 29, 2017 at 3:22 AM, Carlo Lobrano <c.lobr...@gmail.com> wrote: >>> Hi, &g

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-29 Thread Eric Caruso
Thanks for taking a look at this! On Thu, Jun 29, 2017 at 3:22 AM, Carlo Lobrano wrote: > Hi, > >> If I'm not mistaken, whenever a sim insert/removal event is detected, we >> should just call >> mm_broadband_modem_update_sim_hot_swap_detected(), which will trigger a >> full

[PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-29 Thread Eric Caruso
If an MBIM modem supports unsolicited notifications for subscriber ready status, we can use it to detect when SIM cards have been removed and reinserted. Upon detection we should re- probe the modem so that we can configure it for the new SIM. --- src/mm-broadband-modem-mbim.c | 16

Re: [PATCH v2] mm-broadband-modem-mbim: reprobe on mbim-proxy death

2017-08-09 Thread Eric Caruso
Are we waiting for the libmbim fixes for Sierra Wireless to go in before we push this patch, or is there something else I can improve here? Thanks, -Eric ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org

Re: [PATCH] mm-broadband-modem-mbim: reprobe on mbim-proxy death

2017-08-04 Thread Eric Caruso
Thanks for taking a look! On Fri, Aug 4, 2017 at 5:39 AM, Aleksander Morgado wrote: > Ideally mbim-proxy should never crash :) Do you have any issue that ends up > in the proxy crashing, or is this just a nice to have recovery method? Mostly this is a nice-to-have,

Re: [PATCH v2] mm-iface-modem: add check_for_sim_swap method and enable steps

2017-12-13 Thread Eric Caruso
Thanks for catching these! On Wed, Dec 13, 2017 at 1:20 AM, Aleksander Morgado wrote: > > +MM_IFACE_MODEM_GET_INTERFACE (self)->check_for_sim_swap_finish (self, > > res, ); > > +if (error) { > > This is not a big deal, but for methods returning a gboolean, it

[PATCH v3] mm-iface-modem: add check_for_sim_swap method and enable steps

2017-12-13 Thread Eric Caruso
When in low-power mode, some modems will not dispatch unsolicited notifications, such as for SIM hot swapping. There is code in MMBroadbandModemTelit to handle this by checking the SIM identifier during modem power up against the identifier cached in the SIM D-Bus object. If they're different, the

[PATCH v2] mm-iface-modem: add check_for_sim_swap method and enable steps

2017-12-12 Thread Eric Caruso
When in low-power mode, some modems will not dispatch unsolicited notifications, such as for SIM hot swapping. There is code in MMBroadbandModemTelit to handle this by checking the SIM identifier during modem power up against the identifier cached in the SIM D-Bus object. If they're different, the

Re: [PATCH] mm-iface-modem: add check_for_sim_swap method and enable steps

2017-12-06 Thread Eric Caruso
Does this look good to everyone else or is there something else I should do before we can put this in? ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

[PATCH] mm-broadband-modem-qmi: reprobe on qmi-proxy death

2017-10-20 Thread Eric Caruso
This allows us to reprobe the modem and respawn the qmi-proxy in case it dies on us. This gets us access to the modem and unsolicited notifications again. Do this by connecting to the device-removed signal on QmiDevice. --- configure.ac | 2 +- src/mm-broadband-modem-qmi.c | 70

[PATCH] mm-base-manager: remove element from hastable by key, not value

2018-02-20 Thread Eric Caruso
The hashtable is keyed on the UID of the MMDevice, and its hash function is g_str_hash. We shouldn't be passing a GObject into g_hash_table_remove because calling g_str_hash on an MMDevice is wrong. --- src/mm-base-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] mm-base-manager: ref MMDevice before releasing port

2018-02-21 Thread Eric Caruso
Releasing the port on the device looks benign but because it emits a signal, it could call device_context_port_released and unref the MMDevice in port_context_unref. This means the MMDevice might be disposed before we get to the g_object_ref and the subsequent call to g_hash_table_remove will try

[PATCH] qmi-device: small style fix

2018-12-03 Thread Eric Caruso
Remove a redundant comment and add a space between arguments. --- src/libqmi-glib/qmi-device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libqmi-glib/qmi-device.c b/src/libqmi-glib/qmi-device.c index 056e618..2251faf 100644 --- a/src/libqmi-glib/qmi-device.c +++

Instantiating rmnet devices for data ports on QRTR-based modems

2020-10-15 Thread Eric Caruso
Hey all, As part of the QRTR integration into MM we're trying to figure out whose responsibility it is to make rmnet_data net interfaces for a QRTR/IPA-based modem. I had started an MR[1] that gave this responsibility to libqmi, but it's not clear this is the right place for this to go. If we

Re: Instantiating rmnet devices for data ports on QRTR-based modems

2020-10-15 Thread Eric Caruso
Thanks for taking a look, see responses inline. On Thu, Oct 15, 2020 at 12:35 PM Aleksander Morgado wrote: > > > However, delegating it to MM also works. I think that the conceptual > > design is cleaner here as interacting with netlink to create > > interfaces isn't really something that makes

Re: Disabling eSIM

2020-10-23 Thread Eric Caruso
Which version of MM are you using? Recent builds expose endpoints in D-Bus and mmcli to switch the active SIM slot on a modem, so you can manually pick the physical SIM slot rather than the eSIM, if that's what you're trying to do. On Fri, Oct 23, 2020 at 7:49 AM Florin wrote: > > Hi all, > I

Re: Fibocom L850-GL / Intel XMM7360

2020-06-25 Thread Eric Caruso
specific firmware > versions? Are there carrier specific firmware > available too or is there a generic firmware necessary only? > > Thank you & best regards, > > Dennis > > On Wed, 2020-06-24 at 14:54 -0700, Eric Caruso wrote: > > On Chromebooks, we use the L850

Re: Fibocom L850-GL / Intel XMM7360

2020-06-24 Thread Eric Caruso
On Chromebooks, we use the L850-GL in USB mode and it works well. I believe the firmware we get from Fibocom forces the module into USB mode, though, so that might not be super helpful for this discussion. On Tue, Jun 23, 2020 at 4:21 AM Wassenberg, Dennis wrote: > > Hi all, > > thank you for

Re: No SIM Slot Paths

2021-11-17 Thread Eric Caruso
New enough QMI and MBIM modems have messages to gather all the data for each connected SIM. It's possible that the message is simply not supported by your modem, since 1.18.2 should be new enough such that the MBIM implementation of load_sim_slots, etc. is available. -Eric On Wed, Nov 17, 2021

Re: Is there a mean of blocking SMS within the modem manager?

2021-07-16 Thread Eric Caruso
I think this is considered out-of-scope -- ModemManager expects that whatever higher-level program displaying SMS to the user upon receipt would take care of functionality like blocking a number. To my understanding ModemManager does not keep persistent state that is e.g. configurable by the user

Re: Why does the command mmcli 3gpp-scan not return object for scan-networks array

2023-02-03 Thread Eric Caruso
Just adding a little clarification here, On Fri, Feb 3, 2023 at 4:27 AM Aleksander Morgado wrote: > > Hey, > > > I am currently evaluating the modemmanager in my Openwrt system. > > If I now enter the following command `mmcli -m 0 -J --3gpp-scan > > --timeout=300` to show the network providers