[PATCH v3] core: process SMS +CGMR response with regex

R response to a regex that allows for more flexibility and robustness, and adds unit tests around the parsing call. Signed-off-by: Nick Stevens <nick.stev...@digi.com> --- V2->V3: * Refactored parsing logic to use "goto" on error, simplifying logic for error handling V1->V2: *

Re: [PATCH v2] core: process SMS +CGMR response with regex

On Wed, Sep 16, 2015 at 09:21:48AM +0200, Aleksander Morgado wrote: > On Wed, Sep 16, 2015 at 12:26 AM, Dan Williams wrote: > >> +/* +CMGR: ,,(whitespace) */ > >> +/* The and fields are matched, but not currently > >> used */ > >> +r = g_regex_new > >>

Re: [PATCH v2] core: process SMS +CGMR response with regex

On Tue, Sep 15, 2015 at 05:26:06PM -0500, Dan Williams wrote: > On Tue, 2015-09-15 at 20:15 +0000, Nick Stevens wrote: > > Variability in the response style from certain modems causes the parsing > > of the +CGMR response to fail. For example, the Telit HE910 inserts an &

[PATCH v2] core: process SMS +CGMR response with regex

R response to a regex that allows for more flexibility and robustness, and adds unit tests around the parsing call. Signed-off-by: Nick Stevens <nick.stev...@digi.com> --- V1->V2: * Moved parsing logic to mm-modem-helpers.[ch] * Added unit tests for CGMR parsing call - Generic case base

[PATCH v2] core: enable unsolicited messages on secondary

. This change is needed for proper SMS operation on the Telit HE910, which requires that +CNMI be sent to both primary and secondary. Since a failure to send the +CNMI command on the secondary is a non-fatal error, it is unlikely that this will cause issues with other modems. Signed-off-by: Nick Stevens