Re: glib-mkenums error for ublox plugin

2017-02-16 Thread Aleksander Morgado 
On Thu, Feb 16, 2017 at 2:24 PM, Colin Helliwell
 wrote:
>>> (By the way - the configure summary is reporting "ModemManager 1.7.0"?)
>>
>>That is normal. The version in git master is 1.7.x; the next stablemajor 
>>release will be 1.8.0.
>
> Is there a schedule for release of 1.8.0?  (At some point I'd like to get 
> onto a fixed tag/branch as opposed to tracking the head)

Not yet, no. We may want to sync with new distribution releases,
though, suggestions welcome.

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: glib-mkenums error for ublox plugin

2017-02-16 Thread Colin Helliwell 

> On 15 February 2017 at 08:49 Aleksander Morgado  
> wrote:
> 
>> (By the way - the configure summary is reporting "ModemManager 1.7.0"?)
>
>That is normal. The version in git master is 1.7.x; the next stablemajor 
>release will be 1.8.0.

Is there a schedule for release of 1.8.0?  (At some point I'd like to get onto 
a fixed tag/branch as opposed to tracking the head)
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: glib-mkenums error for ublox plugin

2017-02-15 Thread Colin Helliwell 

> On 15 February 2017 at 09:12 Aleksander Morgado  
> wrote:
> 
> On Wed, Feb 15, 2017 at 9:49 AM, Aleksander Morgado
>  wrote:
> 
> > Worst case, we just add a custom mkdir step in those enums generation rules.
> 
> Could you test the attached patch?
> 

Hi Aleksander,
Yes, that seems to have fixed my issue there.
(Once I've squared away my overall migration over to Master, I'll push it into 
our version control & automated build, in order to be certain - will let you 
know if there's any problem)
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: glib-mkenums error for ublox plugin

2017-02-15 Thread Aleksander Morgado 
On Wed, Feb 15, 2017 at 9:49 AM, Aleksander Morgado
 wrote:
> Worst case, we just add a custom mkdir step in those enums generation rules.

Could you test the attached patch?

-- 
Aleksander
https://aleksander.es
From 56d0c49dc80a66bb606b5ecea94c1ecdbb046ed6 Mon Sep 17 00:00:00 2001
From: Aleksander Morgado 
Date: Wed, 15 Feb 2017 10:10:51 +0100
Subject: [PATCH] build: make sure subdir exists before running glib-mkenums

Reported-by: Colin Helliwell 
---
 configure.ac|  1 +
 plugins/Makefile.am | 22 +-
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/configure.ac b/configure.ac
index 3ac71efc..0ad35ae5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -44,6 +44,7 @@ dnl Required programs
 AC_PROG_CC
 AM_PROG_CC_C_O
 AC_PROG_INSTALL
+AC_PROG_MKDIR_P
 
 dnl Initialize libtool
 LT_PREREQ([2.2])
diff --git a/plugins/Makefile.am b/plugins/Makefile.am
index 86026fd5..596866b7 100644
--- a/plugins/Makefile.am
+++ b/plugins/Makefile.am
@@ -900,17 +900,21 @@ UBLOX_ENUMS_GENERATED = \
 	$(NULL)
 
 ublox/mm-ublox-enums-types.h: Makefile.am $(UBLOX_ENUMS_INPUTS) $(top_srcdir)/build-aux/mm-enums-template.h
-	$(AM_V_GEN) $(GLIB_MKENUMS) \
-		--fhead "#include \"mm-modem-helpers-ublox.h\"\n#ifndef __MM_UBLOX_ENUMS_TYPES_H__\n#define __MM_UBLOX_ENUMS_TYPES_H__\n" \
-		--template $(top_srcdir)/build-aux/mm-enums-template.h \
-		--ftail "#endif /* __MM_UBLOX_ENUMS_TYPES_H__ */\n" \
-		$(UBLOX_ENUMS_INPUTS) > $@
+	$(AM_V_GEN) \
+		$(MKDIR_P) ublox; \
+		$(GLIB_MKENUMS) \
+			--fhead "#include \"mm-modem-helpers-ublox.h\"\n#ifndef __MM_UBLOX_ENUMS_TYPES_H__\n#define __MM_UBLOX_ENUMS_TYPES_H__\n" \
+			--template $(top_srcdir)/build-aux/mm-enums-template.h \
+			--ftail "#endif /* __MM_UBLOX_ENUMS_TYPES_H__ */\n" \
+			$(UBLOX_ENUMS_INPUTS) > $@
 
 ublox/mm-ublox-enums-types.c: Makefile.am $(top_srcdir)/build-aux/mm-enums-template.c ublox/mm-ublox-enums-types.h
-	$(AM_V_GEN) $(GLIB_MKENUMS) \
-		--fhead "#include \"mm-ublox-enums-types.h\"" \
-		--template $(top_srcdir)/build-aux/mm-enums-template.c \
-		$(UBLOX_ENUMS_INPUTS) > $@
+	$(AM_V_GEN) \
+		$(MKDIR_P) ublox; \
+		$(GLIB_MKENUMS) \
+			--fhead "#include \"mm-ublox-enums-types.h\"" \
+			--template $(top_srcdir)/build-aux/mm-enums-template.c \
+			$(UBLOX_ENUMS_INPUTS) > $@
 
 libhelpers_ublox_la_SOURCES = \
 	ublox/mm-modem-helpers-ublox.c \
-- 
2.11.1

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: glib-mkenums error for ublox plugin

2017-02-15 Thread Aleksander Morgado 
Hey,

>> The issue is really related to the ublox subdir not existing before
>> calling glib-mkenums. In my setup, the directory is created before
>> glib-mkenums runs, though. What build tools are you using? i.e. which
>> automake version?
>>
>
> automake is version 1.15
> Possibly to do with parallel build threads?

Well, I do parallel builds all the time; and we also do VPATH builds
regularly (see e.g.
https://jenkins.modemmanager.org/job/ModemManager/). This doesn't mean
there's some bug in the build setup, there probably is.

For some reason the ublox subdir mkdir step isn't being added in the
Makefile, and that is required before glib_mkenums runs. Can you send
me the built plugins/Makefile file?

Worst case, we just add a custom mkdir step in those enums generation rules.

This issue doesn't happen on other glib-mkenums steps because in all
other cases the enums aren't generated in a subdir.

> If it helps, initial output from the build is
>
> automake (GNU automake) 1.15
> Copyright (C) 2014 Free Software Foundation, Inc.
> License GPLv2+: GNU GPL version 2 or later 
> 
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
>
> Written by Tom Tromey 
>and Alexandre Duret-Lutz .
> AUTOV is 1
> NOTE: Executing intltoolize --copy --force --automake
> NOTE: Executing ACLOCAL="aclocal 
> --system-acdir=/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/build/aclocal-copy/"
>  autoreconf --verbose --install --force --exclude=autopoint -I 
> /home/colin/100051-karo/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/m4/
> autoreconf: Entering directory `.'
> autoreconf: running: aclocal 
> --system-acdir=/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/build/aclocal-copy/
>  -I 
> /home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/m4/
>  -I 
> /home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/m4/
>  --force -I m4
> autoreconf: configure.ac: tracing
> autoreconf: running: libtoolize --copy --force
> libtoolize: putting auxiliary files in '.'.
> libtoolize: copying file './ltmain.sh'
> libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
> libtoolize: copying file 'm4/libtool.m4'
> libtoolize: copying file 'm4/ltoptions.m4'
> libtoolize: copying file 'm4/ltsugar.m4'
> libtoolize: copying file 'm4/ltversion.m4'
> libtoolize: copying file 'm4/lt~obsolete.m4'
> autoreconf: running: 
> /home/colin/100051/fsl-community-bsp/build_sysv/tmp/sysroots/x86_64-linux/usr/bin/autoconf
>  
> --include=/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/m4/
>  --force
> autoreconf: running: 
> /home/colin/100051/fsl-community-bsp/build_sysv/tmp/sysroots/x86_64-linux/usr/bin/autoheader
>  
> --include=/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/m4/
>  --force
> autoreconf: running: automake --add-missing --copy --force-missing
> configure.ac:41: installing './compile'
> configure.ac:50: installing './config.guess'
> configure.ac:50: installing './config.sub'
> configure.ac:29: installing './install-sh'
> configure.ac:29: installing './missing'
> Makefile.am: installing './INSTALL'
> cli/Makefile.am: installing './depcomp'
> autoreconf: running: gnu-configize
> autoreconf: Leaving directory `.'
> NOTE: Running 
> /home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/configure
>   --build=x86_64-linux--host=arm-poky-linux-gnueabi   
> --target=arm-poky-linux-gnueabi --prefix=/usr 
>   --exec_prefix=/usr  --bindir=/usr/bin   
> --sbindir=/usr/sbin --libexecdir=/usr/lib/modemmanager
>   --datadir=/usr/share--sysconfdir=/etc   
> --sharedstatedir=/com   --localstatedir=/var
> --libdir=/usr/lib   --includedir=/usr/include   
> --oldincludedir=/usr/include--infodir=/usr/share/info 
>   --mandir=/usr/share/man --disable-silent-rules  
> --disable-dependency-tracking   
> --with-libtool-sysroot=/home/colin/100051/fsl-community-bsp/build_sysv/tmp/sysroots/wg2xx-tx6s
>   --without-mbim  --without-qmi  --without-polkit --enable-nls  
> --disable-gtk-doc   --disable-gtk-doc-html   --disable-gtk-doc-pdf
>

All looks good here I think.

>
> (By the way - the configure summary is reporting "ModemManager 1.7.0"?)

Re: glib-mkenums error for ublox plugin

2017-02-14 Thread Colin Helliwell 

> On 14 February 2017 at 21:40 Aleksander Morgado  
> wrote:
> 
> On Tue, Feb 14, 2017 at 7:51 PM, Aleksander Morgado
>  wrote:
> 
> > Could you apply the attached patch and retry? It could just be the
> > order of the files generated, because the .c file depends on the .h
> > file and they were requested in the other way in BUILT_SOURCES.
> 
> Forget about this patch, fixes nothing and has nothing to do with your issue.
> 
> The issue is really related to the ublox subdir not existing before
> calling glib-mkenums. In my setup, the directory is created before
> glib-mkenums runs, though. What build tools are you using? i.e. which
> automake version?
> 

automake is version 1.15
Possibly to do with parallel build threads?
If it helps, initial output from the build is

automake (GNU automake) 1.15
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later 

This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey 
   and Alexandre Duret-Lutz .
AUTOV is 1
NOTE: Executing intltoolize --copy --force --automake
NOTE: Executing ACLOCAL="aclocal 
--system-acdir=/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/build/aclocal-copy/"
 autoreconf --verbose --install --force --exclude=autopoint -I 
/home/colin/100051-karo/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/m4/
autoreconf: Entering directory `.'
autoreconf: running: aclocal 
--system-acdir=/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/build/aclocal-copy/
 -I 
/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/m4/
 -I 
/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/m4/
 --force -I m4
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy --force
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: 
/home/colin/100051/fsl-community-bsp/build_sysv/tmp/sysroots/x86_64-linux/usr/bin/autoconf
 
--include=/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/m4/
 --force
autoreconf: running: 
/home/colin/100051/fsl-community-bsp/build_sysv/tmp/sysroots/x86_64-linux/usr/bin/autoheader
 
--include=/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/m4/
 --force
autoreconf: running: automake --add-missing --copy --force-missing
configure.ac:41: installing './compile'
configure.ac:50: installing './config.guess'
configure.ac:50: installing './config.sub'
configure.ac:29: installing './install-sh'
configure.ac:29: installing './missing'
Makefile.am: installing './INSTALL'
cli/Makefile.am: installing './depcomp'
autoreconf: running: gnu-configize
autoreconf: Leaving directory `.'
NOTE: Running 
/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/configure
  --build=x86_64-linux--host=arm-poky-linux-gnueabi 
  --target=arm-poky-linux-gnueabi --prefix=/usr 
  --exec_prefix=/usr  --bindir=/usr/bin   
--sbindir=/usr/sbin --libexecdir=/usr/lib/modemmanager  
--datadir=/usr/share--sysconfdir=/etc   
--sharedstatedir=/com   --localstatedir=/var
--libdir=/usr/lib   --includedir=/usr/include   
--oldincludedir=/usr/include--infodir=/usr/share/info   
--mandir=/usr/share/man --disable-silent-rules  
--disable-dependency-tracking   
--with-libtool-sysroot=/home/colin/100051/fsl-community-bsp/build_sysv/tmp/sysroots/wg2xx-tx6s
  --without-mbim  --without-qmi  --without-polkit --enable-nls  
--disable-gtk-doc   --disable-gtk-doc-html   --disable-gtk-doc-pdf


(By the way - the configure summary is reporting "ModemManager 1.7.0"?)
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: glib-mkenums error for ublox plugin

2017-02-14 Thread Aleksander Morgado 
On Tue, Feb 14, 2017 at 7:51 PM, Aleksander Morgado
 wrote:
> Could you apply the attached patch and retry? It could just be the
> order of the files generated, because the .c file depends on the .h
> file and they were requested in the other way in BUILT_SOURCES.

Forget about this patch, fixes nothing and has nothing to do with your issue.

The issue is really related to the ublox subdir not existing before
calling glib-mkenums. In my setup, the directory is created before
glib-mkenums runs, though. What build tools are you using? i.e. which
automake version?

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: glib-mkenums error for ublox plugin

2017-02-14 Thread Aleksander Morgado 
On Tue, Feb 14, 2017 at 5:32 PM,   wrote:
> On latest master I’m getting a build error for the glib-mkenums step for the
> ublox plugin:
>
>
>
> make[2]: Entering directory `/home/colin/100051
> /fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/build/plugins'
>
> glib-mkenums \
>
>   --fhead "#include \"mm-modem-helpers-ublox.h\"\n#ifndef
> __MM_UBLOX_ENUMS_TYPES_H__\n#define __MM_UBLOX_ENUMS_TYPES_H__\n" \
>
>--template
> /home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/build-aux/mm-enums-template.h
> \
>
>--ftail "#endif /* __MM_UBLOX_ENUMS_TYPES_H__ */\n" \
>
>
> /home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueabi/modemmanager/1.8-r0/git/plugins/ublox/mm-modem-helpers-ublox.h
>> ublox/mm-ublox-enums-types.h
>
> -bash: ublox/mm-ublox-enums-types.h: No such file or directory
>
>
>
> I guess this is probably because yocto/bitbake is doing an out-of-tree build
> - i.e. the problem seems to be that the ublox sub-directory doesn’t (yet)
> exist in the build directory.
>
> If I manually create it then I can re-do the build without further errors.
>
> It does look though like other glib-mkenums have succeeded – but perhaps
> because earlier build steps have created the relevant directory e.g.
> build/src.

Could you apply the attached patch and retry? It could just be the
order of the files generated, because the .c file depends on the .h
file and they were requested in the other way in BUILT_SOURCES.

-- 
Aleksander
https://aleksander.es
From feacad3f4c8b53e759bad10d7ae1743354496fb7 Mon Sep 17 00:00:00 2001
From: Aleksander Morgado 
Date: Tue, 14 Feb 2017 19:49:49 +0100
Subject: [PATCH] ublox: reorder enum files generated, header first

---
 plugins/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/Makefile.am b/plugins/Makefile.am
index 86026fd5..17f52153 100644
--- a/plugins/Makefile.am
+++ b/plugins/Makefile.am
@@ -913,8 +913,8 @@ ublox/mm-ublox-enums-types.c: Makefile.am $(top_srcdir)/build-aux/mm-enums-templ
 		$(UBLOX_ENUMS_INPUTS) > $@
 
 libhelpers_ublox_la_SOURCES = \
-	ublox/mm-modem-helpers-ublox.c \
 	ublox/mm-modem-helpers-ublox.h \
+	ublox/mm-modem-helpers-ublox.c \
 	$(NULL)
 
 nodist_libhelpers_ublox_la_SOURCES = $(UBLOX_ENUMS_GENERATED)
-- 
2.11.1

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

glib-mkenums error for ublox plugin

2017-02-14 Thread colin.helliwell 
On latest master I'm getting a build error for the glib-mkenums step for the
ublox plugin:

 

make[2]: Entering directory `/home/colin/100051
/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon-poky-linux-gnueab
i/modemmanager/1.8-r0/build/plugins' 

glib-mkenums \

  --fhead "#include \"mm-modem-helpers-ublox.h\"\n#ifndef
__MM_UBLOX_ENUMS_TYPES_H__\n#define __MM_UBLOX_ENUMS_TYPES_H__\n" \

   --template
/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon
-poky-linux-gnueabi/modemmanager/1.8-r0/git/build-aux/mm-enums-template.h \

   --ftail "#endif /* __MM_UBLOX_ENUMS_TYPES_H__ */\n" \

 
/home/colin/100051/fsl-community-bsp/build_sysv/tmp/work/cortexa9hf-vfp-neon
-poky-linux-gnueabi/modemmanager/1.8-r0/git/plugins/ublox/mm-modem-helpers-u
blox.h  > ublox/mm-ublox-enums-types.h

-bash: ublox/mm-ublox-enums-types.h: No such file or directory

 

I guess this is probably because yocto/bitbake is doing an out-of-tree build
- i.e. the problem seems to be that the ublox sub-directory doesn't (yet)
exist in the build directory. 

If I manually create it then I can re-do the build without further errors.

It does look though like other glib-mkenums have succeeded - but perhaps
because earlier build steps have created the relevant directory e.g.
build/src. 

 

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel