Re: [PATCH] mm-base-manager: ref MMDevice before releasing port

2018-02-23 Thread Aleksander Morgado
On 22/02/18 17:55, Dan Williams wrote: >> Releasing the port on the device looks benign but because it emits >> a signal, it could call device_context_port_released and unref the >> MMDevice in port_context_unref. This means the MMDevice might be >> disposed before we get to the g_object_ref and

Re: [PATCH] mm-base-manager: ref MMDevice before releasing port

2018-02-23 Thread Aleksander Morgado
On 21/02/18 22:49, Eric Caruso wrote: > Releasing the port on the device looks benign but because it emits > a signal, it could call device_context_port_released and unref the > MMDevice in port_context_unref. This means the MMDevice might be > disposed before we get to the g_object_ref and the

Re: [PATCH] mm-base-manager: ref MMDevice before releasing port

2018-02-22 Thread Dan Williams
On Wed, 2018-02-21 at 13:49 -0800, Eric Caruso wrote: > Releasing the port on the device looks benign but because it emits > a signal, it could call device_context_port_released and unref the > MMDevice in port_context_unref. This means the MMDevice might be > disposed before we get to the

[PATCH] mm-base-manager: ref MMDevice before releasing port

2018-02-21 Thread Eric Caruso
Releasing the port on the device looks benign but because it emits a signal, it could call device_context_port_released and unref the MMDevice in port_context_unref. This means the MMDevice might be disposed before we get to the g_object_ref and the subsequent call to g_hash_table_remove will try