Re: [PATCH] port-probe: make sure stored task pointer is set to NULL before completing

2016-04-13 Thread Aleksander Morgado
On Wed, Apr 13, 2016 at 10:26 AM, Carlo Lobrano wrote: > No worries :) > I double checked and I can confirm the issue is gone. Thanks. I'll try to prepare a new rc today or tomorrow. -- Aleksander https://aleksander.es ___

Re: [PATCH] port-probe: make sure stored task pointer is set to NULL before completing

2016-04-13 Thread Aleksander Morgado
On Mon, Apr 11, 2016 at 4:56 PM, Carlo Lobrano wrote: > > it looks like the last commit introduced a some kind of problem. HE910 > initialization ends with error > >> Modem couldn't be initialized: couldn't load current capabilities: Failed >> to determine modem capabilities

Re: [PATCH] port-probe: make sure stored task pointer is set to NULL before completing

2016-04-11 Thread Carlo Lobrano
Hi Daniele, it looks like the last commit introduced a some kind of problem. HE910 initialization ends with error > Modem couldn't be initialized: couldn't load current capabilities: Failed to determine modem capabilities Here's the pastebin link of the logs of this test, >

Re: [PATCH] port-probe: make sure stored task pointer is set to NULL before completing

2016-04-11 Thread Daniele Palmas
Hi Carlo, 2016-04-11 10:55 GMT+02:00 Daniele Palmas : > Hi Aleksander, > > 2016-04-08 17:14 GMT+02:00 Aleksander Morgado : >> On Fri, Apr 8, 2016 at 4:55 PM, Daniele Palmas wrote: >>> 2016-04-08 16:42 GMT+02:00 Aleksander Morgado

Re: [PATCH] port-probe: make sure stored task pointer is set to NULL before completing

2016-04-11 Thread Daniele Palmas
Hi Aleksander, 2016-04-08 17:14 GMT+02:00 Aleksander Morgado : > On Fri, Apr 8, 2016 at 4:55 PM, Daniele Palmas wrote: >> 2016-04-08 16:42 GMT+02:00 Aleksander Morgado : >>> When we were completing tasks in idle, the logic was

Re: [PATCH] port-probe: make sure stored task pointer is set to NULL before completing

2016-04-08 Thread Aleksander Morgado
On Fri, Apr 8, 2016 at 4:55 PM, Daniele Palmas wrote: > 2016-04-08 16:42 GMT+02:00 Aleksander Morgado : >> When we were completing tasks in idle, the logic was like this: >> >> * Schedule task completion in idle >> * self->priv->task = NULL >> *

Re: [PATCH] port-probe: make sure stored task pointer is set to NULL before completing

2016-04-08 Thread Daniele Palmas
Hi Aleksander, 2016-04-08 16:42 GMT+02:00 Aleksander Morgado : > When we were completing tasks in idle, the logic was like this: > > * Schedule task completion in idle > * self->priv->task = NULL > * (idle) Task completion callback called > > This meant that the

[PATCH] port-probe: make sure stored task pointer is set to NULL before completing

2016-04-08 Thread Aleksander Morgado
When we were completing tasks in idle, the logic was like this: * Schedule task completion in idle * self->priv->task = NULL * (idle) Task completion callback called This meant that the self->priv->task was always set to NULL before the completion callback was called, which is what we wanted