Re: [PATCH] sim-qmi: avoid unnecessary MM_SIM_QMI() call on MMSimQmi object

2018-10-16 Thread Ben Chan 
On Tue, Oct 16, 2018 at 9:42 AM Dan Williams  wrote:

> On Wed, 2018-10-10 at 23:11 -0700, Ben Chan wrote:
> > ---
> >  src/mm-sim-qmi.c | 12 ++--
> >  1 file changed, 6 insertions(+), 6 deletions(-)
>
> LGTM
>
>
Pushed to git master. Thanks!
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: [PATCH] sim-qmi: avoid unnecessary MM_SIM_QMI() call on MMSimQmi object

2018-10-16 Thread Dan Williams 
On Wed, 2018-10-10 at 23:11 -0700, Ben Chan wrote:
> ---
>  src/mm-sim-qmi.c | 12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)

LGTM

> diff --git a/src/mm-sim-qmi.c b/src/mm-sim-qmi.c
> index 725e073e..e8c0afef 100644
> --- a/src/mm-sim-qmi.c
> +++ b/src/mm-sim-qmi.c
> @@ -449,7 +449,7 @@ uim_verify_pin (MMSimQmi *self,
>  QmiClient *client = NULL;
>  
>  if (!ensure_qmi_client (task,
> -MM_SIM_QMI (self),
> +self,
>  QMI_SERVICE_UIM, ))
>  return;
>  
> @@ -504,7 +504,7 @@ dms_uim_verify_pin (MMSimQmi *self,
>  QmiClient *client = NULL;
>  
>  if (!ensure_qmi_client (NULL,
> -MM_SIM_QMI (self),
> +self,
>  QMI_SERVICE_DMS, )) {
>  /* Very unlikely that this will ever happen, but anyway, try
> with
>   * UIM service instead */
> @@ -605,7 +605,7 @@ uim_unblock_pin (MMSimQmi *self,
>  UnblockPinContext *ctx;
>  
>  if (!ensure_qmi_client (task,
> -MM_SIM_QMI (self),
> +self,
>  QMI_SERVICE_UIM, ))
>  return;
>  
> @@ -664,7 +664,7 @@ dms_uim_unblock_pin (MMSimQmi *self,
>  UnblockPinContext *ctx;
>  
>  if (!ensure_qmi_client (NULL,
> -MM_SIM_QMI (self),
> +self,
>  QMI_SERVICE_DMS, )) {
>  /* Very unlikely that this will ever happen, but anyway, try
> with
>   * UIM service instead */
> @@ -772,7 +772,7 @@ uim_change_pin (MMSimQmi *self,
>  ChangePinContext *ctx;
>  
>  if (!ensure_qmi_client (task,
> -MM_SIM_QMI (self),
> +self,
>  QMI_SERVICE_UIM, ))
>  return;
>  
> @@ -831,7 +831,7 @@ dms_uim_change_pin (MMSimQmi *self,
>  ChangePinContext *ctx;
>  
>  if (!ensure_qmi_client (NULL,
> -MM_SIM_QMI (self),
> +self,
>  QMI_SERVICE_DMS, )) {
>  /* Very unlikely that this will ever happen, but anyway, try
> with
>   * UIM service instead */
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

[PATCH] sim-qmi: avoid unnecessary MM_SIM_QMI() call on MMSimQmi object

2018-10-11 Thread Ben Chan 
---
 src/mm-sim-qmi.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/mm-sim-qmi.c b/src/mm-sim-qmi.c
index 725e073e..e8c0afef 100644
--- a/src/mm-sim-qmi.c
+++ b/src/mm-sim-qmi.c
@@ -449,7 +449,7 @@ uim_verify_pin (MMSimQmi *self,
 QmiClient *client = NULL;
 
 if (!ensure_qmi_client (task,
-MM_SIM_QMI (self),
+self,
 QMI_SERVICE_UIM, ))
 return;
 
@@ -504,7 +504,7 @@ dms_uim_verify_pin (MMSimQmi *self,
 QmiClient *client = NULL;
 
 if (!ensure_qmi_client (NULL,
-MM_SIM_QMI (self),
+self,
 QMI_SERVICE_DMS, )) {
 /* Very unlikely that this will ever happen, but anyway, try with
  * UIM service instead */
@@ -605,7 +605,7 @@ uim_unblock_pin (MMSimQmi *self,
 UnblockPinContext *ctx;
 
 if (!ensure_qmi_client (task,
-MM_SIM_QMI (self),
+self,
 QMI_SERVICE_UIM, ))
 return;
 
@@ -664,7 +664,7 @@ dms_uim_unblock_pin (MMSimQmi *self,
 UnblockPinContext *ctx;
 
 if (!ensure_qmi_client (NULL,
-MM_SIM_QMI (self),
+self,
 QMI_SERVICE_DMS, )) {
 /* Very unlikely that this will ever happen, but anyway, try with
  * UIM service instead */
@@ -772,7 +772,7 @@ uim_change_pin (MMSimQmi *self,
 ChangePinContext *ctx;
 
 if (!ensure_qmi_client (task,
-MM_SIM_QMI (self),
+self,
 QMI_SERVICE_UIM, ))
 return;
 
@@ -831,7 +831,7 @@ dms_uim_change_pin (MMSimQmi *self,
 ChangePinContext *ctx;
 
 if (!ensure_qmi_client (NULL,
-MM_SIM_QMI (self),
+self,
 QMI_SERVICE_DMS, )) {
 /* Very unlikely that this will ever happen, but anyway, try with
  * UIM service instead */
-- 
2.19.0.605.g01d371f741-goog

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel