Re: [PATCH v2 2/2] kernel-device: use device sysfs if physdev sysfs isn't available

2017-03-02 Thread Aleksander Morgado
On Thu, Mar 2, 2017 at 7:31 PM, Ben Chan wrote: > I saw a few self->priv->device check in mm-kernel-device-udev.c, so I was > wondering if there are cases where self->priv->device may be NULL. I'd keep > the check here for now as I haven't ruled out that possibility. I

Re: [PATCH v2 2/2] kernel-device: use device sysfs if physdev sysfs isn't available

2017-03-02 Thread Ben Chan
On Thu, Mar 2, 2017 at 12:36 AM, Aleksander Morgado < aleksan...@aleksander.es> wrote: > On Wed, Mar 1, 2017 at 3:59 AM, Ben Chan wrote: > > find_device_by_physdev_uid() expects a non-NULL UID of the physical > > device. However, mm_kernel_device_get_physdev_uid() could

Re: [PATCH v2 2/2] kernel-device: use device sysfs if physdev sysfs isn't available

2017-03-02 Thread Aleksander Morgado
On Wed, Mar 1, 2017 at 3:59 AM, Ben Chan wrote: > find_device_by_physdev_uid() expects a non-NULL UID of the physical > device. However, mm_kernel_device_get_physdev_uid() could potentially > return NULL on MMKernelDeviceUdev if find_physical_gudevdevice() in >

Re: [PATCH v2 2/2] kernel-device: use device sysfs if physdev sysfs isn't available

2017-03-01 Thread Ben Chan
Aleksander, does v2 match what you expect? On Tue, Feb 28, 2017 at 6:59 PM, Ben Chan wrote: > find_device_by_physdev_uid() expects a non-NULL UID of the physical > device. However, mm_kernel_device_get_physdev_uid() could potentially > return NULL on MMKernelDeviceUdev if