Re: [review] New 'fibocom' plugin

2018-07-19 Thread Aleksander Morgado
Hey, >> You may know this better than me; are all DIAG ports from all qualcomm >> modems ever of the same class/subclass/protocol? i.e. Cls=ff(vend.) >> Sub=ff Prot=ff >> In other words, should we bother probing QCDM for ports that are not >> ff/ff/ff? > > Hi Aleksander, > > at least some Huawei

Re: [review] New 'fibocom' plugin

2018-07-19 Thread Aleksander Morgado
>> >> > On Chrome OS, we simply use ID_MM_PORT_IGNORE to ignore all AT >> >> > ports >> >> > on the L850-GL module (e.g. >> >> > https://chromium.googlesource.com/chromiumos/overlays/chromiumos-ov >> >> > erlay/+/master/net-misc/modemmanager-next/files/77-mm-fibocom-port- >> >> > types.rules). >>

Re: [review] New 'fibocom' plugin

2018-07-19 Thread Reinhard Speyerer
On Thu, Jul 19, 2018 at 09:44:57PM +0200, Aleksander Morgado wrote: > On Thu, Jul 19, 2018 at 9:23 PM, Dan Williams wrote: > > On Thu, 2018-07-19 at 21:10 +0200, Aleksander Morgado wrote: > >> > On Chrome OS, we simply use ID_MM_PORT_IGNORE to ignore all AT > >> > ports > >> > on the L850-GL

Re: [review] New 'fibocom' plugin

2018-07-19 Thread Ben Chan
On Thu, Jul 19, 2018 at 12:45 PM Aleksander Morgado wrote: > > On Thu, Jul 19, 2018 at 9:23 PM, Dan Williams wrote: > > On Thu, 2018-07-19 at 21:10 +0200, Aleksander Morgado wrote: > >> > On Chrome OS, we simply use ID_MM_PORT_IGNORE to ignore all AT > >> > ports > >> > on the L850-GL module

Re: [review] New 'fibocom' plugin

2018-07-19 Thread Aleksander Morgado
On Thu, Jul 19, 2018 at 9:23 PM, Dan Williams wrote: > On Thu, 2018-07-19 at 21:10 +0200, Aleksander Morgado wrote: >> > On Chrome OS, we simply use ID_MM_PORT_IGNORE to ignore all AT >> > ports >> > on the L850-GL module (e.g. >> >

Re: [review] New 'fibocom' plugin

2018-07-19 Thread Dan Williams
On Thu, 2018-07-19 at 21:10 +0200, Aleksander Morgado wrote: > > On Chrome OS, we simply use ID_MM_PORT_IGNORE to ignore all AT > > ports > > on the L850-GL module (e.g. > > https://chromium.googlesource.com/chromiumos/overlays/chromiumos-ov > >

Re: [review] New 'fibocom' plugin

2018-07-19 Thread Aleksander Morgado
> On Chrome OS, we simply use ID_MM_PORT_IGNORE to ignore all AT ports > on the L850-GL module (e.g. > https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/net-misc/modemmanager-next/files/77-mm-fibocom-port-types.rules). > > The modem is functional with just MBIM and

Re: [review] New 'fibocom' plugin

2018-07-19 Thread Ben Chan
Hi Aleksander, On Chrome OS, we simply use ID_MM_PORT_IGNORE to ignore all AT ports on the L850-GL module (e.g. https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/net-misc/modemmanager-next/files/77-mm-fibocom-port-types.rules). The modem is functional with just

[review] New 'fibocom' plugin

2018-07-19 Thread Aleksander Morgado
Hey all, See this MR introducing a new Fibocom plugin, which right now just maps support for AT/MBIM based devices. https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/12 Tested with the L850-GL module (MBIM+2 AT ports+Intel trace port), and explicitly blacklisted the