[PATCH 2/8] broadband-modem: query supported flow control modes before setting

2017-03-25 Thread Aleksander Morgado
Instead of assuming XON/XOFF is supported, we query the supported flow control modes, and then we set the best one based on that, preferring hardware flow control over software flow control. --- src/mm-broadband-modem.c | 79 1 file changed, 60

[PATCH 3/8] wavecom: ignore custom flow control handling

2017-03-25 Thread Aleksander Morgado
The generic modem object already supports querying for the supported methods and setting the best one found. --- plugins/wavecom/mm-broadband-modem-wavecom.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/plugins/wavecom/mm-broadband-modem-wavecom.c

[PATCH 7/8] port-serial: remove all default flow control settings

2017-03-25 Thread Aleksander Morgado
We won't set XON/XOFF by default and we won't allow setting RTS/CTS via a property. The serial port by default starts with no flow control configured. --- src/mm-port-serial.c | 34 ++ src/mm-port-serial.h | 1 - 2 files changed, 6 insertions(+), 29 deletions(-)

[PATCH 4/8] telit: ignore custom flow control handling

2017-03-25 Thread Aleksander Morgado
The generic modem object already supports querying for the supported methods and setting the best one found. --- plugins/telit/mm-broadband-modem-telit.c | 48 1 file changed, 48 deletions(-) diff --git a/plugins/telit/mm-broadband-modem-telit.c

[PATCH 8/8] broadband-bearer: once connected, set flow control settings

2017-03-25 Thread Aleksander Morgado
During modem initialization we detected the flow control settings supported by the modem, and selected the best one to use from them, notifying it to the device via AT+IFC. The device was therefore instructed to use that flow control setting for data transmission in the TTY (i.e. not during AT

[PATCH 6/8] port-serial: new method to explicitly set flow control settings

2017-03-25 Thread Aleksander Morgado
--- src/mm-port-serial.c | 50 ++ src/mm-port-serial.h | 5 + 2 files changed, 55 insertions(+) diff --git a/src/mm-port-serial.c b/src/mm-port-serial.c index f2b97a02..e55f9062 100644 --- a/src/mm-port-serial.c +++ b/src/mm-port-serial.c @@

[PATCH 2/2] broadband-modem: normalize also operator code

2017-03-25 Thread Aleksander Morgado
The operator code (MCCMNC) may also be given encoded in the current charset (e.g. UCS2). Based on a patch from Colin Helliwell --- plugins/altair/mm-broadband-modem-altair-lte.c | 2 +- src/mm-broadband-modem.c | 6 --

[PATCH 1/2] modem-helpers: if operator not in UCS2, see if already valid UTF-8

2017-03-25 Thread Aleksander Morgado
The method doing the operator name normalization takes as input the current configured modem charset. If this is UCS2, we will now just assume this is a hint: the string may or may not come in hex/UCS2. This logic makes the custom operator name loading in Huawei unneeded, if the modem is

Try to normalize both operator name and code

2017-03-25 Thread Aleksander Morgado
Hey Colin and Dan, What do you think of these two patches? Cheers! [PATCH 1/2] modem-helpers: if operator not in UCS2, see if already [PATCH 2/2] broadband-modem: normalize also operator code ___ ModemManager-devel mailing list