Re: ModemManager: symbol lookup error: ModemManager: undefined symbol: mm_kernel_event_properties_get_type

2017-04-07 Thread Aleksander Morgado
On Fri, Apr 7, 2017 at 12:14 AM, Jan Graczyk wrote: > I found no qmi wwan device present in /dev directory even though the > qmi_wwan.ko module is inserted. I am running Linux version 4.1.15 and I have > mini PCie Quectel UC20 modem module installed on my development board. Is

Re: [PATCH] call-list: port mm_call_list_delete_call to use GTask

2017-04-07 Thread Aleksander Morgado
On 06/04/17 21:54, Ben Chan wrote: > --- > src/mm-call-list.c | 55 > +++--- > 1 file changed, 19 insertions(+), 36 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-call-list.c b/src/mm-call-list.c > index fae66035..1cc1f543

Re: [PATCH] sms-list: port mm_sms_list_delete_sms to use GTask

2017-04-07 Thread Aleksander Morgado
On 06/04/17 21:42, Ben Chan wrote: > --- > src/mm-sms-list.c | 70 > +-- > 1 file changed, 27 insertions(+), 43 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-sms-list.c b/src/mm-sms-list.c > index 7819b3ad..22c2cd9a

Re: [PATCH] port-mbim: port mm_port_mbim_{open,close} to use GTask

2017-04-07 Thread Aleksander Morgado
Hey Ben, See some comments below. On 06/04/17 22:46, Ben Chan wrote: > --- > src/mm-port-mbim.c | 130 > + > 1 file changed, 50 insertions(+), 80 deletions(-) > > diff --git a/src/mm-port-mbim.c b/src/mm-port-mbim.c > index

Re: [PATCH 2/2] port-qmi: port mm_port_qmi_allocate_client to use GTask

2017-04-07 Thread Aleksander Morgado
Hey Ben, See comments below. On 06/04/17 22:41, Ben Chan wrote: > --- > src/mm-port-qmi.c | 51 ++- > 1 file changed, 26 insertions(+), 25 deletions(-) > > diff --git a/src/mm-port-qmi.c b/src/mm-port-qmi.c > index c6ae0615..2baeea7c 100644 > ---

Re: [PATCH 1/2] auth: port authorize to use GTask

2017-04-07 Thread Aleksander Morgado
On 06/04/17 21:38, Ben Chan wrote: > --- > src/mm-auth-provider.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-auth-provider.c b/src/mm-auth-provider.c > index 4ef56234..4d8766c0 100644 > --- a/src/mm-auth-provider.c

[PATCH] base-call: remove unnecessary string duplications

2017-04-07 Thread Ben Chan
--- src/mm-base-call.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/mm-base-call.c b/src/mm-base-call.c index 6ce85d0d..606d24f2 100644 --- a/src/mm-base-call.c +++ b/src/mm-base-call.c @@ -754,7 +754,6 @@ call_accept (MMBaseCall *self, gpointer

[PATCH v2] port-mbim: port mm_port_mbim_{open,close} to use GTask

2017-04-07 Thread Ben Chan
--- Good catch! src/mm-port-mbim.c | 132 + 1 file changed, 51 insertions(+), 81 deletions(-) diff --git a/src/mm-port-mbim.c b/src/mm-port-mbim.c index 2b649963..a0534fea 100644 --- a/src/mm-port-mbim.c +++ b/src/mm-port-mbim.c @@ -31,90

Re: [PATCH 2/2] port-qmi: port mm_port_qmi_allocate_client to use GTask

2017-04-07 Thread Ben Chan
On Fri, Apr 7, 2017 at 2:03 AM, Aleksander Morgado wrote: > Hey Ben, > > See comments below. > > On 06/04/17 22:41, Ben Chan wrote: >> --- >> src/mm-port-qmi.c | 51 ++- >> 1 file changed, 26 insertions(+), 25 deletions(-)