Re: [PATCH 4/4] cinterion: use ^SIND unsolicited messages for access tech reporting

On Mon, May 22, 2017 at 6:02 PM, Dan Williams wrote: > On Sun, 2017-05-21 at 21:49 +0200, Aleksander Morgado wrote: >> If the modem supports ^SIND psinfo reporting, we enable the URC and >> flag the access technology polling unsupported, so that we only update >> access

Re: [PATCH] udev: remove default ID_MM_PLATFORM_DRIVER_PROBE whitelist

On Mon, May 22, 2017 at 6:06 PM, Dan Williams wrote: >> The whitelist made all platform TTYs managed by the 'atmel_usart' >> kernel driver probed by ModemManager, which isn't something we want, >> as most of these aren't broadband modems. >> >> We leave the logic supporting the

[PATCH 2/4 v3] broadband-modem: query +CMER format before enabling/disabling

Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable Mobile Equipment Event Reporting. We now query the device for the supported formats and use that info to build commands that will work. --- This v3 adds some additional log messages to specify which CMER settings are selected.

Re: [PATCH 1/4] iface-modem: consolidate signal quality and access tech polling

LGTM, for syntax & control flow. Like the idea but I'm biased on this one ;) On Sun, May 21, 2017 at 1:49 PM, Aleksander Morgado < aleksan...@aleksander.es> wrote: > Plugins have two ways to update signal quality and access technology > values: via unsolicited messages or via polling

Re: [PATCH 2/4] iface-modem: if bands, capabilities or modes change, refresh signal

On Mon, May 22, 2017 at 5:46 PM, Dan Williams wrote: >> We also remove the explicit refresh request from the Cinterion >> plugin, >> as this is a generic action applicable to all modems that require >> polling for signal quality and/or access technology. > > Should the poll

Re: [PATCH] v1: Logging cleanup and systemd journal support

Hey, On Mon, May 22, 2017 at 7:49 AM, Torsten Hilbrich wrote: > This series of patches is based on the "Logging and --help > updates" series posted by Aleksander Morgado > . > > It start with cleaning up some parts of the logging code. The

Re: [PATCH 1/2] log: new --log-func-loc option to enable function location in logs

Hey, On Thu, May 18, 2017 at 12:43 PM, Aleksander Morgado wrote: > The --debug output is a bit annoying right now because it includes the > function location information by default. This information is most of > the times not very useful, so just make it optional under

Re: [PATCH 1/2] log: new --log-func-loc option to enable function location in logs

> On 22 May 2017 at 09:14 Aleksander Morgado wrote: > > Hey, > > On Thu, May 18, 2017 at 12:43 PM, Aleksander Morgado > wrote: > > > The --debug output is a bit annoying right now because it includes the > > function location information by

[PATCH 1/4 v2] helpers: new 'AT+CMER=?' parser

--- Hey, (resent to include in CC the mailing list) This v2 patch includes a correct "underscore_name" for the new enums defined in the helpers header, needed if we want to use the _build_string_from_mask() methods. Cheers, --- src/mm-modem-helpers.c | 136

[PATCH 2/4 v2] broadband-modem: query +CMER format before enabling/disabling

Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable Mobile Equipment Event Reporting. We now query the device for the supported formats and use that info to build commands that will work. --- Hey Colin, This patch fixes a check for +CMER mode 1, and includes additional logging

[PATCH1 1/4 v3] helpers: new 'AT+CMER=?' parser

--- Hey Colin, Please try now with this v3 patch. I modified the helper method to allow the comma-separated number sequence you get in your EHS5 for the modes, i.e.: "(1,2)". The regex wasn't catching that logic, so instead of complicating it too much, I switched to splitting the response

Re: [PATCH 2/4 v2] broadband-modem: query +CMER format before enabling/disabling

> On 22 May 2017 at 12:47 Aleksander Morgado wrote: > > Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable > Mobile Equipment Event Reporting. We now query the device for the > > supported formats and use that info to build commands that will work. >

Re: [PATCH 2/4] broadband-modem: query +CMER format before enabling/disabling

> On 21 May 2017 at 13:54 Aleksander Morgado wrote: > > Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable > Mobile Equipment Event Reporting. We now query the device for the > > supported formats and use that info to build commands that will work. >

[PATCH] broadband-modem: don't create sim hot swap ports context multiple times

--- Hey Carlo, It's never too late :) I couldn't reproduce the issue with the SIM hot swap changes you were trying, because none of my Telit modems here were able to support it properly, so I ended up re-reviewing the logs you sent and I believe I found the issue. When the SIM is already

Re: [PATCH 2/4] broadband-modem: query +CMER format before enabling/disabling

On Mon, May 22, 2017 at 12:36 PM, Colin Helliwell wrote: >> Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable >> Mobile Equipment Event Reporting. We now query the device for the >> >> supported formats and use that info to build commands that

Re: [PATCH 2/4] broadband-modem: query +CMER format before enabling/disabling

> On 22 May 2017 at 12:22 Aleksander Morgado wrote: > > On Mon, May 22, 2017 at 12:36 PM, Colin Helliwell > > wrote: > > > > Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable > > > Mobile Equipment Event Reporting.

Re: [PATCH1 1/4 v3] helpers: new 'AT+CMER=?' parser

> On 22 May 2017 at 13:43 Aleksander Morgado wrote: > > --- > > Hey Colin, > > Please try now with this v3 patch. I modified the helper method to allow the > comma-separated number sequence you get in your EHS5 for the modes, i.e.: > "(1,2)". The regex wasn't

Re: [PATCH 1/2] log: new --log-func-loc option to enable function location in logs

> > ...do quite often find the function location useful. But I don't mind > patching it back in for myself if the consensus is to remove it for > mainstream. When I was starting out I also found it very helpful, but I think if there was a patch or something for others off to the side then it's

Re: [PATCH1 1/4 v3] helpers: new 'AT+CMER=?' parser

On Mon, May 22, 2017 at 3:50 PM, Colin Helliwell wrote: > But do bear in mind that I don't have any conviction about what 'CMER' the > EHS5 actually supports, because it's AT doc doesn't mention the command at > all - by rights it shouldn't even respond at all to

Re: [PATCH 2/4] iface-modem: if bands, capabilities or modes change, refresh signal

On Sun, 2017-05-21 at 21:49 +0200, Aleksander Morgado wrote: > We also remove the explicit refresh request from the Cinterion > plugin, > as this is a generic action applicable to all modems that require > polling for signal quality and/or access technology. Should the poll interval get reset to

Re: [PATCH 4/4] cinterion: use ^SIND unsolicited messages for access tech reporting

On Sun, 2017-05-21 at 21:49 +0200, Aleksander Morgado wrote: > If the modem supports ^SIND psinfo reporting, we enable the URC and > flag the access technology polling unsupported, so that we only update > access technology via the +CIEV URCs. > > E.g.: > > (ttyACM1): -->

Re: [PATCH] udev: remove default ID_MM_PLATFORM_DRIVER_PROBE whitelist

On Thu, 2017-05-18 at 10:15 +0200, Aleksander Morgado wrote: > The whitelist made all platform TTYs managed by the 'atmel_usart' > kernel driver probed by ModemManager, which isn't something we want, > as most of these aren't broadband modems. > > We leave the logic supporting the