Re: [PATCH 2/5] cinterion: flag PLS8 GPS data port

On 17/05/17 15:24, Aleksander Morgado wrote: > --- > plugins/cinterion/77-mm-cinterion-port-types.rules | 4 > 1 file changed, 4 insertions(+) > This has been merged to git master. > diff --git a/plugins/cinterion/77-mm-cinterion-port-types.rules >

Re: [PATCH 3/5] cinterion: setup GPS port only if GPS support detected

On 17/05/17 15:24, Aleksander Morgado wrote: > i.e. if AT^SGPSS not supported, we don't even add traces handler to > the GPS data port. > --- This has been merged to git master. > plugins/cinterion/mm-broadband-modem-cinterion.c | 14 --- > .../cinterion/mm-broadband-modem-qmi-cinterion.c

Re: [PATCH 4/5] cinterion: support AT^SGPSC capable modems

On 17/05/17 15:24, Aleksander Morgado wrote: > The AT^SGPSS command provides an easy way to just start/stop GPS, but > unfortunately it isn't supported by all Cinterion modems. > > The AT^SGPSC command instead is more widely available but it requires > several steps to start and stop the

Re: [PATCH 5/5 v2] cinterion: retry GPS Engine activation up to 3 times

On 20/05/17 09:57, Aleksander Morgado wrote: > The default setup with 100ms between GPS commands doesn't seem to be > always enough for the Engine activation step: > >[1495016625.392972] (ttyACM1): --> 'AT^SGPSC="NMEA/Output","on"' >[1495016625.503885] (ttyACM1): <-- '^SGPSC: >

Re: [PATCH 4/5] cinterion: support AT^SGPSC capable modems

On Tue, May 30, 2017 at 8:27 PM, Dan Williams wrote: >> @@ -429,13 +536,15 @@ mm_common_cinterion_disable_location_gathering >> (MMIfaceModemLocation *self, >> typedef enum { >> ENABLE_LOCATION_GATHERING_GPS_STEP_FIRST, >> ENABLE_LOCATION_GATHERING_GPS_STEP_SGPSS, >>

Re: [PATCH 2/2] ublox: use send-delay=0 by default

On Tue, May 23, 2017 at 6:39 PM, Aleksander Morgado wrote: > Looks like the u-blox SARA-U260 requires this, see: > https://lists.freedesktop.org/archives/modemmanager-devel/2017-May/004670.html > --- Pushed to git master. > plugins/ublox/mm-broadband-modem-ublox.c |

Re: [PATCH 4/4] cinterion: use ^SIND unsolicited messages for access tech reporting

On Mon, May 22, 2017 at 7:15 PM, Aleksander Morgado wrote: >>> +static void >>> +set_unsolicited_events_handlers (MMBroadbandModemCinterion *self, >>> + gboolean enable) >>> +{ >>> +MMPortSerialAt *ports[2]; >>> +

Re: AT send delay set to 0 in port probings

Hi Brent, On Tue, May 30, 2017 at 4:11 PM, Brent Sink wrote: > How did you apply the patches I sent? Did you "save" the emails and > >> apply them with "git am"? or did you manually modify the files with >> the changes seen in the patches? I ask because the \x90\xf0 looks

Re: [PATCH 1/2] altair,hso,samsung: setup send-delay=0 for probing

On Tue, May 23, 2017 at 6:39 PM, Aleksander Morgado wrote: > The Altair, Option HSO and Samsung plugins all use the send-delay=0 > setting once the modem object has been created. For consistency, use > the same setting during port probing. Pushed to git master. > --- >

Re: [PATCH 4/5] cinterion: support AT^SGPSC capable modems

On Wed, 2017-05-17 at 15:24 +0200, Aleksander Morgado wrote: > The AT^SGPSS command provides an easy way to just start/stop GPS, but > unfortunately it isn't supported by all Cinterion modems. > > The AT^SGPSC command instead is more widely available but it requires > several steps to start and

[PATCH v2 4/4] cinterion: use ^SIND unsolicited messages for access tech reporting

If the modem supports ^SIND psinfo reporting, we enable the URC and flag the access technology polling unsupported, so that we only update access technology via the +CIEV URCs. E.g.: (ttyACM1): --> 'AT^SIND="psinfo",1' (ttyACM1): <-- '^SIND: psinfo,1,10OK' Reporting initial access

Allow plugins to specify that signal quality/access tech polling isn't needed (v2)

Hey Dan and everyone, This patch series contains the following updates w.r.t. the v1 patches: * When a explicit signal refresh is requested, setup the initial fast-polling configuration (this was suggested in the review of PATCH 2/4, but the fix has been applied in PATCH v2 1/4). * In the

[PATCH v2 1/4] iface-modem: consolidate signal quality and access tech polling

Plugins have two ways to update signal quality and access technology values: via unsolicited messages or via polling periodically. Instead of keeping separate contexts for polling signal quality and access technology values, we setup a common timeout to trigger both. This allows us to simplify in

[PATCH v2 3/4] port-serial-at: always prepend unsolicited message handlers

The generic modem has several URC handlers for generic messages, like +CIEV. But, there may be cases where the plugins themselves want to provide their own URC handlers to be run before the generic one. This patch enables this setup by always prepending the new URC handlers, so that the last ones

[PATCH v2 2/4] iface-modem: if bands, capabilities or modes change, refresh signal

We also remove the explicit refresh request from the Cinterion plugin, as this is a generic action applicable to all modems that require polling for signal quality and/or access technology. --- plugins/cinterion/mm-broadband-modem-cinterion.c | 10 ++ src/mm-iface-modem.c

Re: Enabling GPS support for the Cinterion PLS8 devices

On Wed, 2017-05-17 at 15:23 +0200, Aleksander Morgado wrote: > Hey Dan, Matthew & everyone, > > The following patches implement support for GPS capabilities in the > Cinterion PLS8-X, PLS8-E and similar devices, plus some additional > improvements in how GPS support is handled. > > The logic is

Re: [PATCH 1/5] cinterion,location: refactor enable/disable and capabilities checks

On 17/05/17 15:24, Aleksander Morgado wrote: > When checking for location capabilities, we will make sure AT^SGPSS is > supported and if it isn't we won't report GPS capabilities. > > The location enable and disable paths are refactored to make it easier > to add possible new GPS commands to use