Re: [PATCH] broadband-modem: initialize 'tac' in registration_status_check_ready()

2018-08-10 Thread Aleksander Morgado
On 10/08/18 02:00, Ben Chan wrote: > mm-broadband-modem.c:4395:13: error: variable 'tac' is used uninitialized > whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > if (act == MM_MODEM_ACCESS_TECHNOLOGY_LTE) { > ^ >

[review v2] Voice implementation fixes (with audio channel setup handlers)

2018-08-10 Thread Aleksander Morgado
Hey Dan, Bob & all, I've updated the "aleksander/voice-fixes" branch to include the "AT^CVOICE based support for Huawei modems that Dan worked on a while ago in his "dcbw/huawei-voice" branch. https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/2 The Huawei USB dongles