RE: [Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

2020-07-07 Thread Amol Lad 
I commented those two lines (and also PKG_FIXUP:=autoreconf) and build is 
successful.

I'm not sure why those lines are there. Maybe, Nick will have some idea.

Amol

-Original Message-
From: Aleksander Morgado  
Sent: Tuesday, 7 July 2020 2:04 PM
To: Amol Lad 
Cc: Nick ; ModemManager (development) 

Subject: Re: [Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

Hey Amol,

> After commenting PKG_FIXUP:=autoreconf, I'm getting below error:
>
> CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash 
> /home/alad/openwrt/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi/Mode
> mManager-1.14.0/missing aclocal-1.16 -I m4
> /home/alad/openwrt/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi/Mode
> mManager-1.14.0/missing: line 81: aclocal-1.16: command not found
>
> OpenWrt "master" has automake version 1.15.1.
>
> Any suggestion?
>

That may be due to these lines that modify configure.ac, which force an 
autoreconf either way even if AUTORECONF=1 not given:

$(SED) 's|^\(GLIB_MKENUMS\)=.*|\1=$(STAGING_DIR_HOSTPKG)/bin/glib-mkenums|'
\
$(PKG_BUILD_DIR)/configure.ac
$(SED) 
's|^\(GDBUS_CODEGEN\)=.*|\1=$(STAGING_DIR_HOSTPKG)/bin/gdbus-codegen|'
\
$(PKG_BUILD_DIR)/configure.ac

Why are those lines in the Makefile? This looks like a hack to workaround some 
build system error. Are we not using the correct glib-mkenums or gdbus-codegen 
from staging if those lines are removed?

Both libmbim and libqmi also use glib-mkenums, and they don't have those lines.

--
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: [Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

2020-07-07 Thread Aleksander Morgado 
Hey Amol,

> After commenting PKG_FIXUP:=autoreconf, I'm getting below error:
>
> CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash 
> /home/alad/openwrt/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi/ModemManager-1.14.0/missing
>  aclocal-1.16 -I m4
> /home/alad/openwrt/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi/ModemManager-1.14.0/missing:
>  line 81: aclocal-1.16: command not found
>
> OpenWrt "master" has automake version 1.15.1.
>
> Any suggestion?
>

That may be due to these lines that modify configure.ac, which force
an autoreconf either way even if AUTORECONF=1 not given:

$(SED) 's|^\(GLIB_MKENUMS\)=.*|\1=$(STAGING_DIR_HOSTPKG)/bin/glib-mkenums|'
\
$(PKG_BUILD_DIR)/configure.ac
$(SED) 
's|^\(GDBUS_CODEGEN\)=.*|\1=$(STAGING_DIR_HOSTPKG)/bin/gdbus-codegen|'
\
$(PKG_BUILD_DIR)/configure.ac

Why are those lines in the Makefile? This looks like a hack to
workaround some build system error. Are we not using the correct
glib-mkenums or gdbus-codegen from staging if those lines are removed?

Both libmbim and libqmi also use glib-mkenums, and they don't have those lines.

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

RE: [Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

2020-07-07 Thread Amol Lad 
Hi Aleksander, 

After commenting PKG_FIXUP:=autoreconf, I'm getting below error:

CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash 
/home/alad/openwrt/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi/ModemManager-1.14.0/missing
 aclocal-1.16 -I m4
/home/alad/openwrt/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi/ModemManager-1.14.0/missing:
 line 81: aclocal-1.16: command not found

OpenWrt "master" has automake version 1.15.1.

Any suggestion?

Amol

-Original Message-
From: ModemManager-devel  On 
Behalf Of Aleksander Morgado
Sent: Tuesday, 7 July 2020 12:20 PM
To: Nick 
Cc: ModemManager (development) 
Subject: Re: [Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

Hey Nick

> Fixed - Issue was resolved by including autoconf-archive in the Openwrt 
> toolchain, as demonstrated by this commit.
> https://github.com/openwrt/openwrt/commit/3c1d1d4332c7fbaccea01b92b28f
> 6d96f7222492
>

You're being forced to use autoconf-archive in the openwrt setup because the 
ModemManager package in openwrt has:
PKG_FIXUP:=autoreconf

None of libqmi, libmbim, ModemManager should require autoreconf if building 
from a source tarball, only when building from git. By explicitly running 
autoreconf, the build is trying to rebuild the configure script instead of 
using the provided one in the tarball.

I would definitely remove that line if possible. I think it was already removed 
from libqmi and libmbim packages.

--
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
___
ModemManager-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: [Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

2020-07-06 Thread Aleksander Morgado 
Hey Nick

> Fixed - Issue was resolved by including autoconf-archive in the Openwrt 
> toolchain, as demonstrated by this commit.
> https://github.com/openwrt/openwrt/commit/3c1d1d4332c7fbaccea01b92b28f6d96f7222492
>

You're being forced to use autoconf-archive in the openwrt setup
because the ModemManager package in openwrt has:
PKG_FIXUP:=autoreconf

None of libqmi, libmbim, ModemManager should require autoreconf if
building from a source tarball, only when building from git. By
explicitly running autoreconf, the build is trying to rebuild the
configure script instead of using the provided one in the tarball.

I would definitely remove that line if possible. I think it was
already removed from libqmi and libmbim packages.

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

[Resolved] Re: Issue building MM 1.14 on Ubuntu 18.04

2020-07-06 Thread Nick 
Hey, 

Fixed - Issue was resolved by including autoconf-archive in the Openwrt 
toolchain, as demonstrated by this commit.
https://github.com/openwrt/openwrt/commit/3c1d1d4332c7fbaccea01b92b28f6d96f7222492
 


Best,
Nick___
ModemManager-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: Issue building MM 1.14 on Ubuntu 18.04

2020-07-06 Thread Nick 
Oh and my other question is... is it says:
 If this token and others are legitimate, please use m4_pattern_allow.

How can I do that from the MM Makefile?

Best,
Nick___
ModemManager-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Issue building MM 1.14 on Ubuntu 18.04

2020-07-06 Thread Nick 
Hey,

Just having an issue building MM 1.14.0 on Ubuntu 18.04.x (fully updated). I 
have a relatively recent version of /usr/share/aclocal/ax_is_release.m4 on my 
system, and have tried replacing the contents of that file with the most recent 
version of it found on the GNU website also.  The weird part is that I am not 
building from a git repository, I am using the stable release archive, so I am 
not sure why it is trying ot use this in the first place.

Does anyone have any tips or advice to help me troubleshoot further?  By the 
way, it builds fine on Ubuntu 20.04.


Here is a relevant snippet from the build output:

autoreconf: running: /home/nick/code/openwrt/staging_dir/host/bin/autoconf 
--include=/home/nick/code/openwrt/staging_dir/target-mips_24kc_musl/host/share/aclocal
 --include=/home/nick/code/openwrt/staging_dir/hostpkg/share/aclocal 
--include=/home/nick/code/openwrt/staging_dir/target-mips_24kc_musl/usr/share/aclocal
 --include=m4 --include=. 
--prepend-include=/home/nick/code/openwrt/staging_dir/host/share/aclocal --force
configure.ac:75: error: Unexpanded AX_ macro found. Please install GNU 
autoconf-archive
  If this token and others are legitimate, please use m4_pattern_allow.
  See the Autoconf documentation.
configure.ac:76: error: Unexpanded AX_ macro found. Please install GNU 
autoconf-archive
autoreconf: /home/nick/code/openwrt/staging_dir/host/bin/autoconf failed with 
exit status: 1
...
...
...
./configure: line 12855: syntax error near unexpected token `git-directory'
./configure: line 12855: `AX_IS_RELEASE(git-directory)'
Makefile:140: recipe for target 
'/home/nick/code/openwrt/build_dir/target-mips_24kc_musl/ModemManager-1.14.0/.configured_a17fb5ef857664f03cd0ce37cc5ea591'
 failed
make[2]: *** 
[/home/nick/code/openwrt/build_dir/target-mips_24kc_musl/ModemManager-1.14.0/.configured_a17fb5ef857664f03cd0ce37cc5ea591]
 Error 2
make[2]: Leaving directory 
'/home/nick/code/openwrt/feeds/packages/net/modemmanager'
time: package/feeds/packages/modemmanager/compile#6.11#0.81#7.74


Best,
Nick
___
ModemManager-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel