Re: [PATCH 1/3] bearer-mbim: remove a unnecessary MbimMessage variable

[Ben Chan]

All lgtm. Thanks Dan!


On Fri, Feb 2, 2018 at 7:46 AM Dan Williams  wrote:

> On Wed, 2018-01-31 at 21:57 -0800, Ben Chan wrote:
> > ---
> >  src/mm-bearer-mbim.c | 1 -
> >  1 file changed, 1 deletion(-)
>
> All three pushed to git master and mm-1-6.  The backport to 1.6
> required undoing the GTask stuff, so maybe take a quick look and see if
> it all looks OK to you?
>
> Thanks!
>
> Dan
>
>
> > diff --git a/src/mm-bearer-mbim.c b/src/mm-bearer-mbim.c
> > index 949edfbe..4535018b 100644
> > --- a/src/mm-bearer-mbim.c
> > +++ b/src/mm-bearer-mbim.c
> > @@ -830,7 +830,6 @@ connect_context_step (GTask *task)
> >  return;
> >
> >  case CONNECT_STEP_ENSURE_DISCONNECTED: {
> > -MbimMessage *message;
> >  GError *error = NULL;
> >
> >  message = (mbim_message_connect_set_new (
>
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: [PATCH 1/3] bearer-mbim: remove a unnecessary MbimMessage variable

[Dan Williams]

On Wed, 2018-01-31 at 21:57 -0800, Ben Chan wrote:
> ---
>  src/mm-bearer-mbim.c | 1 -
>  1 file changed, 1 deletion(-)

All three pushed to git master and mm-1-6.  The backport to 1.6
required undoing the GTask stuff, so maybe take a quick look and see if
it all looks OK to you?

Thanks!

Dan


> diff --git a/src/mm-bearer-mbim.c b/src/mm-bearer-mbim.c
> index 949edfbe..4535018b 100644
> --- a/src/mm-bearer-mbim.c
> +++ b/src/mm-bearer-mbim.c
> @@ -830,7 +830,6 @@ connect_context_step (GTask *task)
>  return;
>  
>  case CONNECT_STEP_ENSURE_DISCONNECTED: {
> -MbimMessage *message;
>  GError *error = NULL;
>  
>  message = (mbim_message_connect_set_new (
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel