Re: [PATCH] END blocks may segfault

2010-07-02 Thread Alex Hunsaker
>>> On Wed, Jun 30, 2010 at 02:49, Tim Bunce wrote: >>> > I suggest the code shift items off the main array, like perl does, >>> > but also push those items onto a new temp array. Find attached a patch that does the above (perhaps naively), passes a make test and fixes the reported problems for m

Re: [PATCH] END blocks may segfault

2010-07-01 Thread Alex Hunsaker
On Wed, Jun 30, 2010 at 16:37, Tim Bunce wrote: > On Wed, Jun 30, 2010 at 09:24:42AM -0600, Alex Hunsaker wrote: >> On Wed, Jun 30, 2010 at 02:49, Tim Bunce wrote: >> > I suggest the code shift items off the main array, like perl does, >> > but also push those items onto a new temp array. > I pr

Re: [PATCH] END blocks may segfault

2010-06-30 Thread Tim Bunce
On Wed, Jun 30, 2010 at 09:24:42AM -0600, Alex Hunsaker wrote: > On Wed, Jun 30, 2010 at 02:49, Tim Bunce wrote: > > On Tue, Jun 29, 2010 at 09:50:00PM -0700, Fred Moyer wrote: > >> I think getting rid of the segfault is a good thing.  But if the main > >> problem is issues with NYTProf, then it s

Re: [PATCH] END blocks may segfault

2010-06-30 Thread Alex Hunsaker
On Wed, Jun 30, 2010 at 02:49, Tim Bunce wrote: > On Tue, Jun 29, 2010 at 09:50:00PM -0700, Fred Moyer wrote: >> I think getting rid of the segfault is a good thing.  But if the main >> problem is issues with NYTProf, then it seems like this change won't >> solve the core problem of autogenerated

Re: [PATCH] END blocks may segfault

2010-06-30 Thread Tim Bunce
On Tue, Jun 29, 2010 at 09:50:00PM -0700, Fred Moyer wrote: > On Mon, Jun 28, 2010 at 11:15 AM, Alex Hunsaker wrote: > > > Another option would be to copy/local() the array in > > modpler_perl_call_list.  Of course that still wont get it "right" > > because we wont run any newly defined subs... B

Re: [PATCH] END blocks may segfault

2010-06-29 Thread Fred Moyer
On Mon, Jun 28, 2010 at 11:15 AM, Alex Hunsaker wrote: > Hi! > > perl: 5.10.1, 5.12.1 (i686-linux, x86_64-linux) > mod_perl: 2.0.4 > > Basically if you have end blocks that modify/add END blocks things > might go crazy. This sounds like it is similar to something Tim B. brought up a month or so a

[PATCH] END blocks may segfault

2010-06-28 Thread Alex Hunsaker
Hi! perl: 5.10.1, 5.12.1 (i686-linux, x86_64-linux) mod_perl: 2.0.4 Basically if you have end blocks that modify/add END blocks things might go crazy. A simple test case for this is: package test: END { eval "END { }" for 1..10 } gives: Not a CODE reference. END failed--call queue aborted. if