Stas Bekman wrote:
[...]
The attached patch contains the updated Apache__Filter.h and a test
that removes INCLUDES from the output chain and DEFLATE from input.
Excellent. I've massaged both quite a bit to adher to the style and
simplify where it made sense (And found a perl bug in regex qr//m o
Torsten Förtsch wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Friday 22 October 2004 19:10, Stas Bekman wrote:
I thought about it this night and realized that I need not to traverse
these lists at all. At first ist was a try to guess what to call
ap_input_filter_remove or ap_output_filter
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Friday 22 October 2004 19:10, Stas Bekman wrote:
> > I thought about it this night and realized that I need not to traverse
> > these lists at all. At first ist was a try to guess what to call
> > ap_input_filter_remove or ap_output_filter_remove. B
Torsten Förtsch wrote:
but why do you need to traverse all these lists? is it because we don't
know whether the given filter is an input filter or output one? May be
it's easier to attach some flag to the filter object to say which kind of
filter is that?
I thought about it this night and realized
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Friday 22 October 2004 00:38, Stas Bekman wrote:
> Torsten Förtsch wrote:
> > + if( f->c ) {
> > + for( list=f->c->input_filters; list; list=list->next ) {
> > + if( list==f ) {
> > + ap_remove_input_filter(f);
> > +
Torsten Förtsch wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
the attached patch makes Apache::Filter::remove work also for nativ filters.
Why do I need this?
[explanation snipped]
I see no reason why we shouldn't support that.
--- mod_perl-1.99_16/xs/Apache/Filter/Apache__Filter.h~ 2004
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
the attached patch makes Apache::Filter::remove work also for nativ filters.
Why do I need this?
First, from a users point of view it is not very understandable why a mod_perl
filter can be removed but a native filter (eg. INCLUDES) cannot.
My