RE: getting rid of Apache::compat dependency in Apache::DBI

2004-10-22 Thread Joe Thomas
I sent a patch that touches some of the same code a couple months back, and I never got any feedback on it. It fixes a bug where database handles won't get rolled back properly if there's more than one handle in use, because $Idx can only keep track of one handle at a time: http://mathforum.org/

Re: getting rid of Apache::compat dependency in Apache::DBI

2004-10-22 Thread Stas Bekman
Haroon Rafique wrote: On Today at 12:54pm, SB=>Stas Bekman <[EMAIL PROTECTED]> wrote: SB> [..snip..] SB> SB> I think here and below you don't need to do this branching. since the SB> C function mod_perl_push_handlers ignores the first argument, SB> Apache->server->push_handlers() should work jus

Re: getting rid of Apache::compat dependency in Apache::DBI

2004-10-22 Thread Haroon Rafique
On Today at 12:54pm, SB=>Stas Bekman <[EMAIL PROTECTED]> wrote: SB> [..snip..] SB> SB> I think here and below you don't need to do this branching. since the SB> C function mod_perl_push_handlers ignores the first argument, SB> Apache->server->push_handlers() should work just fine under mp1, but

Re: getting rid of Apache::compat dependency in Apache::DBI

2004-10-22 Thread Stas Bekman
Haroon Rafique wrote: Hi, Currently, Apache::DBI's connect_on_init method requires that Apache::compat be loaded or it carps "Apache.pm was not loaded" and returns. Find attached a patch for Apache::DBI which gets rid of the dependency for Apache::compat. While in the process, I also fixed a se