Re: distgen enhancements

2008-02-27 Thread demerphq
On 28/02/2008, David Golden <[EMAIL PROTECTED]> wrote: > On Thu, Feb 14, 2008 at 3:54 AM, Michael G Schwern <[EMAIL PROTECTED]> wrote: > Sorry -- just catching up on this thread. > > > > > { > > >$dir->local_chdir(); > > >...do your stuff... > > > } > > > > > > but that's pro

Re: distgen enhancements

2008-02-27 Thread David Golden
On Thu, Feb 14, 2008 at 3:54 AM, Michael G Schwern <[EMAIL PROTECTED]> wrote: Sorry -- just catching up on this thread. > > { > >$dir->local_chdir(); > >...do your stuff... > > } > > > > but that's probably out of my ken. Subroutine prototype? $dir->do_within { }; Also -- feel

Re: distgen enhancements

2008-02-27 Thread Michael G Schwern
demerphq wrote: File::pushd is simple and a no-frills version can be cut & pasted into Module::Build. I prefer the descriptive local_chdir() over the very Unixy and cryptic pushd(). FYI: Theres nothing unixy about pushd, its been on windows computers for years (it dates back to CED and PCED on

Re: distgen enhancements

2008-02-18 Thread demerphq
On 18/02/2008, demerphq <[EMAIL PROTECTED]> wrote: > On 29/01/2008, Michael G Schwern <[EMAIL PROTECTED]> wrote: > > Eric Wilhelm wrote: > > > Hi Ken, > > > > > > I noticed some traffic in the commits and realized I had this stale > > > patch laying around. > > > > > > I see there are still quite a

Re: distgen enhancements

2008-02-18 Thread demerphq
On 29/01/2008, Michael G Schwern <[EMAIL PROTECTED]> wrote: > Eric Wilhelm wrote: > > Hi Ken, > > > > I noticed some traffic in the commits and realized I had this stale > > patch laying around. > > > > I see there are still quite a few chdir()s in the test suite and thought > > this might be a goo

Re: distgen enhancements

2008-02-17 Thread Eric Wilhelm
# from Michael G Schwern # on Sunday 17 February 2008 11:15: >> Should I just call them chdir and unchdir? > >Go with the patch I proposed to implement a simplified > pushd/local_chdir() for Module::Build internal use. Well, I committed it as chdir_in() and chdir_original(). The local_chdir() w

Re: distgen enhancements

2008-02-17 Thread Michael G Schwern
Eric Wilhelm wrote: # from Michael G Schwern # on Thursday 14 February 2008 00:54: There's already a module to do this, File::pushd, and the sentinel approach is a little wonky. There's also File::chdir for another way to do it. Both will happily accept a Path::Class::Dir so I don't see what'

Re: distgen enhancements

2008-02-16 Thread Eric Wilhelm
# from Michael G Schwern # on Thursday 14 February 2008 00:54: >There's already a module to do this, File::pushd, and the sentinel > approach is a little wonky.  There's also File::chdir for another way > to do it.  Both will happily accept a Path::Class::Dir so I don't see > what's to be gained.

Re: distgen enhancements

2008-02-14 Thread Michael G Schwern
Ken Williams wrote: On Jan 29, 2008 8:34 AM, David Golden <[EMAIL PROTECTED]> wrote: On Jan 29, 2008 3:44 AM, Michael G Schwern <[EMAIL PROTECTED]> wrote: Module::Build. I prefer the descriptive local_chdir() over the very Unixy and cryptic pushd(). I've been thinking about adding a feature

Re: distgen enhancements

2008-01-29 Thread Ken Williams
On Jan 29, 2008 8:34 AM, David Golden <[EMAIL PROTECTED]> wrote: > On Jan 29, 2008 3:44 AM, Michael G Schwern <[EMAIL PROTECTED]> wrote: > > Module::Build. I prefer the descriptive local_chdir() over the very Unixy > > and > > cryptic pushd(). I've been thinking about adding a feature to Path::C

Re: distgen enhancements

2008-01-29 Thread David Golden
On Jan 29, 2008 3:44 AM, Michael G Schwern <[EMAIL PROTECTED]> wrote: > Module::Build. I prefer the descriptive local_chdir() over the very Unixy and > cryptic pushd(). Maybe I should add that as an alias in the next release. David

Re: distgen enhancements

2008-01-29 Thread Michael G Schwern
Eric Wilhelm wrote: Hi Ken, I noticed some traffic in the commits and realized I had this stale patch laying around. I see there are still quite a few chdir()s in the test suite and thought this might be a good way to keep things a little more organized. I think I just hadn't checked it in

Re: DistGen

2007-01-22 Thread Randy W. Sims
Eric Wilhelm wrote: [...] However, it is somewhat inconvenient to need to $dist->regen from the toplevel directory. Is it reasonable for $dist to have a cd_in() cd_out() methods (allowing it to know its current state) and be able to regen() from anywhere? Yes, being able to regenerate from a